From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Enge Subject: Re: [PATCH] distro: Add rsync Date: Fri, 21 Dec 2012 14:17:58 +0100 Message-ID: <201212211417.58622.andreas@enge.fr> References: <201212211147.20203.andreas@enge.fr> <87zk17613l.fsf@karetnikov.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="Boundary-01=_GGG1QEPiKrMoK9j" Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([208.118.235.92]:50365) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tm2UP-00083k-Px for bug-guix@gnu.org; Fri, 21 Dec 2012 08:18:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tm2UI-0002ld-8C for bug-guix@gnu.org; Fri, 21 Dec 2012 08:18:13 -0500 Received: from moutng.kundenserver.de ([212.227.126.187]:63778) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tm2UH-0002lX-UI for bug-guix@gnu.org; Fri, 21 Dec 2012 08:18:06 -0500 In-Reply-To: <87zk17613l.fsf@karetnikov.org> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org To: Nikita Karetnikov , bug-guix@gnu.org --Boundary-01=_GGG1QEPiKrMoK9j Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Am Freitag, 21. Dezember 2012 schrieb Nikita Karetnikov: > 1. Change 'uri' according to this [1] example. What does this change? Especially as it is not done systematically for the files already in the distribution. > 2. Use a single semicolon after expression. [2] Okay, thanks. > 3. It's probably better to say what licenses are used for the other > files. Actually, what is one expected to do concerning licenses? README says: "Rsync may be used, modified and redistributed only under the terms of the GNU General Public License, found in the file COPYING in this distribution" COPYING is GPLv3. So I checked a few files whether this means gpl3 or gpl3+. rsync.c states gpl3+, for example. Some other files have different license statements. There is a subdirectory popt containing a different COPYING (looks like X11 license). The file snprintf.c in the subdirectory lib has: /* * Copyright Patrick Powell 1995 * This code is based on code written by Patrick Powell (papowell@astart.com) * It may be used for any purpose as long as this notice remains intact * on all source code distributions */ There may potentially be as many licenses as files in the distribution (208), that is why I went with only the main statement from the README file. What would good practice be? Andreas --Boundary-01=_GGG1QEPiKrMoK9j Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

Am Freitag, 21. Dezember 2012 schrieb Nikita Karetnikov:

> 1. Change 'uri' according to this [1] example.

 

What does this change? Especially as it is not done systematically

for the files already in the distribution.

 

> 2. Use a single semicolon after expression. [2]

 

Okay, thanks.

 

> 3. It's probably better to say what licenses are used for the other

> files.

 

Actually, what is one expected to do concerning licenses?

README says:

"Rsync may be used, modified and redistributed only under the terms of

the GNU General Public License, found in the file COPYING in this

distribution"

 

COPYING is GPLv3. So I checked a few files whether this means

gpl3 or gpl3+.

 

rsync.c states gpl3+, for example.

 

Some other files have different license statements. There is a subdirectory

popt containing a different COPYING (looks like X11 license).

 

The file snprintf.c in the subdirectory lib has:

/*

* Copyright Patrick Powell 1995

* This code is based on code written by Patrick Powell (papowell@astart.com)

* It may be used for any purpose as long as this notice remains intact

* on all source code distributions

*/

 

There may potentially be as many licenses as files in the distribution

(208), that is why I went with only the main statement from the README

file.

 

What would good practice be?

 

Andreas

 

 

--Boundary-01=_GGG1QEPiKrMoK9j--