bug#57467: [EXT] Re: bug#57467: 'guix shell' does not honor default behavior when given a specific command to run

[Maxime Devos <maximedevos@telenet.be>]

[-- Attachment #1.1.1.1: Type: text/plain, Size: 1684 bytes --]


On 29-08-2022 14:48, Thompson, David wrote:
> Hi Maxime,
>
> On Mon, Aug 29, 2022 at 6:29 AM Maxime Devos <maximedevos@telenet.be> 
> wrote:
>
>     On 29-08-2022 03:28, Thompson, David wrote:
>>     Hi again,
>>
>>     I decided to just implement the fix and see what people think of
>>     it.  Simply removing a check for non-interactive invocation
>>     solves the issue and now 'guix shell' and 'guix shell -- make'
>>     act exactly the same except for which command they run.  Patch
>>     attached.
>>
>     The interactive check is a feature, not a bug:
>
> Could you please explain why it's a feature?
The quoted text was my explanation. Maybe that thread has more 
information, or failing that, maybe the person I quoted knows why.
> I've provided an example that shows how it is confusing and unexpected.
Your example was "guix shell -- ...", not interactive checks in general.
>
>>     https://issues.guix.gnu.org/50960#69:
>>     [...]
>>     Agreed. The automatic reading of guix.scm/manifest.scm, if we
>>     keep it,
>>     should only happen in interactive use; I’ll double-check and make
>>     sure
>>     this is the case.
>     It might still be possible to solve 57467, but I don't think this
>     patch is the solution.
>
>
> Could you propose an alternate solution?  What are the next steps 
> here?  Right now all I know is that you don't like my patch.

Possibly, but try proposing an alternate solution yourself first. And 
you know more than that, you know that the interactive check shouldn't 
be simply removed and have a link to a discussion that may have more 
information.

Greetings,
Maxime


[-- Attachment #1.1.1.2: Type: text/html, Size: 4466 bytes --]

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 929 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]