From: David Truby <David.Truby@arm.com>
To: "m.othacehe@gmail.com" <m.othacehe@gmail.com>
Cc: nd <nd@arm.com>, "32773@debbugs.gnu.org" <32773@debbugs.gnu.org>,
"guix-patches@gnu.org" <guix-patches@gnu.org>
Subject: bug#32773: [PATCH] Fix clang libstdc++ header location search
Date: Thu, 14 Nov 2019 16:16:17 +0000 [thread overview]
Message-ID: <1d43f450c61f3c3f27ae895ea4c9e61b55d6fb08.camel@arm.com> (raw)
In-Reply-To: <871rua60fl.fsf@gmail.com>
Hi Mathieu,
Applying both your patch and my patch works for me, in both pure and
non-pure environments. I would suggest taht we also hide clang in the
same way as gcc is hidden (in favour of clang-toolchain) to avoid
confusion, but otherwise it seems these two patches together at least
get things to a working state!
I'd like to see make-clang-toolchain allow you to pick between a
specific libstdc++ or libc++, but that requires more thinking so I
think ideally it'd be better to apply these patches first to get things
to a fixed state.
Thanks
David Truby
On Thu, 2019-11-14 at 14:40 +0100, Mathieu Othacehe wrote:
> > I think adding gcc-toolchain to propagated-inputs should work in
> > principle, other than the fact that the gcc used for gcc-lib and
> > libstdc++ need to be the same as the propagated gcc-toolchain. I
> > did
> > have a fix for this but I'm not sure if it's the best way of
> > writing
> > it.
> > I'll send another patch with the fix though so at least others can
> > comment on it!
>
> Yes propagating gcc-toolchain would work but, would also cause gcc to
> be
> available as a side effect. Maybe the patch attached, on top of
> yours,
> would work?
>
> Thanks,
>
> Mathieu
next prev parent reply other threads:[~2019-11-14 16:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-19 18:23 bug#32773: clang: missing default include paths for C++ Tim Gesthuizen
2018-09-19 18:33 ` Pjotr Prins
2018-09-19 18:47 ` Tim Gesthuizen
2018-10-08 13:51 ` fis trivial
2018-09-22 0:58 ` Robin Templeton
2018-09-23 17:10 ` Tim Gesthuizen
2019-11-13 16:56 ` bug#32773: [PATCH] Fix clang libstdc++ header location search David Truby
2019-11-13 19:50 ` Carl Dong
2019-11-14 10:30 ` Mathieu Othacehe
2019-11-14 13:22 ` David Truby
2019-11-14 13:40 ` Mathieu Othacehe
2019-11-14 16:16 ` David Truby [this message]
2019-11-14 16:54 ` Mathieu Othacehe
2019-11-14 17:03 ` David Truby
2019-11-15 8:42 ` Mathieu Othacehe
2019-11-17 11:21 ` Mathieu Othacehe
2019-11-19 13:08 ` David Truby
2019-11-19 15:30 ` Mathieu Othacehe
2019-11-17 19:29 ` Ludovic Courtès
2019-11-17 19:23 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d43f450c61f3c3f27ae895ea4c9e61b55d6fb08.camel@arm.com \
--to=david.truby@arm.com \
--cc=32773@debbugs.gnu.org \
--cc=guix-patches@gnu.org \
--cc=m.othacehe@gmail.com \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).