From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id GCoEBSCyWmOGgQEAbAwnHQ (envelope-from ) for ; Thu, 27 Oct 2022 18:30:24 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 0MgwBCCyWmPaCAEAG6o9tA (envelope-from ) for ; Thu, 27 Oct 2022 18:30:24 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A6AC21BA0 for ; Thu, 27 Oct 2022 18:30:23 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oo5ke-0007Vf-5Q; Thu, 27 Oct 2022 12:29:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oo5kd-0007Gr-2a for bug-guix@gnu.org; Thu, 27 Oct 2022 12:29:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oo5kc-00081M-Qw for bug-guix@gnu.org; Thu, 27 Oct 2022 12:29:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oo5kc-0001tG-LP for bug-guix@gnu.org; Thu, 27 Oct 2022 12:29:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#58813: can't substitute etc/teams.scm command as doc suggests Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Thu, 27 Oct 2022 16:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58813 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Maxim Cournoyer Cc: 58813@debbugs.gnu.org Received: via spool by 58813-submit@debbugs.gnu.org id=B58813.16668880847176 (code B ref 58813); Thu, 27 Oct 2022 16:29:02 +0000 Received: (at 58813) by debbugs.gnu.org; 27 Oct 2022 16:28:04 +0000 Received: from localhost ([127.0.0.1]:59104 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oo5jf-0001rg-JP for submit@debbugs.gnu.org; Thu, 27 Oct 2022 12:28:04 -0400 Received: from mail-ej1-f67.google.com ([209.85.218.67]:44896) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oo5jd-0001rB-2V for 58813@debbugs.gnu.org; Thu, 27 Oct 2022 12:28:02 -0400 Received: by mail-ej1-f67.google.com with SMTP id n12so6121154eja.11 for <58813@debbugs.gnu.org>; Thu, 27 Oct 2022 09:28:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=ZzXKUu1ypD0q1tSSeZ1cZI/PQ+kzH+I6IJ47IWiCiZA=; b=NY03T1jwnHOlBNtaOi2bvek+xaqp5FYTPzFNJtfgN3SztYoiZw4xK4V9HzFNTK7YTI JmsygY0jpUvnb2/lmTy5yas3PaOmalzGqkdV18O6g0f2oRslchv2Ylofxa6qs0tEo/BS 2qEzSLzBji9vR4wd6OqZ3GHo1wWlnBnUj7kaqOfjQtKxUa3nA+BA8dujFQtbzLatWI4I H63yxmFKc/jZmrpO725qZ7F9euysa6zWrC6TuubMf47LNNJiPvsrUfKby/tGVNZMlROA rYPcWCBheagJ/WBdntz/BSdaamhOA+tllxuvpi6xzUqpCBuZe68F7Y9tZ+rnvBZ7hPZn u38g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ZzXKUu1ypD0q1tSSeZ1cZI/PQ+kzH+I6IJ47IWiCiZA=; b=5N3prfgcohI4qEY7jB2KtOfN8vXlfHSHwWoNi4AytrPYz7ovh4GV9yuksJT/OIp6la w0jAI6vDOxEOF8eccKh9387N7kJ8gkykjWT7Xxoj8242ecyE6NQj8z6rRva02vqs+JLV pdLlV8iCbK/J0cZ4jgX15N2yjnPu4G4dOFT+UF/8ZYxtwyj6ZmzvD7b+VNpXYmdYhFg7 D8l4RjQCOkKQ9cse8oLcRVheO0/Eijf3xZusYnMdkbtAy4TOHIXD2Oz9Jd/bbImbXAn2 ftJtN8ryejsvg9yBdeENFckgJ0SBJ5mV88UmlVFi4BBlx7gWDyHhmuJGsbIUYNyekVlQ avmg== X-Gm-Message-State: ACrzQf1RfM6pB1RTRxDeMynhYoAdJ6CXLciPJEOx/4KqzrF2NBzev60C edn3bFU7vVALqnV/uyZ3Jp0= X-Google-Smtp-Source: AMsMyM7OgPcgpraEYXp7GgfKcPk3XDZ68ACsx4qBs0c1YcwOdlUl0WCnEEqkC+OR2sJ9+KT3H70NwQ== X-Received: by 2002:a17:907:c27:b0:791:81f2:f2b1 with SMTP id ga39-20020a1709070c2700b0079181f2f2b1mr43239918ejc.436.1666888073845; Thu, 27 Oct 2022 09:27:53 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id g10-20020a17090604ca00b0078d46aa3b82sm1023155eja.21.2022.10.27.09.27.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Oct 2022 09:27:53 -0700 (PDT) Message-ID: <1af5b004bf08bdb954dd7f924b6aa1dbb563c075.camel@gmail.com> From: Liliana Marie Prikler Date: Thu, 27 Oct 2022 18:27:51 +0200 In-Reply-To: <87lep1qw1s.fsf@gmail.com> References: <87r0yuq615.fsf@gmail.com> <05f449076bd7fd65f3cd301cbed4101490b3b2db.camel@gmail.com> <87lep1qw1s.fsf@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.0 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "bug-Guix" Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1666888223; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=ZzXKUu1ypD0q1tSSeZ1cZI/PQ+kzH+I6IJ47IWiCiZA=; b=BHU/Wk5UmZpvOCKYE7+0douNOZrF2pVvlLjR5LwWnQnKL7IDuHNOSKwji3LiZYExXl05yT fqoL41FQ+SvXeeK/8RmI0WWuoP6+WLMLYtUjK7chLquS6pGQq2GlWDcechKvPU3HKsBQVZ DGG+F+a3XaVNt3cQhgRjcurtYsB1IHZWUifosOLKJ99MfvEFZHZl6naeIgMDIWgrFQjKn+ KyWpR9bVzxQ12ikNqnYgID6MGA57Jgkcq6iM3VDOa4/LhBghu55QyhjCkRwR8ODSfh2PL2 uvxQIdSNrTm8IIeAfPfsPF7fr2YpcQ96WaxuCZFIFe2bvy02YSMEPxDp93JvUQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1666888223; a=rsa-sha256; cv=none; b=le+tiIcQZ0vBGfKyLhQuwvTiNqxEwDKLexT/C9D33fLy18G8PiU+yNlg8BBQGCVtllPO/M HOUo6/Yk7zgHMXu+h7Nj0mnbpgkrUyW6gp3NYw/dFsWtZcB1PU3DC+eYuenjMFUwwR/Q4b OP+aZ9/6rhATlBRCu8bYWl8Ch2t/ghpJSXyV4tlSLfkBPje+Z4pBs1N9nFmWNYD10ZR1F9 hq7d8B1ewJTQ/rcmq9U6Qrqhqmv1GwTWNj+CEFVXY6JmnycrwtBu0GdeMCzvld43+/iZvd NhIfaXToQx6ilfhxw1/g65tsXKfFe6WTGfjoyK+tvgWlvG+IQzdacOLRNQhkXw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=NY03T1jw; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 6.48 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=NY03T1jw; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: A6AC21BA0 X-Spam-Score: 6.48 X-Migadu-Scanner: scn0.migadu.com X-TUID: pLTYiCmFk7VU Am Donnerstag, dem 27.10.2022 um 08:40 -0400 schrieb Maxim Cournoyer: > Hi, >=20 > Liliana Marie Prikler writes: >=20 > > Am Mittwoch, dem 26.10.2022 um 23:50 -0400 schrieb Maxim Cournoyer: > > > Hi, > > >=20 > > > Today, I tried; > > >=20 > > > --8<---------------cut here---------------start------------->8--- > > > $ git send-email --to=3Dguix-patches@gnu.org=C2=A0\ > > > =C2=A0 $(./etc/teams.scm cc-members origin/master HEAD) 0000-cover- > > > letter.patch > > > fatal: ambiguous argument 'some.email@redacted.com"': unknown > > > revision or path not in the working tree. > > > Use '--' to separate paths from revisions, like this: > > > 'git [...] -- [...]' > > > format-patch -o /tmp/pFSRbRNNoU --add-header=3D"X-Debbugs-Cc: > > > redacted@gmail.com" --add-header=3D"X-Debbugs-Cc: redacted@email" > > > [...]: command returned error: 128 > > >=20 > > > $ ./etc/teams.scm cc-members origin/master HEAD > > > --add-header=3D"X-Debbugs-Cc: redacted@email" --add-header=3D"X- > > > Debbugs- > > > Cc: redacted@email" ... > > > --8<---------------cut here---------------end--------------->8--- > > >=20 > > > You can see the command fails; this is because when using Bash > > > command substitution $(), the quotes in the result are not > > > interpreted and are thus part of the value (literals), which then > > > gets split on white space. > > >=20 > > > As a quick hacky fix,=C2=A0 I tried removing the space and double > > > quotes > > > like: > > >=20 > > > modified=C2=A0=C2=A0 etc/teams.scm.in > > > @@ -514,7 +514,7 @@ (define (cc . teams) > > > =C2=A0=C2=A0 "Return arguments for `git send-email' to notify the mem= bers > > > of > > > the given > > > =C2=A0TEAMS when a patch is received by Debbugs." > > > =C2=A0=C2=A0 (format #true > > > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "~{--add-head= er=3D\"X-Debbugs-Cc: ~a\"~^ ~}" > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "~{--add-head= er=3DX-Debbugs-Cc:~a~^ ~}" > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (map per= son-email > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 (delete-duplicates (append-map team-members > > > teams) > > > equal?)))) > > >=20 > > > and sent a patch with that command: > > >=20 > > > git send-email --to=3Dguix-patches@gnu.org=C2=A0\ > > > =C2=A0 $(./etc/teams.scm cc-members origin/master HEAD 0000-cover- > > > letter.patch > > >=20 > > > It created https://issues.guix.gnu.org/58812=C2=A0with it, but I don'= t > > > see > > > any of the X-Debbugs-Cc headers.=C2=A0 Mmmh. > > Note that the existing etc/teams also assumes there are no funny > > characters in the quote.=C2=A0 So it's susceptible to good ol' bobby > > tables. > >=20 > > Could we, instead of outputting a command, make it so that we can > > pass > > an already formatted patch and etc/teams rewrites it? >=20 > The solution suggested to me in #bash would be to turn etc/teams.scm > into a git wrapper, that could invoke git with all the arguments at > once (allowing people to pass arguments themselves).=C2=A0 I'm told the > git completion could be hooked to such script so that users can still > enjoy git tab-completion when using etc/teams.scm, although I haven't > researched how that'd all work. >=20 > A similar idea proposed by selckin on #git would be to have our > etc/teams.scm script receive the complete git command, and append the > args to it itself (and invoke it), like so: >=20 > ./etc/teams.scm cc mentors -- git send-email --to > XXX@debbugs.gnu.org=C2=A0*.patch I think we should go with the former and implement a proper "guix send- email" ;)