From mboxrd@z Thu Jan  1 00:00:00 1970
From: nee <nee@cock.li>
Subject: bug#28602: Unpack fails with no error message when using a .zip source
Date: Mon, 9 Oct 2017 23:05:02 +0200
Message-ID: <1771470d-8b9a-a516-7da2-6532432955a4@cock.li>
References: <2c2ccbd7-bb47-5292-74d9-e4c7fdc2c990@cock.li>
	<87wp4abwwm.fsf@hyperbola.info>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56258)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1e1fFW-00045z-7B
	for bug-guix@gnu.org; Mon, 09 Oct 2017 17:06:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1e1fFS-0005vA-Uf
	for bug-guix@gnu.org; Mon, 09 Oct 2017 17:06:06 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:50034)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1e1fFS-0005v2-PZ
	for bug-guix@gnu.org; Mon, 09 Oct 2017 17:06:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1e1fFS-0000Pd-Hy
	for bug-guix@gnu.org; Mon, 09 Oct 2017 17:06:02 -0400
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.28602.B28602.15075831091524@debbugs.gnu.org>
In-Reply-To: <87wp4abwwm.fsf@hyperbola.info>
Content-Language: en-GB
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: Adonay Felipe Nogueira <adfeno@hyperbola.info>
Cc: 28602@debbugs.gnu.org

Am 04.10.2017 um 20:17 schrieb Adonay Felipe Nogueira:
> Does the .zip file have a a single directory on the root?
> 
> If not, then we can call it a zipbomb/tarbomb. These bombs are bad
> because they can replace things without notice, and can be very
> difficult to track what was added. Last time I checked Guix expects only
> a single directory in the root of the file --- this might have changed,
> but I didn't test it since one year ago.

Hello, this is a different problem. Tarbombs are still a problem, but
unrelated to this.

The gnu-build-system does not have unzip by default. If a package's
source comes in a zip the package must have unzip as native-input. If it
isn't the (system* "unzip" source) call in the unpack function will fail
because there is no unzip executable.

Happy hacking!