From: Tanguy LE CARROUR <tanguy@bioneland.org>
To: "Ludovic Courtès" <ludovic.courtes@inria.fr>
Cc: Sharlatan Hellseher <sharlatanus@gmail.com>,
Munyoki Kilyungi <me@bonfacemunyoki.com>,
Lars-Dominik Braun <lars@6xq.net>, jgart <jgart@dismail.de>,
Marius Bakke <marius@gnu.org>,
69997@debbugs.gnu.org
Subject: bug#69997: Should ‘guix import pypi’ get dependencies from pyproject files?
Date: Tue, 26 Mar 2024 18:14:10 +0100 [thread overview]
Message-ID: <171147325018.15415.4526491903307851998@bioneland.org> (raw)
In-Reply-To: <171147212395.13452.3553266600176809571@bioneland.org>
Hi,
Quoting Tanguy LE CARROUR (2024-03-26 17:55:23)
> Quoting Ludovic Courtès (2024-03-26 17:04:52)
> > Tanguy LE CARROUR <tanguy@bioneland.org> skribis:
> > > So, my answer would be: do not import from PyPI! Yes, I know, it’s radical! 😅
> > > But if you have to, rely on the wheel’s `METADATA` file.
> > >
> > > I hope this make sense. … I’m not really sure any more! 😅
> >
> > It does!
> >
> > But then I mean, we could offer, say, ‘guix import upstream https://…’,
> > and that thing could parse ‘setup.py’ or similar to produce a package
> > definition from that.
> […]
> So I would say… let’s wait and see what the others think. In the
> meantime, I’ll have to dive deeper in the PEP and the actual importer
> code.
According to PEP 427 [1] a.k.a. Binary distribution format [2], if you
go for packaged/PyPI then we should go for `METADATA`.
[1]: https://peps.python.org/pep-0427/
[2]: https://packaging.python.org/en/latest/specifications/binary-distribution-format/#the-dist-info-directory
But, as stated earlier, we should build from source, to make sure we can
run the test suite. Active projects should slowly migrate to PEP 517 [3]
`pyproject.toml`. But, this is not a solution! 😱 This is actually yet
another problem! 😵
[3]: https://peps.python.org/pep-0517/
Each build system relies on it’s own file organization. For instance, Poetry
looks for a `[tool.poetry.dependencies]` section in the file. So the
importer should be "build system aware", which leads us to… `guix import poetry URL`!?
Not really generic any more! 😞
I guess we should sleep on it…
--
Tanguy
next prev parent reply other threads:[~2024-03-26 17:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-25 11:06 bug#69997: Should ‘guix import pypi’ get dependencies from pyproject files? Ludovic Courtès
2024-03-25 19:28 ` Sharlatan Hellseher
2024-03-26 7:54 ` Tanguy LE CARROUR
2024-03-26 16:04 ` Ludovic Courtès
2024-03-26 16:55 ` Tanguy LE CARROUR
2024-03-26 17:14 ` Tanguy LE CARROUR [this message]
2024-03-28 18:09 ` Ludovic Courtès
2024-03-29 7:46 ` Tanguy LE CARROUR
2024-03-29 9:06 ` Ludovic Courtès
2024-03-29 10:11 ` Tanguy LE CARROUR
2024-03-27 6:49 ` Lars-Dominik Braun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171147325018.15415.4526491903307851998@bioneland.org \
--to=tanguy@bioneland.org \
--cc=69997@debbugs.gnu.org \
--cc=jgart@dismail.de \
--cc=lars@6xq.net \
--cc=ludovic.courtes@inria.fr \
--cc=marius@gnu.org \
--cc=me@bonfacemunyoki.com \
--cc=sharlatanus@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).