From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: 1016546@bugs.debian.org, 56893@debbugs.gnu.org,
Maxime Devos <maximedevos@telenet.be>
Subject: bug#56893: [Pkg-rust-maintainers] Bug#1016546: rust-vergen inserts build timestamps
Date: Wed, 03 Aug 2022 09:09:54 +0200 [thread overview]
Message-ID: <1659510404.ppd071f89s.astroid@nora.none> (raw)
In-Reply-To: <22fbd85d-9f0e-64f8-98d6-972a0f7c9219@telenet.be>
On August 2, 2022 10:16 pm, Maxime Devos wrote:
> On 02-08-2022 20:41, Geert Stappers wrote:
>
>> Date: Tue, 2 Aug 2022 19:18:46 +0200, From: Maxime Devos
>>> In Guix, I've noticed that rust-vergen embeds build timestamps. There is also
>>> a work-around available: <https://issues.guix.gnu.org/56893#1>.
>>
>>
>> Thanks for reporting the FTBR.
>>
>> Please update the workaround, so it looks more
>> like https://en.wikipedia.org/wiki/Diff#Unified_format
>> and can be absured by https://en.wikipedia.org/wiki/Patch_(Unix)
>>
>>
>> Just telling the filename that needs modification would be a great help.
>
> Oops, I did not send the full work-around, here it is:
>
>> (substitute* (find-files "." "\\.rs$")
>> (("^extern crate chrono;") "extern crate chrono; use
>> chrono::Utc; use chrono::TimeZone;")
>> (("^use chrono::Utc;") "use chrono::Utc; use
>> chrono::TimeZone;")
>> (("\\bUtc::now\\(\\)") "Utc.timestamp(0, 0)"))))))
> (Should hopefully be clearer now!)
>
> The important thing here is replacing all instances of Utc::now()
> (across all Rust source files of rust-vergen) by Utc.timestamp(0, 0),
> the rest is just adding the required imports -- I have not made a list
> of all file names. If you want a list, try "grep -rF Utc::now" or such.
>
> I do not intend to update the workaround, it works fine in Guix and
> frankly porting it to whatever format Debian likes is Debian's concern,
> not Guix', I'm just sharing our workaround as a courtesy to another distro.
also note that for debian purposes, we likely want to honor
SOURCE_DATE_EPOCH instead of setting it to epoch zero.
prev parent reply other threads:[~2022-08-03 9:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220802174658.jzawpmxvx2abwebo@gpm.stappers.nl>
[not found] ` <20220802184151.hxy5a4ua6rx5ukem@gpm.stappers.nl>
2022-08-02 20:16 ` bug#56893: rust-vergen inserts build timestamps Maxime Devos
2022-08-03 7:09 ` Fabian Grünbichler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1659510404.ppd071f89s.astroid@nora.none \
--to=f.gruenbichler@proxmox.com \
--cc=1016546@bugs.debian.org \
--cc=56893@debbugs.gnu.org \
--cc=maximedevos@telenet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).