From: Brendan Tildesley <mail@brendan.scot>
To: 48967@debbugs.gnu.org
Subject: bug#48967: No newline after substitution of ~a complete line.
Date: Sat, 12 Jun 2021 08:07:17 +0200 (CEST) [thread overview]
Message-ID: <1520066429.101148.1623478037139@office.mailbox.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 476 bytes --]
I get output that looks like this:
substitution of /gnu/store/g26z8hhqagcsiwz611jwhyj7rk6zywqg-python-pybigwig-0.3.17 completesubstituting /gnu/store/slxjk0sg8q85qk0l0dv5kv71z2l4pgv2-python-pybrowserid-0.14.0...
downloading from https://ci.guix.gnu.org/nar/lzip/slxjk0sg8q85qk0l0dv5kv71z2l4pgv2-python-pybrowserid-0.14.0 ...
Also, could the value of (simultaneous-jobs status) change between invocations in the code? It's ok not to use let?
Adding a newline seems to fix it.
[-- Attachment #2: 0001-status-Add-missing-newline.patch --]
[-- Type: text/x-patch, Size: 1026 bytes --]
From a2628f0565e0428af55ada53ac3826e9a855b022 Mon Sep 17 00:00:00 2001
From: Brendan Tildesley <mail@brendan.scot>
Date: Sat, 12 Jun 2021 15:58:13 +1000
Subject: [PATCH] status: Add missing (newline).
* guix/status.scm: Add newline after substitution complete line.
---
guix/status.scm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/guix/status.scm b/guix/status.scm
index 1164c2a6e3..f351a56d92 100644
--- a/guix/status.scm
+++ b/guix/status.scm
@@ -558,7 +558,8 @@ substitutes being downloaded."
;; If there are no jobs running, we already reported download completion
;; so there's nothing left to do.
(unless (zero? (simultaneous-jobs status))
- (format port (success (G_ "substitution of ~a complete")) item))
+ (format port (success (G_ "substitution of ~a complete")) item)
+ (newline port))
(when (and print-urls? (zero? (simultaneous-jobs status)))
;; Leave a blank line after the "downloading ..." line and the
--
2.31.1
reply other threads:[~2021-06-12 6:08 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1520066429.101148.1623478037139@office.mailbox.org \
--to=mail@brendan.scot \
--cc=48967@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).