unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Cyril Roelandt <tipecaml@gmail.com>
To: bug-guix@gnu.org
Subject: [PATCH] gnu: add dependencies to poppler.
Date: Sun, 24 Mar 2013 21:08:52 +0100	[thread overview]
Message-ID: <1364155732-2031-1-git-send-email-tipecaml@gmail.com> (raw)

Add libpng and zlib to the inputs.
---
Hello!

This patch is quite simple. It adds both libpng (which  was already available
in Guix) and zlib (which has to be explicitely enabled) to poppler. Note that
zlib is not enabled by default, even if it is found on the system, because it
is "not safe" according to the poppler developers. Andreas, do you know why ?
Maybe we should remove it from the dependencies.

I also listed the dependencies that are not yet satisfied. I think I will take
care of libopenjpeg soon, but it requires cmake, and I'd rather write a cmake
build system first.

Cyril.

 gnu/packages/pdf.scm |   13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/pdf.scm b/gnu/packages/pdf.scm
index 5a9d513..a172414 100644
--- a/gnu/packages/pdf.scm
+++ b/gnu/packages/pdf.scm
@@ -25,6 +25,7 @@
   #:use-module (gnu packages compression)
   #:use-module (gnu packages fontutils)
   #:use-module (gnu packages libjpeg)
+  #:use-module (gnu packages libpng)
   #:use-module (gnu packages libtiff)
   #:use-module (gnu packages pkg-config))
 
@@ -40,15 +41,25 @@
                      "1rmrspavldlpqi6g76fijcmshy80m0kxd01nc1dmy4id3h4las44"))))
    (build-system gnu-build-system)
    ;; FIXME: more dependencies could  be added
+   ;;  cairo output:       no (requires cairo >= 1.10.0)
+   ;;  qt4 wrapper:        no
+   ;;  glib wrapper:       no (requires cairo output)
+   ;;    introspection:    no
+   ;;  use gtk-doc:        no
+   ;;  use libcurl:        no
+   ;;  use libopenjpeg:    no
    (inputs `(("fontconfig" ,fontconfig)
              ("freetype" ,freetype)
              ("libjpeg-8" ,libjpeg-8)
+             ("libpng" ,libpng)
              ("libtiff" ,libtiff)
              ("pkg-config" ,pkg-config)
              ("zlib" ,zlib)))
    (arguments
     `(#:tests? #f ; no test data provided with the tarball
-      #:configure-flags '("--enable-xpdf-headers"))) ; to install header files
+      #:configure-flags
+       '("--enable-xpdf-headers" ; to install header files
+         "--enable-zlib")))
    (synopsis "Poppler, a pdf rendering library")
    (description
     "Poppler is a PDF rendering library based on the xpdf-3.0 code base.")
-- 
1.7.10.4

             reply	other threads:[~2013-03-24 20:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-24 20:08 Cyril Roelandt [this message]
2013-03-25 10:55 ` [PATCH] gnu: add dependencies to poppler Ludovic Courtès
2013-03-28 19:20 ` Andreas Enge
2013-03-28 20:39   ` Cyril Roelandt
2013-03-28 21:26     ` Andreas Enge
2013-03-28 22:15       ` Cyril Roelandt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1364155732-2031-1-git-send-email-tipecaml@gmail.com \
    --to=tipecaml@gmail.com \
    --cc=bug-guix@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).