unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
blob 1269e0759327ef9601f0159c58449412ca3e330a 7975 bytes (raw)
name: gnu/packages/valgrind.scm 	 # note: path name is non-authoritative(*)

  1
  2
  3
  4
  5
  6
  7
  8
  9
 10
 11
 12
 13
 14
 15
 16
 17
 18
 19
 20
 21
 22
 23
 24
 25
 26
 27
 28
 29
 30
 31
 32
 33
 34
 35
 36
 37
 38
 39
 40
 41
 42
 43
 44
 45
 46
 47
 48
 49
 50
 51
 52
 53
 54
 55
 56
 57
 58
 59
 60
 61
 62
 63
 64
 65
 66
 67
 68
 69
 70
 71
 72
 73
 74
 75
 76
 77
 78
 79
 80
 81
 82
 83
 84
 85
 86
 87
 88
 89
 90
 91
 92
 93
 94
 95
 96
 97
 98
 99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
 
;;; GNU Guix --- Functional package management for GNU
;;; Copyright © 2013, 2014, 2022 Ludovic Courtès <ludo@gnu.org>
;;; Copyright © 2015 Andreas Enge <andreas@enge.fr>
;;; Copyright © 2015 Mark H Weaver <mhw@netris.org>
;;; Copyright © 2016, 2020, 2022 Efraim Flashner <efraim@flashner.co.il>
;;; Copyright © 2018 Tobias Geerinckx-Rice <me@tobias.gr>
;;; Copyright © 2020 Marius Bakke <marius@gnu.org>
;;; Copyright © 2022 Denis Carikli <GNUtoo@cyberdimension.org>
;;;
;;; This file is part of GNU Guix.
;;;
;;; GNU Guix is free software; you can redistribute it and/or modify it
;;; under the terms of the GNU General Public License as published by
;;; the Free Software Foundation; either version 3 of the License, or (at
;;; your option) any later version.
;;;
;;; GNU Guix is distributed in the hope that it will be useful, but
;;; WITHOUT ANY WARRANTY; without even the implied warranty of
;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
;;; GNU General Public License for more details.
;;;
;;; You should have received a copy of the GNU General Public License
;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.

(define-module (gnu packages valgrind)
  #:use-module (guix build-system gnu)
  #:use-module (guix download)
  #:use-module (guix gexp)
  #:use-module (guix licenses)
  #:use-module (guix packages)
  #:use-module (guix utils)
  #:use-module (gnu packages)
  #:use-module (gnu packages base)
  #:use-module (gnu packages gdb)
  #:use-module (gnu packages perl))

(define-public valgrind
  (package
    (name "valgrind")
    ;; Note: check "guix refresh -l -e '(@ (gnu packages valgrind) valgrind)'"
    ;; when updating this package to find which branch it should go to.
    (version "3.17.0")
    (source (origin
              (method url-fetch)
              (uri (list (string-append "https://sourceware.org/pub/valgrind"
                                        "/valgrind-" version ".tar.bz2")
                         (string-append "ftp://sourceware.org/pub/valgrind"
                                        "/valgrind-" version ".tar.bz2")))
              (sha256
               (base32
                "18l5jbk301j3462gipqn9bkfx44mdmwn0pwr73r40gl1irkfqfmd"))
              (patches (search-patches "valgrind-enable-arm.patch"))))
    (build-system gnu-build-system)
    (outputs '("doc"                              ;16 MB
               "out"))
    (arguments
     `(,@(if (string-prefix? "powerpc" (or (%current-target-system)
                                           (%current-system)))
           `(#:make-flags '("CFLAGS+=-maltivec"))
           '())
       #:phases
       (modify-phases %standard-phases
         (add-after 'install 'patch-suppression-files
           (lambda* (#:key outputs #:allow-other-keys)
             ;; Don't assume the FHS.
             (let* ((out (assoc-ref outputs "out"))
                    (dir (string-append out "/lib/valgrind")))
               (substitute* (find-files dir "\\.supp$")
                 (("obj:/lib") "obj:*/lib")
                 (("obj:/usr/X11R6/lib") "obj:*/lib")
                 (("obj:/usr/lib") "obj:*/lib"))
               #t)))
         (add-after 'install 'install-doc
           (lambda* (#:key outputs #:allow-other-keys)
             (let ((orig (format #f "~a/share/doc" (assoc-ref outputs "out")))
                   (dest (format #f "~a/share" (assoc-ref outputs "doc"))))
               (mkdir-p dest)
               (rename-file orig dest)
               #t))))))
    (native-inputs
     (list perl))
    (home-page "https://www.valgrind.org/")
    (synopsis "Debugging and profiling tool suite")
    (description
     "Valgrind is an instrumentation framework for building dynamic analysis
tools.  There are Valgrind tools that can automatically detect many memory
management and threading bugs, and profile your programs in detail.  You can
also use Valgrind to build new tools.")
    ;; https://valgrind.org/info/platforms.html
    (supported-systems (delete "riscv64-linux" %supported-systems))
    (license gpl2+)

    ;; Hide this variant so end users get the "interactive" Valgrind below.
    (properties '((hidden? . #t)))))

(define-public valgrind/interactive
  (package/inherit
   valgrind
   (version "3.17.0")
   (source (origin
             (method url-fetch)
             (uri (list (string-append "https://sourceware.org/pub/valgrind"
                                       "/valgrind-" version ".tar.bz2")
                        (string-append "ftp://sourceware.org/pub/valgrind"
                                       "/valgrind-" version ".tar.bz2")))
             (sha256
              (base32
               "18l5jbk301j3462gipqn9bkfx44mdmwn0pwr73r40gl1irkfqfmd"))
             (patches (search-patches
                       "valgrind-enable-arm.patch"
                       "valgrind-fix-default-debuginfo-path.patch"))))
   (inputs
    ;; GDB is needed to provide a sane default for `--db-command'.
    `(("gdb" ,gdb)
      ("glibc:debug" ,(canonical-package glibc) "debug")))
   (arguments
     (substitute-keyword-arguments (package-arguments valgrind)
       ((#:phases those-phases #~%standard-phases)
        #~(let* ((those-phases #$those-phases)
                 (unpack (assoc-ref those-phases 'unpack)))
            (modify-phases
              those-phases
                (add-before 'configure 'patch-default-debuginfo-path
                  (lambda _
                    ;; This helps Valgrind find the debug symbols of ld.so.
                    ;; Without it, Valgrind does not work in a Guix shell
                    ;; container and cannot be used as-is during packages tests
                    ;; phases
                    (substitute* '
                      ("coregrind/m_debuginfo/readelf.c"
                       "docs/xml/manual-core-adv.xml"
                       "docs/xml/manual-core.xml")
                      (("DEFAULT_DEBUGINFO_PATH")
                       (string-append (assoc-ref %build-inputs "glibc:debug")
                                      "/lib/debug")))
                    ;; We also need to account for the bigger path in
                    ;; the malloc-ed variables
                    (substitute* '
                     ("coregrind/m_debuginfo/readelf.c")
                     (("DEBUGPATH_EXTRA_BYTES_1")
                      (number->string
                       (+ (string-length
                           (string-append
                            (assoc-ref %build-inputs "glibc:debug")
                            "/lib/debug"))
                          (string-length "/.build-id//.debug")
                          1))))
                    (substitute* '
                     ("coregrind/m_debuginfo/readelf.c")
                     (("DEBUGPATH_EXTRA_BYTES_2")
                      (number->string
                       (+ (string-length
                           (string-append
                            (assoc-ref
                             %build-inputs
                             "glibc:debug")
                            "/lib/debug"))
                          (string-length
                           "/usr/lib/debug")
                          1)))))))))))
   (properties '())))

(define-public valgrind-3.18
  (package
    (inherit valgrind/interactive)
    (version "3.18.1")
    (source (origin
              (method url-fetch)
              (uri (list (string-append "https://sourceware.org/pub/valgrind"
                                        "/valgrind-" version ".tar.bz2")
                         (string-append "ftp://sourceware.org/pub/valgrind"
                                        "/valgrind-" version ".tar.bz2")))
              (sha256
               (base32
                "1xgph509i6adv9w2glviw3xrmlz0dssg8992hbvxsbkp7ahrm180"))
              (patches (search-patches "valgrind-enable-arm.patch"
                                       "valgrind-fix-default-debuginfo-path.patch"))))))

debug log:

solving 1269e07593 ...
found 1269e07593 in https://yhetil.org/guix-bugs/20220426013913.20117-3-GNUtoo@cyberdimension.org/
found 6648f17dfa in https://git.savannah.gnu.org/cgit/guix.git
preparing index
index prepared:
100644 6648f17dfad0aac6c3f745f33611bb69b1c08196	gnu/packages/valgrind.scm

applying [1/1] https://yhetil.org/guix-bugs/20220426013913.20117-3-GNUtoo@cyberdimension.org/
diff --git a/gnu/packages/valgrind.scm b/gnu/packages/valgrind.scm
index 6648f17dfa..1269e07593 100644

Checking patch gnu/packages/valgrind.scm...
Applied patch gnu/packages/valgrind.scm cleanly.

index at:
100644 1269e0759327ef9601f0159c58449412ca3e330a	gnu/packages/valgrind.scm

(*) Git path names are given by the tree(s) the blob belongs to.
    Blobs themselves have no identifier aside from the hash of its contents.^

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).