* bug#63526: hubbub build failure when doing guix package -u
@ 2023-05-15 19:24 Andy Tai
2023-05-22 6:44 ` bug#63526: [PATCH] gnu: hubbub: Disable building tests Andy Tai
2023-05-27 7:29 ` bug#63526: [PATCH v2] gnu (hubbub): Fix build Andy Tai
0 siblings, 2 replies; 6+ messages in thread
From: Andy Tai @ 2023-05-15 19:24 UTC (permalink / raw)
To: 63526
key lines:
COMPILE: test/tokeniser2.c
COMPILE: test/tokeniser3.c
COMPILE: test/tree.c
COMPILE: test/tree2.c
COMPILE: test/tree-buf.c
test/tokeniser2.c: In function ‘token_handler’:
test/tokeniser2.c:444:46: error: ‘t.data.character.ptr’ may be used
uninitialized [-Werror=maybe-uninitialized]
444 | t.data.character.ptr += len;
| ^~
test/tokeniser2.c:441:38: note: ‘t’ declared here
441 | hubbub_token t;
| ^
test/tokeniser2.c:445:46: error: ‘t.data.character.len’ may be used
uninitialized [-Werror=maybe-uninitialized]
445 | t.data.character.len -= len;
| ^~
test/tokeniser2.c:441:38: note: ‘t’ declared here
441 | hubbub_token t;
| ^
test/tokeniser3.c: In function ‘token_handler’:
test/tokeniser3.c:453:46: error: ‘t.data.character.ptr’ may be used
uninitialized [-Werror=maybe-uninitialized]
453 | t.data.character.ptr += len;
| ^~
test/tokeniser3.c:450:38: note: ‘t’ declared here
450 | hubbub_token t;
| ^
test/tokeniser3.c:454:46: error: ‘t.data.character.len’ may be used
uninitialized [-Werror=maybe-uninitialized]
454 | t.data.character.len -= len;
| ^~
test/tokeniser3.c:450:38: note: ‘t’ declared here
450 | hubbub_token t;
| ^
LINK: build-x86_64-unknown-linux-gnu-x86_64-unknown-linux-gnu-release-lib-shared/test_entities
LINK: build-x86_64-unknown-linux-gnu-x86_64-unknown-linux-gnu-release-lib-shared/test_csdetect
LINK: build-x86_64-unknown-linux-gnu-x86_64-unknown-linux-gnu-release-lib-shared/test_tokeniser
LINK: build-x86_64-unknown-linux-gnu-x86_64-unknown-linux-gnu-release-lib-shared/test_parser
cc1: all warnings being treated as errors
make: *** [/gnu/store/3jqaqf59ra550lk7hvpgpg8l5krxizra-netsurf-buildsystem-1.9/share/netsurf-buildsystem/makefiles/Makefile.top:631:
build-x86_64-unknown-linux-gnu-x86_64-unknown-linux-gnu-release-lib-shared/test_tokeniser2.o]
Error 1
make: *** Waiting for unfinished jobs....
cc1: all warnings being treated as errors
make: *** [/gnu/store/3jqaqf59ra550lk7hvpgpg8l5krxizra-netsurf-buildsystem-1.9/share/netsurf-buildsystem/makefiles/Makefile.top:631:
build-x86_64-unknown-linux-gnu-x86_64-unknown-linux-gnu-release-lib-shared/test_tokeniser3.o]
Error 1
Test suite failed, dumping logs.
error: in phase 'check': uncaught exception:
%exception #<&invoke-error program: "make" arguments: ("test" "-j"
"31" "COMPONENT_TYPE=lib-shared" "CC=gcc" "BUILD_CC=gcc"
"PREFIX=/gnu/store/7fn6jxg1vpadm8rpa8rzbwqgipxlwync-hubbub-0.3.7"
"NSSHARED=/gnu/store/3jqaqf59ra550lk7hvpgpg8l5krxizra-netsurf-buildsystem-1.9/share/netsurf-buildsystem")
exit-status: 2 term-signal: #f stop-signal: #f>
phase `check' failed after 0.2 seconds
command "make" "test" "-j" "31" "COMPONENT_TYPE=lib-shared" "CC=gcc"
"BUILD_CC=gcc" "PREFIX=/gnu/store/7fn6jxg1vpadm8rpa8rzbwqgipxlwync-hubbub-0.3.7"
"NSSHARED=/gnu/store/3jqaqf59ra550lk7hvpgpg8l5krxizra-netsurf-buildsystem-1.9/share/netsurf-buildsystem"
failed with status 2
^ permalink raw reply [flat|nested] 6+ messages in thread* bug#63526: [PATCH] gnu: hubbub: Disable building tests 2023-05-15 19:24 bug#63526: hubbub build failure when doing guix package -u Andy Tai @ 2023-05-22 6:44 ` Andy Tai 2023-05-25 13:02 ` Greg Hogan 2023-05-27 7:29 ` bug#63526: [PATCH v2] gnu (hubbub): Fix build Andy Tai 1 sibling, 1 reply; 6+ messages in thread From: Andy Tai @ 2023-05-22 6:44 UTC (permalink / raw) To: 63526; +Cc: Andy Tai Fix for https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63526 * gnu/packages/web.scm (hubbub): [arguments] (tests): Set to #f to disable test build --- gnu/packages/web.scm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm index fe52f673e2..203e3283cf 100644 --- a/gnu/packages/web.scm +++ b/gnu/packages/web.scm @@ -5252,7 +5252,9 @@ (define-public hubbub perl)) (propagated-inputs (list libparserutils)) ;for libhubbub.pc - (arguments netsurf-buildsystem-arguments) + (arguments + `(#:tests? #f ;build error in building tests with gcc 11; skip for now + ,@netsurf-buildsystem-arguments)) (home-page "https://www.netsurf-browser.org/projects/hubbub/") (synopsis "HTML5 compliant parsing library") (description base-commit: 3abcf1663b86bc075e29563140698d8bfae44992 -- 2.40.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* bug#63526: [PATCH] gnu: hubbub: Disable building tests 2023-05-22 6:44 ` bug#63526: [PATCH] gnu: hubbub: Disable building tests Andy Tai @ 2023-05-25 13:02 ` Greg Hogan 2023-05-25 13:35 ` Bruno Victal 0 siblings, 1 reply; 6+ messages in thread From: Greg Hogan @ 2023-05-25 13:02 UTC (permalink / raw) To: Andy Tai; +Cc: 63526 On Mon, May 22, 2023 at 2:46 AM Andy Tai <atai@atai.org> wrote: > > Fix for https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63526 > > * gnu/packages/web.scm (hubbub): [arguments] (tests): Set to #f to disable test build > --- > gnu/packages/web.scm | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm > index fe52f673e2..203e3283cf 100644 > --- a/gnu/packages/web.scm > +++ b/gnu/packages/web.scm > @@ -5252,7 +5252,9 @@ (define-public hubbub > perl)) > (propagated-inputs > (list libparserutils)) ;for libhubbub.pc > - (arguments netsurf-buildsystem-arguments) > + (arguments > + `(#:tests? #f ;build error in building tests with gcc 11; skip for now > + ,@netsurf-buildsystem-arguments)) > (home-page "https://www.netsurf-browser.org/projects/hubbub/") > (synopsis "HTML5 compliant parsing library") > (description > > base-commit: 3abcf1663b86bc075e29563140698d8bfae44992 > -- > 2.40.1 Hi Andy, Disabling tests should be a last resort, especially without a process to evaluate re-enabling tests in the future. Based on the error, can we instead add "-Wno-error=maybe-uninitialized" to the configure-flags? Greg ^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#63526: [PATCH] gnu: hubbub: Disable building tests 2023-05-25 13:02 ` Greg Hogan @ 2023-05-25 13:35 ` Bruno Victal 2023-05-25 17:54 ` Andy Tai 0 siblings, 1 reply; 6+ messages in thread From: Bruno Victal @ 2023-05-25 13:35 UTC (permalink / raw) To: Greg Hogan, Andy Tai; +Cc: 63526 On 2023-05-25 14:02, Greg Hogan wrote: > Hi Andy, > > Disabling tests should be a last resort, especially without a process > to evaluate re-enabling tests in the future. I concur. A test failure, unless it is caused by things such as “requiring network access” or is expected due to guix specifics should be considered a problem with the package. (if tests are disabled simply because they happen to fail without doing any investigation, why have tests at all?) > Based on the error, can we instead add > "-Wno-error=maybe-uninitialized" to the configure-flags? I'd report this upstream first, it can be the case that the error (which is being flagged by the compiler) is unmasking a real bug upstream. -- Furthermore, I consider that nonfree software must be eradicated. Cheers, Bruno. ^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#63526: [PATCH] gnu: hubbub: Disable building tests 2023-05-25 13:35 ` Bruno Victal @ 2023-05-25 17:54 ` Andy Tai 0 siblings, 0 replies; 6+ messages in thread From: Andy Tai @ 2023-05-25 17:54 UTC (permalink / raw) To: Bruno Victal; +Cc: 63526, Greg Hogan Will do. Thanks On Thu, May 25, 2023 at 6:35 AM Bruno Victal <mirai@makinata.eu> wrote: > > On 2023-05-25 14:02, Greg Hogan wrote: > > > Based on the error, can we instead add > > "-Wno-error=maybe-uninitialized" to the configure-flags? > > I'd report this upstream first, it can be the case that the error > (which is being flagged by the compiler) is unmasking a real bug > upstream. > ^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#63526: [PATCH v2] gnu (hubbub): Fix build 2023-05-15 19:24 bug#63526: hubbub build failure when doing guix package -u Andy Tai 2023-05-22 6:44 ` bug#63526: [PATCH] gnu: hubbub: Disable building tests Andy Tai @ 2023-05-27 7:29 ` Andy Tai 1 sibling, 0 replies; 6+ messages in thread From: Andy Tai @ 2023-05-27 7:29 UTC (permalink / raw) To: 63526, code, mirai; +Cc: Andy Tai Fix for https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63526 * gnu/packages/web.scm (hubbub): [source](patches): Add patch to fix build. * gnu/packages/patches/hubbub-prevent-Werror-maybe-uninitialized-build-failure-wit.patch: New file * gnu/local.mk (dist_patch_DATA): Add it. --- gnu/local.mk | 2 + ...aybe-uninitialized-build-failure-wit.patch | 40 +++++++++++++++++++ gnu/packages/web.scm | 4 +- 3 files changed, 45 insertions(+), 1 deletion(-) create mode 100644 gnu/packages/patches/hubbub-prevent-Werror-maybe-uninitialized-build-failure-wit.patch diff --git a/gnu/local.mk b/gnu/local.mk index 18e8235140..e2b42ca676 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -58,6 +58,7 @@ # Copyright © 2022 jgart <jgart@dismail.de> # Copyright © 2023 Zheng Junjie <873216071@qq.com> # Copyright © 2023 Ivana Drazovic <iv.dra@hotmail.com> +# Copyright © 2023 Andy Tai <atai@atai.org> # # This file is part of GNU Guix. # @@ -1349,6 +1350,7 @@ dist_patch_DATA = \ %D%/packages/patches/http-parser-CVE-2020-8287.patch \ %D%/packages/patches/htslib-for-stringtie.patch \ %D%/packages/patches/hubbub-sort-entities.patch \ + %D%/packages/patches/hubbub-prevent-Werror-maybe-uninitialized-build-failure-wit.patch \ %D%/packages/patches/hueplusplus-mbedtls.patch \ %D%/packages/patches/hurd-add-without-rump-configure-option.patch \ %D%/packages/patches/hurd-fix-types-of-read-write-and-readables-methods-2.patch \ diff --git a/gnu/packages/patches/hubbub-prevent-Werror-maybe-uninitialized-build-failure-wit.patch b/gnu/packages/patches/hubbub-prevent-Werror-maybe-uninitialized-build-failure-wit.patch new file mode 100644 index 0000000000..6f289a770e --- /dev/null +++ b/gnu/packages/patches/hubbub-prevent-Werror-maybe-uninitialized-build-failure-wit.patch @@ -0,0 +1,40 @@ +From 69d81a8a4d4c223aad67cde0fdf64d64351b9802 Mon Sep 17 00:00:00 2001 +From: Andy Tai <atai@atai.org> +Date: Sat, 27 May 2023 00:01:34 -0700 +Subject: [PATCH] prevent -Werror=maybe-uninitialized build failure with gcc 11 + when building tests tokeniser2 and tokeniser3 + +--- + test/tokeniser2.c | 2 +- + test/tokeniser3.c | 2 +- + 2 files changed, 2 insertions(+), 2 deletions(-) + +diff --git a/test/tokeniser2.c b/test/tokeniser2.c +index c8ab9c0..4caae38 100644 +--- a/test/tokeniser2.c ++++ b/test/tokeniser2.c +@@ -438,7 +438,7 @@ hubbub_error token_handler(const hubbub_token *token, void *pw) + /* Expected token only contained part of the data + * Calculate how much is left, then try again with + * the next expected token */ +- hubbub_token t; ++ hubbub_token t = { 0 }; + + t.type = HUBBUB_TOKEN_CHARACTER; + t.data.character.ptr += len; +diff --git a/test/tokeniser3.c b/test/tokeniser3.c +index e33d018..b3be901 100644 +--- a/test/tokeniser3.c ++++ b/test/tokeniser3.c +@@ -447,7 +447,7 @@ hubbub_error token_handler(const hubbub_token *token, void *pw) + /* Expected token only contained part of the data + * Calculate how much is left, then try again with + * the next expected token */ +- hubbub_token t; ++ hubbub_token t = { 0 }; + + t.type = HUBBUB_TOKEN_CHARACTER; + t.data.character.ptr += len; +-- +2.40.1 + diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm index 3af4aa0b8d..387ceac058 100644 --- a/gnu/packages/web.scm +++ b/gnu/packages/web.scm @@ -5242,7 +5242,9 @@ (define-public hubbub (sha256 (base32 "1dimfyblmym98qa1b80c5jslv2zk8r44xbdrgrsrw1n9wr9y4yly")) - (patches (search-patches "hubbub-sort-entities.patch")))) + (patches (search-patches + "hubbub-sort-entities.patch" + "hubbub-prevent-Werror-maybe-uninitialized-build-failure-wit.patch")))) (build-system gnu-build-system) (native-inputs (list netsurf-buildsystem base-commit: b96b82bcd4bc24529941ff74a91432481f1a71b5 -- 2.40.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-05-27 7:30 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-05-15 19:24 bug#63526: hubbub build failure when doing guix package -u Andy Tai 2023-05-22 6:44 ` bug#63526: [PATCH] gnu: hubbub: Disable building tests Andy Tai 2023-05-25 13:02 ` Greg Hogan 2023-05-25 13:35 ` Bruno Victal 2023-05-25 17:54 ` Andy Tai 2023-05-27 7:29 ` bug#63526: [PATCH v2] gnu (hubbub): Fix build Andy Tai
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/guix.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).