From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id KLQBIgXt9l8eegAA0tVLHw (envelope-from ) for ; Thu, 07 Jan 2021 11:14:13 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id eKrTHQXt9l/dfQAA1q6Kng (envelope-from ) for ; Thu, 07 Jan 2021 11:14:13 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D0C0A9403A9 for ; Thu, 7 Jan 2021 11:14:12 +0000 (UTC) Received: from localhost ([::1]:50876 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kxTF5-0006R6-Nz for larch@yhetil.org; Thu, 07 Jan 2021 06:14:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:53106) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kxTEy-0006PE-01 for bug-guix@gnu.org; Thu, 07 Jan 2021 06:14:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:35111) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kxTEw-0005PJ-C0 for bug-guix@gnu.org; Thu, 07 Jan 2021 06:14:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kxTEw-0007GQ-8H for bug-guix@gnu.org; Thu, 07 Jan 2021 06:14:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#45570: [PATCH v2] system: Assert, that user and group names are unique. Resent-From: Leo Prikler Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Thu, 07 Jan 2021 11:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45570 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 45570-submit@debbugs.gnu.org id=B45570.161001801727881 (code B ref 45570); Thu, 07 Jan 2021 11:14:02 +0000 Received: (at 45570) by debbugs.gnu.org; 7 Jan 2021 11:13:37 +0000 Received: from localhost ([127.0.0.1]:46657 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kxTEX-0007Fc-2v for submit@debbugs.gnu.org; Thu, 07 Jan 2021 06:13:37 -0500 Received: from mailrelay.tugraz.at ([129.27.2.202]:31087) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kxTEU-0007FT-QG for 45570@debbugs.gnu.org; Thu, 07 Jan 2021 06:13:35 -0500 Received: from nijino.local (217-149-174-13.nat.highway.telekom.at [217.149.174.13]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4DBNrr5HK4z3wCX; Thu, 7 Jan 2021 12:13:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1610018012; bh=oei+Q7Q1Gmr42ljEnyc9Ec/xeyzklkeYJz16fmOy8DU=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=epAywIQc7kKNaOo/pZ3+M1aUSvyRXs+sDmHd8XDEsOjjrSirvHEenJpST1K/q1qpD x1LMSo1azuoKO0MYazDD9xWu9xDsDHn7kHo3C2MeZtcRwdkm0Hp4A7zEIqc08rBkgt Xn07eAkLhimxeAQmc5xk6dAhYN0Gh3XvXtFE4Xeo= Message-ID: <08d83d415bc59d7b86dc7233f48ece7d909069f2.camel@student.tugraz.at> From: Leo Prikler Date: Thu, 07 Jan 2021 12:13:31 +0100 In-Reply-To: <87czyhjg9s.fsf@gnu.org> References: <20210106212148.28720-1-leo.prikler@student.tugraz.at> <87czyhjg9s.fsf@gnu.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 45570@debbugs.gnu.org, conjaroy@gmail.com Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.25 Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=tugraz.at header.s=mailrelay header.b=epAywIQc; dmarc=fail reason="SPF not aligned (relaxed)" header.from=student.tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: D0C0A9403A9 X-Spam-Score: -1.25 X-Migadu-Scanner: scn0.migadu.com X-TUID: IAXWCGvngDYp Am Donnerstag, den 07.01.2021, 09:35 +0100 schrieb Ludovic Courtès: > Leo Prikler skribis: > > > *gnu/system/shadow.scm (find-duplicates): New variable. > > (assert-unique-account-names, assert-unique-group-names): New > > variables. > > (account-activation): Use them here. > > Final nitpicks! :-) > > > +(define (find-duplicates list) > > Please add a docstring. Done, see v3. > > + (let loop ((table (make-hash-table)) > > + (list list)) > > You can move ‘table’ out of the ‘loop’ arguments since it’s mutated > anyway. I don't see any benefit from doing so, however. It'd be an additional layer of mutation and if we ever wanted to change to vhashes or alists we'd have to refactor that. Regards, Leo