unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Prikler <leo.prikler@student.tugraz.at>
To: "Tobias Geerinckx-Rice" <me@tobias.gr>,
	"Miguel Ángel Arruga Vivas" <rosen644835@gmail.com>
Cc: 45676@debbugs.gnu.org
Subject: bug#45676: Store references inside compressed data
Date: Wed, 06 Jan 2021 09:54:25 +0100	[thread overview]
Message-ID: <06ba5c0f24bdcdb706990c9169093aba72463302.camel@student.tugraz.at> (raw)
In-Reply-To: <871rezf1yg.fsf@nckx>

[-- Attachment #1: Type: text/plain, Size: 409 bytes --]

Hi!
Am Dienstag, den 05.01.2021, 23:33 +0100 schrieb Tobias Geerinckx-Rice:
> Let's stop installing compressed executables & data files.  We 
> already avoid compressed .jars and other renamed zip files.  It 
> ain't right.
Would this be strictly necessary even if the same references are kept
through other files, e.g. uncompressed binaries?
I'll attach a patch, that fixes Emacs just in case.

Regards, Leo

[-- Attachment #2: 0001-gnu-emacs-Don-t-install-compressed-archives.patch --]
[-- Type: text/x-patch, Size: 1475 bytes --]

From 57c23bf6ecac79c397cb49ff251176ec3a7b1cf5 Mon Sep 17 00:00:00 2001
From: Leo Prikler <leo.prikler@student.tugraz.at>
Date: Wed, 6 Jan 2021 09:24:07 +0100
Subject: [PATCH] gnu: emacs: Don't install compressed archives.

See <http://issues.guix.gnu.org/45676#3>.

* gnu/packages/emacs.scm (emacs)[#:configure-flags]:
Add --without-compress-install.
(emacs-minimal)[#:configure-flags]: Likewise.
---
 gnu/packages/emacs.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index ca14584ada..aa636b8c9b 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -124,6 +124,7 @@
      `(#:tests? #f                      ; no check target
        #:configure-flags (list "--with-modules"
                                "--with-cairo"
+                               "--without-compress-install"
                                "--disable-build-details")
        #:phases
        (modify-phases %standard-phases
@@ -355,7 +356,8 @@ also enabled and works without glitches even on X server."))))
     (arguments
      (substitute-keyword-arguments (package-arguments emacs)
        ((#:configure-flags flags ''())
-        `(list "--with-gnutls=no" "--disable-build-details"))
+        `(list "--with-gnutls=no" "--disable-build-details"
+               "--without-compress-install"))
        ((#:phases phases)
         `(modify-phases ,phases
            (delete 'restore-emacs-pdmp)
-- 
2.30.0


  reply	other threads:[~2021-01-06  8:55 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-05 14:36 bug#45676: Store references inside compressed data Miguel Ángel Arruga Vivas
2021-01-05 20:22 ` Leo Famulari
2021-01-05 20:22 ` Leo Famulari
2021-01-06 11:35   ` Ludovic Courtès
2021-01-06 16:57     ` Miguel Ángel Arruga Vivas
2021-01-07 11:05       ` Ludovic Courtès
2021-01-05 22:33 ` Tobias Geerinckx-Rice via Bug reports for GNU Guix
2021-01-06  8:54   ` Leo Prikler [this message]
2021-01-14 21:31     ` Ludovic Courtès
2021-01-14 22:24       ` Leo Prikler
2021-01-06 18:40   ` Miguel Ángel Arruga Vivas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=06ba5c0f24bdcdb706990c9169093aba72463302.camel@student.tugraz.at \
    --to=leo.prikler@student.tugraz.at \
    --cc=45676@debbugs.gnu.org \
    --cc=me@tobias.gr \
    --cc=rosen644835@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).