From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id yBu/B+IgWmNk1AAAbAwnHQ (envelope-from ) for ; Thu, 27 Oct 2022 08:10:42 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id mMPUBuIgWmNoFAAAG6o9tA (envelope-from ) for ; Thu, 27 Oct 2022 08:10:42 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9EC557387 for ; Thu, 27 Oct 2022 08:10:41 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1onw4p-0003Nb-Gd; Thu, 27 Oct 2022 02:09:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1onw4c-0002nC-QM for bug-guix@gnu.org; Thu, 27 Oct 2022 02:09:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1onw4c-0007Jc-Fr for bug-guix@gnu.org; Thu, 27 Oct 2022 02:09:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1onw4b-0005yZ-VZ for bug-guix@gnu.org; Thu, 27 Oct 2022 02:09:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#58813: can't substitute etc/teams.scm command as doc suggests Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Thu, 27 Oct 2022 06:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58813 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Maxim Cournoyer , 58813@debbugs.gnu.org Received: via spool by 58813-submit@debbugs.gnu.org id=B58813.166685093522945 (code B ref 58813); Thu, 27 Oct 2022 06:09:01 +0000 Received: (at 58813) by debbugs.gnu.org; 27 Oct 2022 06:08:55 +0000 Received: from localhost ([127.0.0.1]:55959 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1onw4M-0005xr-KT for submit@debbugs.gnu.org; Thu, 27 Oct 2022 02:08:55 -0400 Received: from mail-ej1-f68.google.com ([209.85.218.68]:46012) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1onw4I-0005xd-Vq for 58813@debbugs.gnu.org; Thu, 27 Oct 2022 02:08:45 -0400 Received: by mail-ej1-f68.google.com with SMTP id sc25so1592250ejc.12 for <58813@debbugs.gnu.org>; Wed, 26 Oct 2022 23:08:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:from:to:cc:subject:date :message-id:reply-to; bh=CBNaPD2ILKGLb1DMKgv3l8JEKthUKCvMqRH0326VCPE=; b=cxlzH0w/cIMFuQM6rsOZoZkJgfXmG9tQ2PI4RJFdbf16fpL/QinF7ibkMfbbgbi4rc JApppm0EcqENnUeXKGHfuwnhSul+R3FgQ2frKnkeGcF8KHPKmbXYc4I9wQyCtmfTAIKz qQIJPy0ErfFXvcOSyGqM7o+DEQ557CO0ySSRU/q+Z/ObaA0CR1lA4IB+icirKJT1UjTK wG4qnsbmSwtXqBbnUvIrsqF02GqFpU+/HJVw0brB29HIGubofDfT3pQr119xvIlqUuHx T0k7FpOCxv7NKN5QZdWCUwFchSdcEOwxoSqMBidkWYSGGoNY+Bmm9PRAMb0uqjrMDIys sHdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=CBNaPD2ILKGLb1DMKgv3l8JEKthUKCvMqRH0326VCPE=; b=jMAVXIi+jpRuDMHwk9nvOAakYHtvcDp7akSJMYM9TFONK8eYdj2P8JPUfKhYOUgI7+ WO5ofDHFZ5J9liKPGOQLYBoEagkvCMmxgkDzq1J+gUiWRtnUwQqQY/XxukoXDkYJzO5W nQeTrnYvi4RWjmCys5MuBaeH9mYBEU2oyx0HnYJLSToU/3+Q5dCbZS0ASfaSKp9d4AsP cEoi7TU2MzIM6+HrFjkCyHbn9xVR0RBYQfb9lRCnP87ZeMjJM9bzDSkjZko8tz/wIxHD Ra02Pe0ZZRGVje6/FKI9Vt35nrLelBxDVQzW2KvyxRXb3mbXiEHF7gwLOIfBI/yNIK+W vj3g== X-Gm-Message-State: ACrzQf2LP6vGR/mDDvuELE1KmFBthccMLf5S2LkkfBGHN2nq96yG6C0A Dnlfc2+eesMH+sApvc/GCOs= X-Google-Smtp-Source: AMsMyM43G+e3npsn1nde5sAGd9B3H44FOSVRfRile4Zp0eLS11NC/IgWK1/tXvdNFY7u09oGm1Ly9w== X-Received: by 2002:a17:907:7f25:b0:7aa:acf9:c07e with SMTP id qf37-20020a1709077f2500b007aaacf9c07emr14242126ejc.280.1666850917054; Wed, 26 Oct 2022 23:08:37 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id d2-20020a170906304200b0073ddb2eff27sm239322ejd.167.2022.10.26.23.08.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Oct 2022 23:08:36 -0700 (PDT) Message-ID: <05f449076bd7fd65f3cd301cbed4101490b3b2db.camel@gmail.com> From: Liliana Marie Prikler Date: Thu, 27 Oct 2022 08:08:35 +0200 In-Reply-To: <87r0yuq615.fsf@gmail.com> References: <87r0yuq615.fsf@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.0 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "bug-Guix" Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1666851041; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=CBNaPD2ILKGLb1DMKgv3l8JEKthUKCvMqRH0326VCPE=; b=o6cxdxaZpN+MjLtneEJNLUMJ+RYjf9ivapDuWBe4JyGxvzVySkiLRSNyLWkdmMxNmjginV I2hO0/8e4iShaRAxqVCrI9HV1ODf1sahLBMH42GzwUqrQp8NaafKqZf24ReJi6HfiH6Mav bkb4p3Kz3scEPhng49punQhBAfywIc/CPxCcWgX+fQwBHk7h+7Vgdd7FpJ9b2fKl6YFOWp ewmoBnN2cd716FfRCypcALr8IbzKM++0sL60aZevHqiQ1PkcdTvqm57mR54mrCciuVA7u3 ZmruRxyFwVIXhP49mijvVCUcfo7GmGPDcbn7WHd4CHKAECZSjpFguEhvfbV3WA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1666851041; a=rsa-sha256; cv=none; b=umPl3F9QxC2cldPoulHIMzt4/TCRhUiViqWQHtBLaWT5/7kxKeamJQlfsXDcFEBxo52oEf NT5XZ57TkJ/C0CpMkn1mFhhPoLMt3zJn9HiPlQ7m3EXLU6RT8IGh59MhrD2rP1tRjG8+cB U+caAoR2Q+0Kn1c3FD2lSy+nWqbXSgqjaDi0gqfvyniy2jC+xwhuMWmrEW3OjpVqMkpZJG tnp1PdK+lt8RVSPxI5akov65pj3T/1zMDiB342Ly5XU2jbjrkMjJ9ziqER3NP6jwmvvIXQ j9siCmi2k6nbtHh6/Ku3VpuJhhkuvG9W2W6YnH22AENJiCyvvwgHYBolQW4Ppw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b="cxlzH0w/"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 6.58 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b="cxlzH0w/"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 9EC557387 X-Spam-Score: 6.58 X-Migadu-Scanner: scn0.migadu.com X-TUID: /VEL4GzJGSBg Am Mittwoch, dem 26.10.2022 um 23:50 -0400 schrieb Maxim Cournoyer: > Hi, >=20 > Today, I tried; >=20 > --8<---------------cut here---------------start------------->8--- > $ git send-email --to=3Dguix-patches@gnu.org=C2=A0\ > =C2=A0 $(./etc/teams.scm cc-members origin/master HEAD) 0000-cover- > letter.patch > fatal: ambiguous argument 'some.email@redacted.com"': unknown > revision or path not in the working tree. > Use '--' to separate paths from revisions, like this: > 'git [...] -- [...]' > format-patch -o /tmp/pFSRbRNNoU --add-header=3D"X-Debbugs-Cc: > redacted@gmail.com" --add-header=3D"X-Debbugs-Cc: redacted@email" > [...]: command returned error: 128 >=20 > $ ./etc/teams.scm cc-members origin/master HEAD > --add-header=3D"X-Debbugs-Cc: redacted@email" --add-header=3D"X-Debbugs- > Cc: redacted@email" ... > --8<---------------cut here---------------end--------------->8--- >=20 > You can see the command fails; this is because when using Bash > command substitution $(), the quotes in the result are not > interpreted and are thus part of the value (literals), which then > gets split on white space. >=20 > As a quick hacky fix,=C2=A0 I tried removing the space and double quotes > like: >=20 > modified=C2=A0=C2=A0 etc/teams.scm.in > @@ -514,7 +514,7 @@ (define (cc . teams) > =C2=A0=C2=A0 "Return arguments for `git send-email' to notify the members= of > the given > =C2=A0TEAMS when a patch is received by Debbugs." > =C2=A0=C2=A0 (format #true > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "~{--add-header= =3D\"X-Debbugs-Cc: ~a\"~^ ~}" > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "~{--add-header= =3DX-Debbugs-Cc:~a~^ ~}" > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (map person-= email > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 (delete-duplicates (append-map team-members teams) > equal?)))) >=20 > and sent a patch with that command: >=20 > git send-email --to=3Dguix-patches@gnu.org=C2=A0\ > =C2=A0 $(./etc/teams.scm cc-members origin/master HEAD 0000-cover- > letter.patch >=20 > It created https://issues.guix.gnu.org/58812=C2=A0with it, but I don't se= e > any of the X-Debbugs-Cc headers.=C2=A0 Mmmh. Note that the existing etc/teams also assumes there are no funny characters in the quote. So it's susceptible to good ol' bobby tables. Could we, instead of outputting a command, make it so that we can pass an already formatted patch and etc/teams rewrites it? Cheers