unofficial mirror of guile-user@gnu.org 
 help / color / mirror / Atom feed
From: Taylan Kammer <taylan.kammer@gmail.com>
To: guile-user@gnu.org
Cc: christopher@librehacker.com
Subject: Re: srfi-64 apathetic test-error
Date: Thu, 24 Oct 2019 18:50:01 +0200	[thread overview]
Message-ID: <dd05aeb2-3d6a-468d-e210-2321e6343cf2@gmail.com> (raw)
In-Reply-To: <5d7fb138-a870-826f-2a68-a539c90da813@gmail.com>

Sorry, I said something wrong in my previous email.

The SRFI-64 specification does not mention the possibility of providing
an arbitrary predicate.  That's a feature supported by my R7RS-based
implementation of SRFI-64:

    https://github.com/TaylanUB/scheme-srfis/tree/master/srfi/64

(The file 'execution.body.scm' contains most of the logic.)

I've tried to figure out what the reference implementation supports but
the code is overly complicated.  There's a comment saying "TODO: decide
how to specify expected error types for Guile" which makes me think it
doesn't support Guile that well.  I think it doesn't actually use the
"error-type" information at all in the case of Guile and just matches
all errors it catches and considers them correct.  See lines 800 to 818
here:


http://git.savannah.gnu.org/cgit/guile.git/tree/module/srfi/srfi-64/testing.scm

Last time I suggested Guile to adopt my SRFI-64 implementation, it was
argued against on the grounds that it's not been around as long as the
reference implementation and therefore possibly less stable.  Maybe I
should try again, because IMO the reference implementation is written in
a terrible style that makes it very difficult to comprehend and improve.

- Taylan


On 24.10.2019 18:18, Taylan Kammer wrote:
> On 23.10.2019 06:37, Christopher Howard wrote:
>> Hi, I was just wondering: `test-error' from (srfi srfi-64) gives a pass
>> if it catches an exception, but it doesn't seem to care whether or not
>> the exception caught matches what you told it to expect. Is this a bug?
> 
> The (test-error ...) form takes an optional "error-type" operand.  It
> can be an arbitrary predicate (one-argument procedure that returns a
> Boolean value) which tests if the error is the expected kind.
> 
> See here for a complete documentation of the SRFI-64 API:
> 
>     https://srfi.schemers.org/srfi-64/srfi-64.html
> 
> - Taylan
> 



      parent reply	other threads:[~2019-10-24 16:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-23  4:37 srfi-64 apathetic test-error Christopher Howard
2019-10-24 16:18 ` Taylan Kammer
2019-10-24 16:21   ` John Cowan
2019-10-24 16:50   ` Taylan Kammer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dd05aeb2-3d6a-468d-e210-2321e6343cf2@gmail.com \
    --to=taylan.kammer@gmail.com \
    --cc=christopher@librehacker.com \
    --cc=guile-user@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).