From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Zelphir Kaltstahl Newsgroups: gmane.lisp.guile.user Subject: Re: guile-hall issues converting my project to a hall project Date: Thu, 18 Feb 2021 20:16:42 +0100 Message-ID: References: <11206998.46ALo4VoAQ@terra> <02902ff9-1585-a453-4e36-c9a731eee6fe@posteo.de> <6330005.mNMjihpRT5@terra> <87wnv6xulu.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35627"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 Cc: guile-user@gnu.org To: alex.sassmannshausen@gmail.com Original-X-From: guile-user-bounces+guile-user=m.gmane-mx.org@gnu.org Thu Feb 18 20:17:55 2021 Return-path: Envelope-to: guile-user@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lCooD-000988-Eq for guile-user@m.gmane-mx.org; Thu, 18 Feb 2021 20:17:53 +0100 Original-Received: from localhost ([::1]:47382 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lCooC-0006FD-9H for guile-user@m.gmane-mx.org; Thu, 18 Feb 2021 14:17:52 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60176) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lConC-0006DF-Jn for guile-user@gnu.org; Thu, 18 Feb 2021 14:16:50 -0500 Original-Received: from mout01.posteo.de ([185.67.36.65]:52600) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lCon9-0006jx-Q8 for guile-user@gnu.org; Thu, 18 Feb 2021 14:16:50 -0500 Original-Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 2723A160063 for ; Thu, 18 Feb 2021 20:16:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1613675804; bh=kbbqgsYY0tzMDKJhV8OfhQR/6xAMFu/nTb83ypYomwA=; h=Subject:To:Cc:From:Date:From; b=G5FL9iNP/Qjg1UnsuRa7v7/AO3JeIcN5w5V9O5N2yCIuY5vSbXEm3Xo7yezsGn1b9 x9SUuh/9dY11OmkYtyUVP77WT5+dmVi+S+WjDBi9mL52NkVGLnCrpn+3ujWefQIAdM 90R6LDfp/XU/Wjr2XiOAC1un2VcKmTcJL1zJPoDnmuNRvMB0KV2tZtr89TKQltPumc OiigQiUwbBb7LPUhiMmaGx1A4HQF0CW7UW2CMg5bnm9Rl/iItlg1c8ik4oyXmEk2s9 aMC15f/Fy8xbYIZ3x+fvCftpGo0Gyl3AhZ+nt9TuZ3KOEe4n7l3p0Hm9JcgDaPdN5X snAlVvVclhH8g== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4DhPZz1s9qz6tm6; Thu, 18 Feb 2021 20:16:43 +0100 (CET) X-Tagtoolbar-Keys: D20210218201642479 In-Reply-To: <87wnv6xulu.fsf@gmail.com> Content-Language: en-US Received-SPF: pass client-ip=185.67.36.65; envelope-from=zelphirkaltstahl@posteo.de; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guile-user@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: General Guile related discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-user-bounces+guile-user=m.gmane-mx.org@gnu.org Original-Sender: "guile-user" Xref: news.gmane.io gmane.lisp.guile.user:17263 Archived-At: Hi Alex! I am willing to test/try some more. When you say "since commit xyz", do you mean commit of guile-hall itself, or a commit of Guix, where an updated version of guile-hall is available? How would I test the master branch version? I would guess install it in a guix environment and then use that environment to try and convert a project. What would you suggest testing? It was quite OK to edit hall.scm in an editor. Perhaps, if a project is significantly bigger than my project, it would become cumbersome, but for me personally it is fine, now that I know what goes in there and how it needs to look. I have not yet begun writing a guide for converting a project. Hopefully I'll be able to do so soon. Best regards, Zelphir On 2/17/21 10:17 PM, Alex Sassmannshausen wrote: > Hi Zelphir and Tim, > > I am the author of guile hall — apologies for only now getting into this > thread. I'm afraid I have been somewhat distracted with other things. > > First of all I want to echo what others have said — thank you very much > for your detailed descriptions of what exactly happened when you tried > to migrate the project to guile hall. > > The aim of the project is to massively reduce the barrier of entry to > creating new, portable, high quality guile projects — and to contribute > them to Guix. Your descriptions suggest it's not there yet! > > In any case, some comments inline: > > Zelphir Kaltstahl writes: > >> Hello Tim! >> >> Thank you, it works now! >> >> Removing the duplicate entry of `fslib` in hall.scm fixed it. > Fwiw, since commit ac76541a this issue can be automatically resolved by > running scan once more: it should remove duplicate entries in hall.scm. > >> Regarding the license: OK, I have no problem moving my license to >> `COPYING`. However, I still think, that it should not put GPL there, >> when I specified AGPL in `hall.scm`. This looks like a hardcoded >> fallback, which does not take the license specification into account. >> Something like: "If there is no `COPYING` file just put GPL into a file >> `COPYING`." instead of "If there is no `COPYING` file just put >> into a file `COPYING`.". I could be >> wrong though, as I do not know anything about guile-hall's internals. > This is odd — Hall should respect your license choice. It should, for > (A)GPL licenses automatically download those from the internet and > install them in COPYING. There was an issue with those licenses hiding > behind a 302 status code, which resulted in fallback text being loaded > in COPYING. But even that fallback text should respect your license. > > I just tried changing my license to AGPLv3+ in one of my projects, > running hall from Master (the most recent commit fixes the 302 license > issue), and it's fetching the license correctly. > > I'd be interested in seeing what your experience is if you are willing > to try? > > In any case, Hall is undergoing active development, and I'm hoping to > have a fresh release end of this month, with a whole bunch of > improvements and bug fixes. Definitely feel free to drop issues to me > directly by email or on gitlab (though some of the ones you raised have > been fixed, like the unknown filetype issue). > > Best wishes, > > Alex > >> Follow up question would be, how to bring the package into the guix >> repository, but I am guessing, that it will be answered at >> https://guix.gnu.org/cookbook/en/html_node/Direct-checkout-hacking.html, >> which I have not read yet. >> >> Another question is, whether I should put you into the authors file and >> write something like "help with packaging" there. What is the common >> practice? >> >> Best regards, >> Zelphir >> >> On 2/16/21 5:48 PM, Tim Van den Langenbergh wrote: >>> Err, looking at your hall.scm file, you have the fslib file added to your >>> libraries twice. >>> >>> Guix environment is not needed if you have all the requirements for building >>> the package installed locally, but if you want to distribute your package it's >>> good practise to ensure it builds in a clean environment (see also https:// >>> guix.gnu.org/manual/en/html_node/Invoking-guix-environment.html for more >>> information about Guix environments). >>> >>> The "COPYING" file is hardcoded as license file in Hall, to ensure compatibility >>> with GNU standards: https://www.gnu.org/licenses/gpl-howto.en.html >>> >>> Hope this helps, >>> >>> Vale >>> >>> -Tim >>> >>> -- repositories: https://notabug.org/ZelphirKaltstahl