unofficial mirror of guile-user@gnu.org 
 help / color / mirror / Atom feed
From: "Aleix Conchillo Flaqué" <aconchillo@gmail.com>
To: Zelphir Kaltstahl <zelphirkaltstahl@posteo.de>
Cc: Guile User <guile-user@gnu.org>
Subject: Re: Simple list of key-value pairs?
Date: Fri, 9 Jul 2021 15:37:49 -0700	[thread overview]
Message-ID: <CA+XASoV7PQa74KN_v0ZLwfYz5u_QzJz-YzuN+JjrYhbig2ehAg@mail.gmail.com> (raw)
In-Reply-To: <52395f5c-a470-1b47-2c5a-7274bbd14940@posteo.de>

Hello,

I would also use Zelphir's approach and pass query parameters as an alist,
the reason is because then you can dynamically generate that alist more
easily if needed and even pass it around, and it looks nicer to me but
that's a personal choice. I would also actually make that an optional
argument instead and explicitly pass it with #:query-params.

(api-uri "https://ci.guix.gnu.org"
                 "/api/jobs"
                 #:query-params `(("nr" . ,limit)
                                              ("evaluation" . ,evaluation)
                                              ("system" . #f)))

Aleix

On Fri, Jul 9, 2021 at 4:37 AM Zelphir Kaltstahl <zelphirkaltstahl@posteo.de>
wrote:

> Hi!
>
> I think I would give the pairs together in an association list and use
> alist
> procedures to work with that. Then you could also only have one backtick,
> at the
> start of the alist:
>
> ~~~~
> `((attr . ,val)
>   (attr . ,val)
>   (attr . ,val)
>   (attr . ,val))
> ~~~~
>
> Looks simpler to me and fewer special characters.
>
> Regards,
> Zelphir
>
> On 7/8/21 4:37 PM, Hartmut Goebel wrote:
> > Hi,
> >
> > I'm seeking advice for passing simple key-value pairs to a function and
> > generate a string out of these values. Neither the names not the number
> of
> > keys is known in advance.
> >
> > Background: This shall become a generic function for generating URI
> > query-strings.
> >
> > My current approach please see below. Anyhow, I'm wondering whether the
> quite
> > and quasiquote can be replaced by something simpler.
> >
> > (use-modules (ice-9 match))
> >
> > (define limit 100)
> > (define evaluation "linux")
> >
> > (define* (api-uri base path #:rest query)
> >
> >   (define (build-query-string kv)
> >     (match kv
> >        ((name #f) #f)
> >        ((name (? string? value))
> >         (string-append name "=" value))  ; FIXME: encode
> >        ((name (? number? value))
> >         (string-append name "=" (number->string value)))))
> >
> >
> >   (format #t "~%Query: ~a~%~%" query)
> >   (let ((query-string
> >      (when query
> >        (string-join
> >         (filter (lambda (x) x) (map build-query-string query))
> >         "&"))))
> >     (format #t "~%Query-String: ~a~%~%" query-string)
> >     ;; todo: build uri incl. query-string
> >   ))
> >
> >
> > (api-uri "https://ci.guix.gnu.org" "/api/jobs")
> > (api-uri "https://ci.guix.gnu.org" "/api/jobs"
> >      `("nr" ,limit)
> >      `("evaluation" ,evaluation)
> >      `("system" ,#f))
> >
> --
> repositories: https://notabug.org/ZelphirKaltstahl
>
>


  reply	other threads:[~2021-07-09 22:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-08 14:37 Simple list of key-value pairs? Hartmut Goebel
2021-07-08 15:22 ` Christopher Lam
2021-07-08 18:59 ` Luis Felipe
2021-07-09 11:31 ` Zelphir Kaltstahl
2021-07-09 22:37   ` Aleix Conchillo Flaqué [this message]
2021-07-09 11:55 ` Tim Van den Langenbergh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+XASoV7PQa74KN_v0ZLwfYz5u_QzJz-YzuN+JjrYhbig2ehAg@mail.gmail.com \
    --to=aconchillo@gmail.com \
    --cc=guile-user@gnu.org \
    --cc=zelphirkaltstahl@posteo.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).