From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: =?UTF-8?Q?Aleix_Conchillo_Flaqu=C3=A9?= Newsgroups: gmane.lisp.guile.user Subject: issues unit testing with srfi-64 Date: Sat, 29 Dec 2018 15:50:18 -0800 Message-ID: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Trace: blaine.gmane.org 1546128230 11650 195.159.176.226 (30 Dec 2018 00:03:50 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 30 Dec 2018 00:03:50 +0000 (UTC) To: guile-user Original-X-From: guile-user-bounces+guile-user=m.gmane.org@gnu.org Sun Dec 30 01:03:46 2018 Return-path: Envelope-to: guile-user@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gdOa1-0002xx-VL for guile-user@m.gmane.org; Sun, 30 Dec 2018 01:03:46 +0100 Original-Received: from localhost ([127.0.0.1]:42161 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gdOc5-0003hH-Lk for guile-user@m.gmane.org; Sat, 29 Dec 2018 19:05:53 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:47383) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gdObQ-0003Mz-Lw for guile-user@gnu.org; Sat, 29 Dec 2018 19:05:13 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gdOND-0001Qf-K1 for guile-user@gnu.org; Sat, 29 Dec 2018 18:50:32 -0500 Original-Received: from mail-lj1-x234.google.com ([2a00:1450:4864:20::234]:44394) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gdOND-0001Ph-CE for guile-user@gnu.org; Sat, 29 Dec 2018 18:50:31 -0500 Original-Received: by mail-lj1-x234.google.com with SMTP id k19-v6so21375178lji.11 for ; Sat, 29 Dec 2018 15:50:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=munB4af9+Fae+FcjwvJPOBXTcT9/11eQdG8J84/jCf8=; b=deJG8gwqtV8rVPx5pR0MOKd0cqy8z8RsE++K+jWq+JPgkeafmBpO1es0EhpnaTMD+h pFmV66xXBNH34CU652EwxryT1OLG6tUi6IxIeBaHsLnRl2NRLfi77w0K95iyAaJMO6Tp whADku6PByKHTGPE6ggpfbg+M/mr+BbDuKLqX0M3B0/ZK9OOFpH/2qG1eqt2JaEBPcEo Eq9UG803VYlRBqVoiJkygwMb5AeTjtNOk/o1fYKcu+nRuCvzGnQdIg+mUV6E5FYvGpTe oyIc6q6WwZy0SH7fb4eLb50MjVYfWsAOP4Drf4+vQxlEzdki8058qjBhbJ8t2vLLWX7J 8jmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=munB4af9+Fae+FcjwvJPOBXTcT9/11eQdG8J84/jCf8=; b=Hq9lmvnzZ5reptL1I7TsC2kH09xxC3XlpoGDAqY4lPcxAlL/4hBBVzdpLZGbqfpShE c3nzINq1J9A/fiiT6NCrR7ifKTe4WeYbjE0I1IiXlEUYkiMXhEj8z+7hwyIN02P5ketT 5IFDu+d5sSqTFFLxmUKWGLUluWY/GQFgatKsR11AE25/r5QHn6CmnPZLcjhwEvhEzX+Y 2hRAYcqKHC5QP0NXHyYhi6yqyVuVMHzvE7ps8mj2S6RHAXh85A/6IF5E9D1h/nGECtVT 5c2hyZp0xosdY/gWKQjhBXPq+bvl5jRM+0K9lZZTvpXJNChJQEsj0/2zvI+Ipdy54r8b ek3w== X-Gm-Message-State: AJcUukfhFy7EiUhEYCSPQwMI+ijv89QiPfJVdDx8KrI+rhPyQMcCVEk/ gytx6QPlSYNd8RyrsHwcr4Ujpe0ysWtZN8y36AEWEJk6 X-Google-Smtp-Source: AFSGD/VGfBzRoBmUsOwEaBX2rIO9W5Qj7B664rnu6tDqjCgRtL5ZaW6dGQgul98yjE3SvS2JO8j/0fNWSZADmww9bP0= X-Received: by 2002:a2e:83d7:: with SMTP id s23-v6mr21080224ljh.139.1546127428947; Sat, 29 Dec 2018 15:50:28 -0800 (PST) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::234 X-BeenThere: guile-user@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: General Guile related discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-user-bounces+guile-user=m.gmane.org@gnu.org Original-Sender: "guile-user" Xref: news.gmane.org gmane.lisp.guile.user:15172 Archived-At: Hi! happy holidays and almost happy new year to everyone! I've added unit tests to guile-json and I have found a couple of issues. This is the branch: https://github.com/aconchillo/guile-json/tree/switch-to-alist-and-vectors First one (which might not be a real issue) is that (test-end) doesn't exit with an exit status different than 0 if a test fails. And this will cause automake to believe the tests passed when they actually did not. I have solved this with the following which works for my use case, but I'm not sure if that's the right way: ... (test-end "test-builder") (exit (if (eqv? 0 (test-runner-fail-count (test-runner-current))) 0 1)) (I could have returned the fail-count directly, but since there are only 255 exit values I thought it could wrap around.) The other issue is that the beginning of the log files are corrupted: %%%% Starting test test-builder (Writing full log to "test-builder.log") # of expected passes 19 r.scm" source-line: 33 source-form: (test-equal "1234" (scm->json-string 1234)) This should be something like: Test begin: source-file: "tests/test-builder.scm" source-line: 33 source-form: (test-equal "1234" (scm->json-string 1234)) Test end: result-kind: pass actual-value: "1234" expected-value: "1234" I don't know how to fix this one yet. Has anyone else found these issues before? Thanks in advance! Aleix