unofficial mirror of guile-user@gnu.org 
 help / color / mirror / Atom feed
From: Cecil Westerhof <Cecil@decebal.nl>
To: guile-user@gnu.org
Subject: Re: How to read from a file
Date: Fri, 18 Jun 2010 18:21:40 +0200	[thread overview]
Message-ID: <87zkysb9bf.fsf@linux-lqcw.site> (raw)
In-Reply-To: <878w6ccsz9.fsf@linux-lqcw.site> (Cecil Westerhof's message of "Fri, 18 Jun 2010 16:31:38 +0200")

Op vrijdag 18 jun 2010 16:31 CEST schreef Cecil Westerhof:

> When looking at:
> http://www.gnu.org/software/guile/docs/faq/OLD-guile-faq.html
>
> The following code should work:
> #!/usr/bin/guile \
> -e main -s
> !#
> (use-modules (ice-9 readline))
> (activate-readline)
>
> (define (main args)
> (let ((input-file  (cadr args))
> (output-file (caddr args)))
> (with-input-from-file input-file
> (lambda ()
> (while (not (eof-object? (peek-char)))
> (display (read-line))
> (newline))))))
>
> But when executing it, I get:
> ERROR: Unbound variable: read-line
>
> What am I doing wrong?

I found it:
    #!/usr/bin/guile \
    -e main -s
    !#
    (use-modules (ice-9 readline))
    (use-modules (ice-9 rdelim))
    (activate-readline)

    (define (main args)
      (let ((input-file-name  (cadr args))
            (output-file-name (caddr args))
            (input-file       "")
            (output-file      "")
            (this-line        ""))
        (set! input-file  (open-file input-file-name  "r"))
        (set! output-file (open-file output-file-name "w"))
        (while (not (eof-object? (peek-char input-file)))
               (set! this-line (read-line input-file))
               (write-line this-line output-file)
               )
        (close-port output-file)
        (close-port input-file)))

A file of 5.000.000 lines and 163 MB is processed in 26 seconds. At the
moment it is just copying, but that is properly the most expensive part.
There should be some error checking and the processing should be done,
but that is the next step.

Could this be done more efficient?

By the way, it is not that bad. My Emacs Lisp code takes about two times
as long. It does also a replace, but that will not take 50% of the time.
So it looks like Guile has a good performance notwithstanding that it is
said that  Guile's IO performance is not very fast at the moment. It is
about as fast as a Perl script. The problem with the Perl script is that
it only works with ASCII. It goes wrong on files that contain other
characters. That is why I at the moment use the Emacs Lisp script. I am
wondering what will happen when Guile's IO performance becomes good.

-- 
Cecil Westerhof
Senior Software Engineer
LinkedIn: http://www.linkedin.com/in/cecilwesterhof



      parent reply	other threads:[~2010-06-18 16:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-18 14:31 How to read from a file Cecil Westerhof
2010-06-18 15:50 ` Mike Gran
2010-06-18 16:21 ` Cecil Westerhof [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zkysb9bf.fsf@linux-lqcw.site \
    --to=cecil@decebal.nl \
    --cc=guile-user@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).