From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Ricardo Wurmus Newsgroups: gmane.comp.gnu.guix.devel,gmane.lisp.guile.user Subject: Re: guile-gdbm doesn't work with gdbm-1.14 Date: Mon, 19 Mar 2018 11:20:15 +0100 Message-ID: <87zi34cqow.fsf@elephly.net> References: <874lldvktm.fsf@member.fsf.org> <87efkhebmf.fsf@netris.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1521454749 15838 195.159.176.226 (19 Mar 2018 10:19:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 19 Mar 2018 10:19:09 +0000 (UTC) User-Agent: mu4e 1.0; emacs 25.3.1 Cc: guix-devel@gnu.org, guile-user@gnu.org To: Mark H Weaver Original-X-From: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Mon Mar 19 11:19:04 2018 Return-path: Envelope-to: gcggd-guix-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1exrsd-0003z9-EA for gcggd-guix-devel@m.gmane.org; Mon, 19 Mar 2018 11:19:03 +0100 Original-Received: from localhost ([::1]:41148 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1exrug-0007cp-EC for gcggd-guix-devel@m.gmane.org; Mon, 19 Mar 2018 06:21:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43173) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1exruL-0007bV-34 for guix-devel@gnu.org; Mon, 19 Mar 2018 06:20:50 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1exruH-0005c7-0t for guix-devel@gnu.org; Mon, 19 Mar 2018 06:20:49 -0400 Original-Received: from sender-of-o51.zoho.com ([135.84.80.216]:21001) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1exruG-0005bG-N7 for guix-devel@gnu.org; Mon, 19 Mar 2018 06:20:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1521454818; s=zoho; d=elephly.net; i=rekado@elephly.net; h=References:From:To:Cc:Subject:In-reply-to:Date:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-ID; l=1154; bh=fZJ6IrhnaekqDsWzgWwFtiANYmsChOzc9zh0geJMxOg=; b=cH+EqdDKIwuHaKyUnzyhtj/OCAL4w6pkd3nfsOXAluufj9tb25syJxNmBl53xy6S 1ZjBT7mZAu8m7Qm7AMq30GMrwNtP9IT9AePoXhUogfRK9ZalvO6aXkajZitgVLEEYRU Qen28SWCkR9HoJYrFhKzFV/sGt85FSdtwGD1qIUw= Original-Received: from localhost (port-92-200-113-70.dynamic.qsc.de [92.200.113.70]) by mx.zohomail.com with SMTPS id 1521454818571383.799893137235; Mon, 19 Mar 2018 03:20:18 -0700 (PDT) In-reply-to: <87efkhebmf.fsf@netris.org> X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC X-ZohoMailClient: External X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 135.84.80.216 X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Original-Sender: "Guix-devel" Xref: news.gmane.org gmane.comp.gnu.guix.devel:41915 gmane.lisp.guile.user:14493 Archived-At: Mark H Weaver writes: > iyzsong@member.fsf.org (=E5=AE=8B=E6=96=87=E6=AD=A6) writes: > >> Hello, since version 1.14, gdbm doesn't export "gdbm_errno" anymore [1], >> so the guile-gdbm ffi binding code [2] need updates now (I'm not >> confident to do it myself...). >> >> [1] http://git.gnu.org.ua/cgit/gdbm.git/commit/?id=3Dc175231e2781abd17ea= bf412cfb597654a076c7b >> [2] https://github.com/ijp/guile-gdbm/blob/master/gdbm.scm#L156 > > Here's a preliminary fix. Thank you. > * gnu/packages/patches/guile-gdbm-ffi-support-gdbm-1.14.patch: New file. > * gnu/local.mk (dist_patch_DATA): Add it. > * gnu/packages/guile.scm (guile-gdbm-ffi)[native-inputs]: New field. > [inputs]: Move above arguments. Add the patch, and the 'patch' program. > [propagated-inputs]: Move above arguments. > [arguments]: In the builder, add code to apply the patch. I don=E2=80=99t see the native-inputs field in the patch. Shouldn=E2=80=99= t the =E2=80=9Cpatch=E2=80=9D and =E2=80=9Cpatch-file=E2=80=9D inputs be native-inputs? --=20 Ricardo GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC https://elephly.net