From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alex Sassmannshausen Newsgroups: gmane.lisp.guile.user Subject: Re: guile-hall issues converting my project to a hall project Date: Wed, 17 Feb 2021 22:17:01 +0100 Message-ID: <87wnv6xulu.fsf@gmail.com> References: <11206998.46ALo4VoAQ@terra> <02902ff9-1585-a453-4e36-c9a731eee6fe@posteo.de> <6330005.mNMjihpRT5@terra> Reply-To: alex.sassmannshausen@gmail.com Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17816"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.4.13; emacs 27.1 Cc: guile-user@gnu.org To: Zelphir Kaltstahl Original-X-From: guile-user-bounces+guile-user=m.gmane-mx.org@gnu.org Wed Feb 17 22:40:39 2021 Return-path: Envelope-to: guile-user@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lCUYo-0004W6-Vc for guile-user@m.gmane-mx.org; Wed, 17 Feb 2021 22:40:39 +0100 Original-Received: from localhost ([::1]:52096 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lCUYn-0001e1-TJ for guile-user@m.gmane-mx.org; Wed, 17 Feb 2021 16:40:37 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46152) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lCUC4-0006WB-Db for guile-user@gnu.org; Wed, 17 Feb 2021 16:17:08 -0500 Original-Received: from mail-ej1-x629.google.com ([2a00:1450:4864:20::629]:40181) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lCUC2-00053B-Fq for guile-user@gnu.org; Wed, 17 Feb 2021 16:17:08 -0500 Original-Received: by mail-ej1-x629.google.com with SMTP id b14so19079558eju.7 for ; Wed, 17 Feb 2021 13:17:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:reply-to:in-reply-to:date :message-id:mime-version; bh=vCcoULE6ZcOpVX5Dvd0mjO+mArK5/ran3/abkcVleXE=; b=byCfGng5Doq4lkXfOdt0A10AlDkDNinH7NQbudCS7DdqFMxRH0KX2ItSRevS3/lCfX QzdU1ywGPeYWQatWF6023bRlILHdS4IRLdCrDbvDYeaK88oDongGxJQpUl0m/URgx607 ZlL9z6svjIMTAK+Wz0toOguh034eMixPkdTjZ+z/sveE8Vgb/f8DXQIvNGbvtXq0Vqo4 YGedCzRPnAYcNhYjz0Zwc+ZfWBociNdNVJKUWvFQ9ZZbQh4trZRI8H7lxjPixjCxoJiT XDWNLI0uy1CZSXhi1Iiw7xPXzvuD6WyVLE0eB1sTskV6TxyXkl15Y7DYDdis4H16/LUI NXsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :reply-to:in-reply-to:date:message-id:mime-version; bh=vCcoULE6ZcOpVX5Dvd0mjO+mArK5/ran3/abkcVleXE=; b=hf7961ZmeT0CU2wCPFNkcvMFKQpuGL6WTfi3iwv1WYREnbzlwxppw44Dqm6F8IhSrf Aopc/OfUgfigVHL06KlkBtM9jdfGSfrKU3Cem4lX0/Lk/9gj6vgUMCTo5zU2RnXvb5Z/ RGAZkoERY5bvAaiVLdOKPj3MtDCu582HT1HdyLBQsoZtymQQZofn+6RuGmUlPeY6Tevz oTScpCxUdDnYP8PngNjQd838xApQaJDntcTLVnsNYioI2+wxzCn4O5rFFsAzfVTQJ7XC Lgd6C7F5TlCbqEgyjjpTo88Dq0OFB8y8ERvvqque1vKJ3HGdXChHUm2Tgsdw+cjbqf0z Qxug== X-Gm-Message-State: AOAM531dc2Ks1bGMdvGAmDem+kFDcvJPHuYm+krRaGjVrPMFoZNNHuCl levzTlUo7znpW/uMLI98EifwE6D2Hrs= X-Google-Smtp-Source: ABdhPJzzrKUQw3/bX1LzJ8hx94pzSAocTPyKJRJaxJcgthm9w3dx2bxKt1Th/FKew0LkJ1dSkryFCg== X-Received: by 2002:a17:906:388a:: with SMTP id q10mr841905ejd.496.1613596625026; Wed, 17 Feb 2021 13:17:05 -0800 (PST) Original-Received: from watership ([91.178.162.244]) by smtp.gmail.com with ESMTPSA id gh36sm1113570ejc.33.2021.02.17.13.17.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Feb 2021 13:17:04 -0800 (PST) In-reply-to: Received-SPF: pass client-ip=2a00:1450:4864:20::629; envelope-from=alex.sassmannshausen@gmail.com; helo=mail-ej1-x629.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guile-user@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: General Guile related discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-user-bounces+guile-user=m.gmane-mx.org@gnu.org Original-Sender: "guile-user" Xref: news.gmane.io gmane.lisp.guile.user:17259 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Zelphir and Tim, I am the author of guile hall =E2=80=94 apologies for only now getting into= this thread. I'm afraid I have been somewhat distracted with other things. First of all I want to echo what others have said =E2=80=94 thank you very = much for your detailed descriptions of what exactly happened when you tried to migrate the project to guile hall. The aim of the project is to massively reduce the barrier of entry to creating new, portable, high quality guile projects =E2=80=94 and to contri= bute them to Guix. Your descriptions suggest it's not there yet! In any case, some comments inline: Zelphir Kaltstahl writes: > Hello Tim! > > Thank you, it works now! > > Removing the duplicate entry of `fslib` in hall.scm fixed it. Fwiw, since commit ac76541a this issue can be automatically resolved by running scan once more: it should remove duplicate entries in hall.scm. > Regarding the license: OK, I have no problem moving my license to > `COPYING`. However, I still think, that it should not put GPL there, > when I specified AGPL in `hall.scm`. This looks like a hardcoded > fallback, which does not take the license specification into account. > Something like: "If there is no `COPYING` file just put GPL into a file > `COPYING`." instead of "If there is no `COPYING` file just put > into a file `COPYING`.". I could be > wrong though, as I do not know anything about guile-hall's internals. This is odd =E2=80=94 Hall should respect your license choice. It should, f= or (A)GPL licenses automatically download those from the internet and install them in COPYING. There was an issue with those licenses hiding behind a 302 status code, which resulted in fallback text being loaded in COPYING. But even that fallback text should respect your license. I just tried changing my license to AGPLv3+ in one of my projects, running hall from Master (the most recent commit fixes the 302 license issue), and it's fetching the license correctly. I'd be interested in seeing what your experience is if you are willing to try? In any case, Hall is undergoing active development, and I'm hoping to have a fresh release end of this month, with a whole bunch of improvements and bug fixes. Definitely feel free to drop issues to me directly by email or on gitlab (though some of the ones you raised have been fixed, like the unknown filetype issue). Best wishes, Alex > Follow up question would be, how to bring the package into the guix > repository, but I am guessing, that it will be answered at > https://guix.gnu.org/cookbook/en/html_node/Direct-checkout-hacking.html, > which I have not read yet. > > Another question is, whether I should put you into the authors file and > write something like "help with packaging" there. What is the common > practice? > > Best regards, > Zelphir > > On 2/16/21 5:48 PM, Tim Van den Langenbergh wrote: >> Err, looking at your hall.scm file, you have the fslib file added to your >> libraries twice. >> >> Guix environment is not needed if you have all the requirements for buil= ding >> the package installed locally, but if you want to distribute your packag= e it's >> good practise to ensure it builds in a clean environment (see also https= :// >> guix.gnu.org/manual/en/html_node/Invoking-guix-environment.html for more >> information about Guix environments). >> >> The "COPYING" file is hardcoded as license file in Hall, to ensure compa= tibility >> with GNU standards: https://www.gnu.org/licenses/gpl-howto.en.html >> >> Hope this helps, >> >> Vale >> >> -Tim >> >> --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iJUEAREIAD0WIQSaK0Ae0AEGUBWEuqyLxPRHboqOAAUCYC2Hzh8cYWxleC5zYXNz bWFubnNoYXVzZW5AZ21haWwuY29tAAoJEIvE9Eduio4ArwUBALwvk9zMCfc7IdAT SeqUqxeWcOqd1tvUwv0oD2CGFMETAQDjiU/76M6ILXl2UAbTr0O7kvmD1+kQMu35 BH0/X9/Wzw== =s87j -----END PGP SIGNATURE----- --=-=-=--