From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Newsgroups: gmane.lisp.guile.user Subject: Re: guile 2.0.9 build on mingw Date: Sun, 16 Jun 2013 16:44:55 +0200 Message-ID: <87r4g215eg.fsf@gnu.org> References: <83sj1hv2ml.fsf@gnu.org> <874ndx9y7h.fsf@pobox.com> <83ip2bt4qk.fsf@gnu.org> <8761xqhyyt.fsf@gnu.org> <83li6mt18y.fsf@gnu.org> <83wqq3mcq9.fsf@gnu.org> <87k3m3kor5.fsf@gnu.org> <83ehcalysu.fsf@gnu.org> <87sj0pvl4a.fsf@tines.lan> <837gi1n3v5.fsf@gnu.org> <87k3m1vg8b.fsf@tines.lan> <83txl4lhby.fsf@gnu.org> <838v2fky99.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1371394209 25131 80.91.229.3 (16 Jun 2013 14:50:09 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 16 Jun 2013 14:50:09 +0000 (UTC) Cc: guile-user@gnu.org To: Eli Zaretskii Original-X-From: guile-user-bounces+guile-user=m.gmane.org@gnu.org Sun Jun 16 16:50:09 2013 Return-path: Envelope-to: guile-user@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UoEHQ-00030A-Ph for guile-user@m.gmane.org; Sun, 16 Jun 2013 16:50:08 +0200 Original-Received: from localhost ([::1]:40798 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UoEHQ-0005CX-BA for guile-user@m.gmane.org; Sun, 16 Jun 2013 10:50:08 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54555) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UoEHJ-0005CK-3Y for guile-user@gnu.org; Sun, 16 Jun 2013 10:50:02 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UoEHH-0001x9-Kp for guile-user@gnu.org; Sun, 16 Jun 2013 10:50:01 -0400 Original-Received: from hera.aquilenet.fr ([141.255.128.1]:41247) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UoEHF-0001wr-VR; Sun, 16 Jun 2013 10:49:58 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id D041FCCC; Sun, 16 Jun 2013 16:44:56 +0200 (CEST) Original-Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qiDmPPzIUiXs; Sun, 16 Jun 2013 16:44:56 +0200 (CEST) Original-Received: from pluto (reverse-83.fdn.fr [80.67.176.83]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 2D4348D5; Sun, 16 Jun 2013 16:44:56 +0200 (CEST) X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 28 Prairial an 221 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0xEA52ECF4 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 83C4 F8E5 10A3 3B4C 5BEA D15D 77DD 95E2 EA52 ECF4 X-OS: x86_64-unknown-linux-gnu In-Reply-To: <838v2fky99.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 12 Jun 2013 20:57:38 +0300") User-Agent: Gnus/5.130007 (Ma Gnus v0.7) Emacs/24.3 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x [fuzzy] X-Received-From: 141.255.128.1 X-BeenThere: guile-user@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: General Guile related discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-user-bounces+guile-user=m.gmane.org@gnu.org Original-Sender: guile-user-bounces+guile-user=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.user:10445 Archived-At: Eli Zaretskii skribis: > First, running the test suite resulted in some failures. > test-system-cmds failed because it uses '..' quoting on the command > line, which the Windows shell doesn't support. Fixed thusly: > > --- test-suite/standalone/test-system-cmds~0 2010-12-08 11:07:11.00000000= 0 +0200 > +++ test-suite/standalone/test-system-cmds 2013-06-12 13:52:14.333269200 = +0300 > @@ -10,7 +10,7 @@ > "test-system-cmds: (system) did not return a boolean\n") > (exit 1))) >=20=20=20=20 > - (let ((rs (status:exit-val (system "guile -c '(exit 42)'")))) > + (let ((rs (status:exit-val (system "guile -c \"(exit 42)\"")))) > (if (not (=3D 42 rs)) > (begin > (simple-format > @@ -39,4 +39,4 @@ >=20=20 > ;; Local Variables: > ;; mode: scheme > -;; End: > \ No newline at end of file > +;; End: Applied. > '/tmp' will exist, none of which can be counted upon on Windows. > Here's the fix for that (the declaration of mkstemp avoids compiler > warning): > > --- test-suite/standalone/test-unwind.c~0 2012-01-31 00:32:38.000000000 += 0200 > +++ test-suite/standalone/test-unwind.c 2013-06-12 14:11:47.967231800 +03= 00 > @@ -200,9 +200,19 @@ check_ports () > #define FILENAME_TEMPLATE "/check-ports.XXXXXX" > char *filename; > const char *tmpdir =3D getenv ("TMPDIR"); > +#ifdef __MINGW32__ > + extern int mkstemp (char *); >=20=20 > if (tmpdir =3D=3D NULL) > + tmpdir =3D getenv ("TEMP"); > + if (tmpdir =3D=3D NULL) > + tmpdir =3D getenv ("TMP"); > + if (tmpdir =3D=3D NULL) > + tmpdir =3D "/"; > +#else > + if (tmpdir =3D=3D NULL) > tmpdir =3D "/tmp"; > +#endif >=20=20 > filename =3D alloca (strlen (tmpdir) + sizeof (FILENAME_TEMPLATE) + 1); > strcpy (filename, tmpdir); Applied, thanks. In the future, could you send patches as produced by =E2=80=98git format-pa= tch=E2=80=99, with a ChangeLog-style commit log? That would allow us to preserve authorship, and make it easier to apply patches. Ludo=E2=80=99.