Compile issues for 1.8.0 on Solaris 10

Compile issues for 1.8.0 on Solaris 10

[Charles Gagnon]

Those are compile issues but not really deve issues. Maybe just a
few things to fix in the configure.in scripts.

I got guile-1.8.0 to compile on my Solaris 10 box with gcc 3.4.3 but
I had to fix a few things first:

1. I had to replace the "-pthread" option in all the Makefile with
   "-pthreads". I think this is just a Linux vs Solaris thing, one
   gcc uses pthread and the other pthreads. -pthread reports invalid
   option.

2. per BIll Schottstaet (reported for 1.7.91), I changed filesys.c
   around line 860 cause I was getting an error in function
   scm_readdir:

   I changed filesys.c line 860 (or thereabouts) from:

    union {
      struct dirent ent;
      char pad1 [sizeof(struct dirent) + NAME_MAX];
      char pad2 [offsetof (struct dirent, d_name) + NAME_MAX + 1];
    } u;
    SCM_SYSCALL (readdir_r ((DIR *) SCM_CELL_WORD_1 (port), &u.ent, &rdent));

    to:

    struct dirent ent;
    SCM_SYSCALL (readdir_r ((DIR *) SCM_CELL_WORD_1 (port), &ent));

3.  I also removed -Werror from libguile/Makefile cause I was getting:

    In file included from eval.c:5969:
    eval.c: In function `deval':
    eval.c:3248: warning: implicit declaration of function `alloca'
    make[2]: *** [libguile_la-eval.lo] Error 1
    make[2]: Leaving directory `/home/bil/test/guile-1.7.91/libguile'
    make[1]: *** [all-recursive] Error 1

Thanks.

-- 
Charles Gagnon                   | My views are my views and they
http://unixrealm.com             | do not represent those of anybody
charlesg at unixrealm.com        | but me.

   If a man stands in the middle of the forest speaking and
   there is no woman around to hear him....Is he still wrong?
        -- Dennis Miller


_______________________________________________
Guile-user mailing list
Guile-user@gnu.org
http://lists.gnu.org/mailman/listinfo/guile-user

Re: Compile issues for 1.8.0 on Solaris 10

[Neil Jerram]

Charles Gagnon <charlesg@unixrealm.com> writes:

> Those are compile issues but not really deve issues. Maybe just a
> few things to fix in the configure.in scripts.
>
> I got guile-1.8.0 to compile on my Solaris 10 box with gcc 3.4.3 but
> I had to fix a few things first:
>
> 1. I had to replace the "-pthread" option in all the Makefile with
>    "-pthreads". I think this is just a Linux vs Solaris thing, one
>    gcc uses pthread and the other pthreads. -pthread reports invalid
>    option.

Thanks.  This seems to be an issue in our ACX_PTHREAD definition (in
acinclude.m4), which has been fixed in the latest version on
http://autoconf-archive.cryp.to, so I'll update our acinclude.m4 to
use the latest version.

> 2. per BIll Schottstaet (reported for 1.7.91), I changed filesys.c
>    around line 860 cause I was getting an error in function
>    scm_readdir:
>
>    I changed filesys.c line 860 (or thereabouts) from:
>
>     union {
>       struct dirent ent;
>       char pad1 [sizeof(struct dirent) + NAME_MAX];
>       char pad2 [offsetof (struct dirent, d_name) + NAME_MAX + 1];
>     } u;
>     SCM_SYSCALL (readdir_r ((DIR *) SCM_CELL_WORD_1 (port), &u.ent, &rdent));
>
>     to:
>
>     struct dirent ent;
>     SCM_SYSCALL (readdir_r ((DIR *) SCM_CELL_WORD_1 (port), &ent));

This code has since changed in CVS (both HEAD and the 1.8.x branch),
so I think that means this problem has been fixed and will be OK in
the next 1.8.x release.

> 3.  I also removed -Werror from libguile/Makefile cause I was getting:
>
>     In file included from eval.c:5969:
>     eval.c: In function `deval':
>     eval.c:3248: warning: implicit declaration of function `alloca'
>     make[2]: *** [libguile_la-eval.lo] Error 1
>     make[2]: Leaving directory `/home/bil/test/guile-1.7.91/libguile'
>     make[1]: *** [all-recursive] Error 1

Where is alloca() declared in Solaris 10?  Is it in <malloc.h>?  If it
is, we already have the fix for this in place, so it will be in the
next release.

> Thanks.

Many thanks for your report.

     Neil



_______________________________________________
Guile-user mailing list
Guile-user@gnu.org
http://lists.gnu.org/mailman/listinfo/guile-user

Re: Compile issues for 1.8.0 on Solaris 10

[Kevin Ryde]

Charles Gagnon <charlesg@unixrealm.com> writes:
>
>     struct dirent ent;
>     SCM_SYSCALL (readdir_r ((DIR *) SCM_CELL_WORD_1 (port), &ent));

I'm not sure that'll work, struct dirent can be small, hence the union
with the bigger amounts.  If you're using that function you might be
better just putting 1024 in place of NAME_MAX.


_______________________________________________
Guile-user mailing list
Guile-user@gnu.org
http://lists.gnu.org/mailman/listinfo/guile-user

Re: Compile issues for 1.8.0 on Solaris 10

[Charles Gagnon]

Thanks Neil. Any ETA the next release? 

Can you let know when acinclude.m4 is fixed in the CVS, I'll give it
a try.

I'll double-check but I thought alloca was declerad in alloca.h on
Solaris 10. 

On Tue, Jun 06, 2006 at 10:37:20PM +0100, Neil Jerram wrote:
> Charles Gagnon <charlesg@unixrealm.com> writes:
[...]
> > I got guile-1.8.0 to compile on my Solaris 10 box with gcc 3.4.3 but
> > I had to fix a few things first:
> >
> > 1. I had to replace the "-pthread" option in all the Makefile with
> >    "-pthreads". I think this is just a Linux vs Solaris thing, one
> >    gcc uses pthread and the other pthreads. -pthread reports invalid
> >    option.
> 
> Thanks.  This seems to be an issue in our ACX_PTHREAD definition (in
> acinclude.m4), which has been fixed in the latest version on
> http://autoconf-archive.cryp.to, so I'll update our acinclude.m4 to
> use the latest version.
> 
> > 2. per BIll Schottstaet (reported for 1.7.91), I changed filesys.c
> >    around line 860 cause I was getting an error in function
[...]
> This code has since changed in CVS (both HEAD and the 1.8.x branch),
> so I think that means this problem has been fixed and will be OK in
> the next 1.8.x release.
> 
> > 3.  I also removed -Werror from libguile/Makefile cause I was getting:
[...]
> Where is alloca() declared in Solaris 10?  Is it in <malloc.h>?  If it
> is, we already have the fix for this in place, so it will be in the
> next release.
[...]

-- 
Charles Gagnon                   | My views are my views and they
http://unixrealm.com             | do not represent those of anybody
charlesg at unixrealm.com        | but me.

   Why do they put Braille on the drive thru bank machines?
        -- Dennis Miller


_______________________________________________
Guile-user mailing list
Guile-user@gnu.org
http://lists.gnu.org/mailman/listinfo/guile-user

Re: Compile issues for 1.8.0 on Solaris 10

[Neil Jerram]

Charles Gagnon <charlesg@unixrealm.com> writes:

> Thanks Neil. Any ETA the next release? 

I'm afraid I don't know, sorry.  I guess once we have a handful of
fixes to make it worthwhile.

> Can you let know when acinclude.m4 is fixed in the CVS, I'll give it
> a try.

Yes, it's in CVS now; please let us know how it goes.

> I'll double-check but I thought alloca was declerad in alloca.h on
> Solaris 10. 

Thanks.

- Neil



_______________________________________________
Guile-user mailing list
Guile-user@gnu.org
http://lists.gnu.org/mailman/listinfo/guile-user