unofficial mirror of guile-user@gnu.org 
 help / color / mirror / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Mark H Weaver <mhw@netris.org>
Cc: guix-devel@gnu.org, guile-user@gnu.org, Ian Price <ianprice90@gmail.com>
Subject: Re: guile-gdbm doesn't work with gdbm-1.14
Date: Mon, 19 Mar 2018 17:47:30 +0100	[thread overview]
Message-ID: <87lgeoui59.fsf@gnu.org> (raw)
In-Reply-To: <87efkhebmf.fsf@netris.org> (Mark H. Weaver's message of "Sun, 18 Mar 2018 09:50:32 -0400")

Hello,

Mark H Weaver <mhw@netris.org> skribis:

> iyzsong@member.fsf.org (宋文武) writes:
>
>> Hello, since version 1.14, gdbm doesn't export "gdbm_errno" anymore [1],
>> so the guile-gdbm ffi binding code [2] need updates now (I'm not
>> confident to do it myself...).

Thanks, Mark for the quick fix.

> --- /dev/null
> +++ b/gnu/packages/patches/guile-gdbm-ffi-support-gdbm-1.14.patch
> @@ -0,0 +1,53 @@
> +From 1da99396dc65993ba34ac0370ca5d6acda6a3322 Mon Sep 17 00:00:00 2001
> +From: Mark H Weaver <mhw@netris.org>
> +Date: Sun, 18 Mar 2018 07:02:37 -0400
> +Subject: [PATCH] Add support for gdbm-1.14.
> +
> +As of gdbm-1.14, 'gdbm_errno' no longer exists as a binary interface.
> +It has been replaced by 'gdbm_errno_location', a function that returns
> +int*.  We now use this new interface if it's available.

Ian, could you consider applying this patch upstream?

Thanks!

Ludo’.



      parent reply	other threads:[~2018-03-19 16:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-18  8:39 guile-gdbm doesn't work with gdbm-1.14 宋文武
2018-03-18 13:50 ` Mark H Weaver
2018-03-19 10:20   ` Ricardo Wurmus
2018-03-19 16:17     ` Mark H Weaver
2018-03-19 16:47   ` Ludovic Courtès [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lgeoui59.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guile-user@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=ianprice90@gmail.com \
    --cc=mhw@netris.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).