From: Janneke Nieuwenhuizen <janneke@gnu.org>
To: Morgan Smith <Morgan.J.Smith@outlook.com>
Cc: guile-user@gnu.org
Subject: Re: [PATCH] Emacsy - formatting and consistency changes
Date: Tue, 05 Dec 2023 07:08:22 +0100 [thread overview]
Message-ID: <87edg189m1.fsf@gnu.org> (raw)
In-Reply-To: <LV8PR84MB34369C460242230B7E8B9C75C586A@LV8PR84MB3436.NAMPRD84.PROD.OUTLOOK.COM> (Morgan Smith's message of "Mon, 04 Dec 2023 17:55:12 -0500")
Morgan Smith writes:
Hi!
> I have some more patches for emacsy.
\o/
> I apologize for the linting change. I know it is a massive patch that
> will muddle the history and will make applying any pre-existing patches
> more difficult. I normally try to avoid making such a change to a
> project if I can avoid it.
> However, the ".dir-locals.el" file made my Emacs delete trailing
> whitespace which was resulting in ugly patches. Also running GNU indent
> was apparently on the TODO list anyways. So I decided to go ahead and
> run a simply lint script.
It's a good effort; it would (have) be(en) nice to run Emacs'
indent-region in the lint script, but I guess this simple lint
is much of an improvement already.
> I then went through all the tests to make everything consistent.
Nice.
> I also started fixing some of the simple warnings I was getting (null
> termination error, unknown variable error).
Ok.
> With these patches applied, the source should be easier to work with. I
> am planning to start providing more exciting patches soon.
Great, applied to master.
Thanks,
Janneke
--
Janneke Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond https://LilyPond.org
Freelance IT https://www.JoyOfSource.com | Avatar® https://AvatarAcademy.com
next prev parent reply other threads:[~2023-12-05 6:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 22:55 [PATCH] Emacsy - formatting and consistency changes Morgan Smith
2023-12-05 6:08 ` Janneke Nieuwenhuizen [this message]
2023-12-05 6:31 ` Janneke Nieuwenhuizen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87edg189m1.fsf@gnu.org \
--to=janneke@gnu.org \
--cc=Morgan.J.Smith@outlook.com \
--cc=guile-user@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).