Re: Debian guile-1.8 and ttn guile-pg

Re: Debian guile-1.8 and ttn guile-pg

[dsmich]

---- Greg Troxel <gdt@ir.bbn.com> wrote: 
>   [guile-pg and guile 1.8]
> 
>   I was hoping his guile-pg would work because it doesn't explicity
>   state that a 1.4.x guile is required like some of his other packages
>   do.
> 
> It works fine under 1.6.  What it needs is the feature, deprecated in
> 1.6 and removed in 1.8, of looking for a shlib when a module is used,
> and loading it and running the init function.  The 1.8 way is to have a
> scheme stub that dynlinks the module and exports the symbols.  So
> guile-pg needs a new .scm file that does this, and I suspect that's all
> that's required but I'm not sure.

That is one issue but not all.  There are other apis that were deprecated in 1.6 and finally removed in 1.8.  I'm pretty sure it's not possible to wite a C Guile extension that works without change on 1.4 *and* 1.8.

-Dale

Re: Debian guile-1.8 and ttn guile-pg

[Sebastian Tennant]

Quoth <dsmich@adelphia.net>:
> ---- Greg Troxel <gdt@ir.bbn.com> wrote: 
>>   [guile-pg and guile 1.8]
>> 
>>   I was hoping his guile-pg would work because it doesn't explicity
>>   state that a 1.4.x guile is required like some of his other packages
>>   do.
>> 
>> It works fine under 1.6.  What it needs is the feature, deprecated in
>> 1.6 and removed in 1.8, of looking for a shlib when a module is used,
>> and loading it and running the init function.  The 1.8 way is to have a
>> scheme stub that dynlinks the module and exports the symbols.  So
>> guile-pg needs a new .scm file that does this, and I suspect that's all
>> that's required but I'm not sure.
>
> That is one issue but not all.  There are other apis that were
> deprecated in 1.6 and finally removed in 1.8.  I'm pretty sure it's
> not possible to wite a C Guile extension that works without change on
> 1.4 *and* 1.8.

Thanks for the clarifications.

Sebastian

Debian guile-1.8 and ttn guile-pg

[Sebastian Tennant]

Hi list,

Has anyone successfully built ttn's guile-pg (0.36) using Debian's
guile-1.8?

Needless to say I haven't been able to get it to work.

I can run configure successfully once I tell it where Debian's
libpq-dev package puts the libpq includes:

  ./configure --with-libpq-includes=/usr/include/postgresql

but make fails, complaining about two files not found:

 ac_nonexistent.h
 guile/modsup.h

Any help much appreciated.

Sebastian

Re: Debian guile-1.8 and ttn guile-pg

[Sebastian Tennant]

Quoth David Pirotte <david@altosw.be>:
> Here is a package for debian that Dale Smith produced for me a month
> or so ago. 

Many thanks David.

I did see your list posting and I was considering writing to you
directly, but I though I'd enquire about ttn's version first because it
seems much further advanced.

Seb

Re: Debian guile-1.8 and ttn guile-pg

[David Pirotte]

Le Sun, 30 Mar 2008 15:11:58 +0300,
Sebastian Tennant <sebyte@smolny.plus.com> a écrit :

> Quoth David Pirotte <david@altosw.be>:
> > Here is a package for debian that Dale Smith produced for me a month
> > or so ago. 
> 
> Many thanks David.
> 
> I did see your list posting and I was considering writing to you
> directly, but I though I'd enquire about ttn's version first because it
> seems much further advanced.

Yes, but for some reasons, ttn's modules/packages are 'only' running under
guile-1.4.x, rarely under guile-1.6.x and i've never seen any of his work being
ported on guile-1.8, which is very sad indeed. But he wrote recently that he
might consider changing this in the future, let's hope!

You're welcome!
TC
David

Re: Debian guile-1.8 and ttn guile-pg

[Sebastian Tennant]

David Pirotte <david@altosw.be> writes:
> Le Sun, 30 Mar 2008 15:11:58 +0300,
> Sebastian Tennant <sebyte@smolny.plus.com> a écrit :
>
>> Quoth David Pirotte <david@altosw.be>:
>> > Here is a package for debian that Dale Smith produced for me a month
>> > or so ago. 
>> 
>> Many thanks David.
>> 
>> I did see your list posting and I was considering writing to you
>> directly, but I though I'd enquire about ttn's version first because it
>> seems much further advanced.
>
> Yes, but for some reasons, ttn's modules/packages are 'only' running
> under guile-1.4.x, rarely under guile-1.6.x and i've never seen any
> of his work being ported on guile-1.8, which is very sad indeed.

I agree.  It's a great shame.

I can confirm his guile-www works under 1.8.

I was hoping his guile-pg would work because it doesn't explicity
state that a 1.4.x guile is required like some of his other packages
do.

> But he wrote recently that he might consider changing this in the
> future, let's hope!

Indeed.

Sebastian

Re: Debian guile-1.8 and ttn guile-pg

[Greg Troxel]

  [guile-pg and guile 1.8]

  I was hoping his guile-pg would work because it doesn't explicity
  state that a 1.4.x guile is required like some of his other packages
  do.

It works fine under 1.6.  What it needs is the feature, deprecated in
1.6 and removed in 1.8, of looking for a shlib when a module is used,
and loading it and running the init function.  The 1.8 way is to have a
scheme stub that dynlinks the module and exports the symbols.  So
guile-pg needs a new .scm file that does this, and I suspect that's all
that's required but I'm not sure.

Re: Debian guile-1.8 and ttn guile-pg

[Thien-Thi Nguyen]

() Greg Troxel <gdt@ir.bbn.com>
() Mon, 31 Mar 2008 15:04:16 -0400

   So guile-pg needs a new .scm file that does this, and
   I suspect that's all that's required but I'm not sure.

Would something like this be sufficient?

(define-module (database postgres))
(load-extension "/ABS/PATH/TO/libpostgres.so.0.0.0"
                "scm_init_database_postgres_module")

thi

Re: Debian guile-1.8 and ttn guile-pg

[Greg Troxel]

Thien-Thi Nguyen <ttn@gnuvola.org> writes:

> () Greg Troxel <gdt@ir.bbn.com>
> () Mon, 31 Mar 2008 15:04:16 -0400
>
>    So guile-pg needs a new .scm file that does this, and
>    I suspect that's all that's required but I'm not sure.
>
> Would something like this be sufficient?
>
> (define-module (database postgres))
> (load-extension "/ABS/PATH/TO/libpostgres.so.0.0.0"
>                 "scm_init_database_postgres_module")

(I presume you are either consing up the path or substituting it with
autoconf.)

My understanding is slightly fuzzy, but I think that defines the
guile-pg symbols in the (database postgres) module, but will not
necessarily export them.  The 1.4-style module loading seems to do the
equivalent of define-public.  I did make guile-pg work with a scheme
load file as you write above once, and I also had a number of export
statements.

Re: Debian guile-1.8 and ttn guile-pg

[Thien-Thi Nguyen]

⎛⎞ Greg Troxel <gdt@ir.bbn.com>
⎝⎠ Tue, 27 May 2008 08:46:04 -0400

   > (define-module (database postgres))
   > (load-extension "/ABS/PATH/TO/libpostgres.so.0.0.0"
   >                 "scm_init_database_postgres_module")

   (I presume you are either consing up the path or substituting
   it with autoconf.)

Yes, either way or even both (whatever will work).

   My understanding is slightly fuzzy, but I think that defines
   the guile-pg symbols in the (database postgres) module, but
   will not necessarily export them.

OK.

   The 1.4-style module loading seems to do the equivalent of
   define-public.

Yes.

   I did make guile-pg work with a scheme load file as you write
   above once, and I also had a number of export statements.

So in addition to the above, there needs to be `define-public'
for each proc?  Can that be phrased as an `#:export' clause in
the `define-module' form (prior to the `load-extension' call)?

thi

Re: Debian guile-1.8 and ttn guile-pg

[David Pirotte]

[-- Attachment #1: Type: text/plain, Size: 1447 bytes --]

Hi Thien,

Symbols need to be exported.

Here is [attached] an exemple of the actual guile-pg 0.16-4 
postgres.scm file from the latest debian package.

The exports are done after the load-extension, but I am convinced it 
could be done in the define-module #:export clause, could it not?

David

Le Tue, 27 May 2008 15:04:27 +0200,
Thien-Thi Nguyen <ttn@gnuvola.org> a écrit :

> ⎛⎞ Greg Troxel <gdt@ir.bbn.com>
> ⎝⎠ Tue, 27 May 2008 08:46:04 -0400
> 
>    > (define-module (database postgres))
>    > (load-extension "/ABS/PATH/TO/libpostgres.so.0.0.0"
>    >                 "scm_init_database_postgres_module")
> 
>    (I presume you are either consing up the path or substituting
>    it with autoconf.)
> 
> Yes, either way or even both (whatever will work).
> 
>    My understanding is slightly fuzzy, but I think that defines
>    the guile-pg symbols in the (database postgres) module, but
>    will not necessarily export them.
> 
> OK.
> 
>    The 1.4-style module loading seems to do the equivalent of
>    define-public.
> 
> Yes.
> 
>    I did make guile-pg work with a scheme load file as you write
>    above once, and I also had a number of export statements.
> 
> So in addition to the above, there needs to be `define-public'
> for each proc?  Can that be phrased as an `#:export' clause in
> the `define-module' form (prior to the `load-extension' call)?
> 
> thi
> 
> 

[-- Attachment #2: postgres.scm --]
[-- Type: text/x-scheme, Size: 3594 bytes --]

;;; postgres.scm --- wrap PostgreSQL libpq

;;    Guile-pg - A Guile interface to PostgreSQL
;;    Copyright (C) 1999,2000,2002,2003 Free Software Foundation, Inc.
;;
;;    This program is free software; you can redistribute it and/or modify
;;    it under the terms of the GNU General Public License as published by
;;    the Free Software Foundation; either version 2 of the License, or
;;    (at your option) any later version.
;;
;;    This program is distributed in the hope that it will be useful,
;;    but WITHOUT ANY WARRANTY; without even the implied warranty of
;;    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
;;    GNU General Public License for more details.
;;
;;    You should have received a copy of the GNU General Public License
;;    along with this program; if not, write to the Free Software
;;    Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA

;;    Author: Ian Grant <Ian.Grant@cl.cam.ac.uk>

;; Load the C interface functions

(define-module (database postgres))

(cond
 ;; maybe this is already done
 ((and (defined? 'pg-guile-pg-loaded) pg-guile-pg-loaded))
 ;; use app-module loader if there
 ((defined? 'make-app-module-loader)
  ((make-app-module-loader
    (lambda (name)
      (car (list
            `("~A/guile-pg/0.16" ,(assq-ref %guile-build-info 'libdir)))))
    (lambda (name)
      `("lib~A" ,name))
    (lambda (name)
      `("init_~A" ,name)))
   "postgres"))
 ;; primitive way
 (else (dynamic-call
        "init_postgres"
        (dynamic-link
         (car (list
               (format #f "~A/guile-pg/0.16/libpostgres.so"
                       (assq-ref %guile-build-info 'libdir))))))))

(export pg-guile-pg-loaded)             ; ugh

(export pg-connectdb)
(export pg-connection?)
(export pg-setdb)
(export pg-reset)
(export pg-get-client-data)
(export pg-set-client-data!)
(export pg-exec)
(export pg-result?)
(export pg-error-message)
(export pg-get-db)
(export pg-get-user)
(export pg-get-pass)
(export pg-get-host)
(export pg-get-port)
(export pg-get-tty)
(export pg-get-options)
(export pg-get-connection)
(export pg-backend-pid)
(export pg-result-status)
(export pg-ntuples)
(export pg-nfields)
(export pg-cmdtuples)
(export pg-oid-status)
(export pg-oid-value)
(export pg-fname)
(export pg-fnumber)
(export pg-ftype)
(export pg-fsize)
(export pg-getvalue)
(export pg-getlength)
(export pg-getisnull)
(export pg-binary-tuples?)
(export pg-fmod)
(export pg-guile-pg-version)
(export pg-getline)
(export pg-putline)
(export pg-endcopy)
(export pg-trace)
(export pg-untrace)

(export pg-make-print-options)
(export pg-print)

(export pg-lo-creat)
(export pg-lo-open)
(export pg-lo-unlink)
(export pg-lo-get-connection)
(export pg-lo-get-oid)
(export pg-lo-tell)
(export pg-lo-seek)
(export pg-lo-read)
(export pg-lo-import)
(export pg-lo-export)

(define-public (pg-guile-pg-module-config-stamp) "Mon Feb 25 11:12:05 EST 2008")
(define-public (pg-guile-pg-module-version) "0.16")

;; backward compatibility (not documented to encourage
;;                         usage of symbols in new code)
;;
;; WARNING: these will go away!

(define-public PGRES_EMPTY_QUERY    'PGRES_EMPTY_QUERY)
(define-public PGRES_COMMAND_OK     'PGRES_COMMAND_OK)
(define-public PGRES_TUPLES_OK      'PGRES_TUPLES_OK)
(define-public PGRES_COPY_OUT       'PGRES_COPY_OUT)
(define-public PGRES_COPY_IN        'PGRES_COPY_IN)
(define-public PGRES_BAD_RESPONSE   'PGRES_BAD_RESPONSE)
(define-public PGRES_NONFATAL_ERROR 'PGRES_NONFATAL_ERROR)
(define-public PGRES_FATAL_ERROR    'PGRES_FATAL_ERROR)

;;; postgres.scm ends here

Re: Debian guile-1.8 and ttn guile-pg

[Thien-Thi Nguyen]

⎛⎞ David Pirotte <david@altosw.be>
⎝⎠ Tue, 27 May 2008 13:17:18 -0300

   Here is [attached] an exemple of the actual guile-pg 0.16-4 
   postgres.scm file from the latest debian package.

I remember that file, but unfortunately...

   The exports are done after the load-extension, but I am convinced it 
   could be done in the define-module #:export clause, could it not?

... my uncertainty is w/ Guile 1.8.x and later, and not w/ 1.6.x (and
1.4.x which have similar capabilities re loading .so files as modules).

thi

Re: Debian guile-1.8 and ttn guile-pg

[Greg Troxel]

I ma pretty sure that 1.6 and 1.8 behave the same way when one loads a
.so when in a module context.  It's just that 1.8 no longer has the code
that satisfies a require by loading a .so.

So the export statements that David posted from debian look fine to me,
and the least confusing way to do things.  define-public isn't right,
because the symbol is defined after loading the .so, just not exported.