From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Mark H Weaver Newsgroups: gmane.comp.gnu.guix.devel,gmane.lisp.guile.user Subject: Re: guile-gdbm doesn't work with gdbm-1.14 Date: Mon, 19 Mar 2018 12:17:35 -0400 Message-ID: <87605sdops.fsf@netris.org> References: <874lldvktm.fsf@member.fsf.org> <87efkhebmf.fsf@netris.org> <87zi34cqow.fsf@elephly.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1521476218 8540 195.159.176.226 (19 Mar 2018 16:16:58 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 19 Mar 2018 16:16:58 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) Cc: guix-devel@gnu.org, guile-user@gnu.org To: Ricardo Wurmus Original-X-From: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Mon Mar 19 17:16:54 2018 Return-path: Envelope-to: gcggd-guix-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1exxSw-00028k-1w for gcggd-guix-devel@m.gmane.org; Mon, 19 Mar 2018 17:16:54 +0100 Original-Received: from localhost ([::1]:42868 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1exxUy-00089n-SL for gcggd-guix-devel@m.gmane.org; Mon, 19 Mar 2018 12:19:00 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43713) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1exxUW-00087L-G2 for guix-devel@gnu.org; Mon, 19 Mar 2018 12:18:33 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1exxUV-0001cy-75 for guix-devel@gnu.org; Mon, 19 Mar 2018 12:18:32 -0400 Original-Received: from world.peace.net ([50.252.239.5]:40024) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1exxUP-0001Xf-K9; Mon, 19 Mar 2018 12:18:25 -0400 Original-Received: from pool-72-93-29-2.bstnma.east.verizon.net ([72.93.29.2] helo=jojen) by world.peace.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1exxUN-00008n-DN; Mon, 19 Mar 2018 12:18:23 -0400 In-Reply-To: <87zi34cqow.fsf@elephly.net> (Ricardo Wurmus's message of "Mon, 19 Mar 2018 11:20:15 +0100") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 50.252.239.5 X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Original-Sender: "Guix-devel" Xref: news.gmane.org gmane.comp.gnu.guix.devel:41922 gmane.lisp.guile.user:14494 Archived-At: Ricardo Wurmus writes: > Mark H Weaver writes: > >> iyzsong@member.fsf.org (=E5=AE=8B=E6=96=87=E6=AD=A6) writes: >> >>> Hello, since version 1.14, gdbm doesn't export "gdbm_errno" anymore [1], >>> so the guile-gdbm ffi binding code [2] need updates now (I'm not >>> confident to do it myself...). >>> >>> [1] http://git.gnu.org.ua/cgit/gdbm.git/commit/?id=3Dc175231e2781abd17e= abf412cfb597654a076c7b >>> [2] https://github.com/ijp/guile-gdbm/blob/master/gdbm.scm#L156 >> >> Here's a preliminary fix. > > Thank you. > >> * gnu/packages/patches/guile-gdbm-ffi-support-gdbm-1.14.patch: New file. >> * gnu/local.mk (dist_patch_DATA): Add it. >> * gnu/packages/guile.scm (guile-gdbm-ffi)[native-inputs]: New field. >> [inputs]: Move above arguments. Add the patch, and the 'patch' program. >> [propagated-inputs]: Move above arguments. >> [arguments]: In the builder, add code to apply the patch. > > I don=E2=80=99t see the native-inputs field in the patch. Indeed, sorry for the mistake in the commit log. Initially I made them native inputs, but then I moved them to 'inputs'. > Shouldn=E2=80=99t the =E2=80=9Cpatch=E2=80=9D and =E2=80=9Cpatch-file=E2= =80=9D inputs be native-inputs? Yes. However, I noticed that the package already assumes a native build, because it runs 'guile' from 'inputs' to compile the Scheme code. Also, I wasn't sure off-hand how native-inputs are handled in the trivial-build-system. For purposes of this commit, I didn't want to take on the job of also fixing this package for cross-building, which I was likely to get wrong without testing. Given that I no longer use substitutes, that would have been a big job. Does that make sense? Mark