From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel,gmane.lisp.guile.user Subject: Re: [PATCH 1/3] Support Guile backtraces in compilation mode. Date: Fri, 08 Aug 2014 16:47:46 +0300 Message-ID: <838umzm6t9.fsf@gnu.org> References: <1407495956-20322-1-git-send-email-janneke@gnu.org> <1407495956-20322-2-git-send-email-janneke@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1407505699 3579 80.91.229.3 (8 Aug 2014 13:48:19 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 8 Aug 2014 13:48:19 +0000 (UTC) Cc: guile-user@gnu.org, emacs-devel@gnu.org To: Jan Nieuwenhuizen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Aug 08 15:48:12 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XFkWf-0007qB-Ek for ged-emacs-devel@m.gmane.org; Fri, 08 Aug 2014 15:48:09 +0200 Original-Received: from localhost ([::1]:51215 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XFkWf-0002Sd-0W for ged-emacs-devel@m.gmane.org; Fri, 08 Aug 2014 09:48:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53085) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XFkWV-0002LY-Sf for emacs-devel@gnu.org; Fri, 08 Aug 2014 09:48:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XFkWP-0007YA-Vm for emacs-devel@gnu.org; Fri, 08 Aug 2014 09:47:59 -0400 Original-Received: from mtaout26.012.net.il ([80.179.55.182]:60585) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XFkWP-0007Xu-Ne; Fri, 08 Aug 2014 09:47:53 -0400 Original-Received: from conversion-daemon.mtaout26.012.net.il by mtaout26.012.net.il (HyperSendmail v2007.08) id <0N9Z00600Q8A2P00@mtaout26.012.net.il>; Fri, 08 Aug 2014 16:46:36 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout26.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N9Z004LSQ9OJ310@mtaout26.012.net.il>; Fri, 08 Aug 2014 16:46:36 +0300 (IDT) In-reply-to: <1407495956-20322-2-git-send-email-janneke@gnu.org> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 80.179.55.182 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:173480 gmane.lisp.guile.user:11385 Archived-At: > From: Jan Nieuwenhuizen > Date: Fri, 8 Aug 2014 13:05:54 +0200 > > +(defcustom compilation-guile-load-path '("/usr/share/guile/2.0" "/usr/share/guile/site") Not a good idea, IMO. This is inherently system-dependent, and doesn't support Guile installations with non-default $(prefix). IOW, it's unreliable. How about invoking the Guile executable and asking it to emit the path? That would be reliable and portable. > + "Path to locate Guile soure files for incomplete (Guile %load-path based) error messages. If compilation-guile-load-path-p is non-nil, it is dynamically set from Guile." Please break the doc string into lines that are shorter than 75 columns, that's our coding practice. Thanks.