unofficial mirror of guile-user@gnu.org 
 help / color / mirror / Atom feed
From: Sebastian Tennant <sebyte@smolny.plus.com>
To: guile-user@gnu.org
Subject: Re: Uploading Word documents, PDFs, PNG files etc
Date: Wed, 13 May 2009 19:09:35 +0000	[thread overview]
Message-ID: <7i0kzuog.fsf@vps203.linuxvps.org> (raw)
In-Reply-To: 87vdo5qc52.fsf@gnu.org

Quoth ludo@gnu.org (Ludovic Courtès):
> Hello,
>
> Sebastian Tennant <sebyte@smolny.plus.com> writes:
>
>> (info "(guile-1.8)Regexp Functions")
>>
>>  "Zero bytes (`#\nul') cannot be used in regex patterns or input
>>   strings, since the underlying C functions treat that as the end of
>>   string.  If there's a zero byte an error is thrown."
>
> I think it makes sense to explicitly restrict regexps to actual text as
> opposed to binary data.

On second thoughts, I'm not so sure... shouldn't users have the option
(either at compile time, or better still, in userland)?

Restricting regexps to actual text is fine... until you need to grep
binary data, or, as in this case, a combination of text and binary data.

I thought it was going to be trivial to replace the call to regexp-exec
in cgi.scm that extracted the uploaded (possibly binary) file, because
the pattern identifying the beginning of the file in the raw data string
is simple ("\n\r\n\r") - but I now realise that many calls to
regexp-exec in cgi.scm will need to be replaced, some with complex
matching patterns, so I can't see how this can be done without using
regexps, hence my changed opinion.

The only thing I can think of doing now is replacing calls to
regexp-exec with system calls to grep (which can accept binary data) -
clearly sub-optimal and non-trivial.

Anyone have any other ideas?  How easy would it be to build a guile with
a regex feature that doesn't implement this restriction on binary data?

Seb
-- 
Emacs' AlsaPlayer - Music Without Jolts
Lightweight, full-featured and mindful of your idyllic happiness.
http://home.gna.org/eap





  parent reply	other threads:[~2009-05-13 19:09 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-10 16:21 Uploading Word documents, PDFs, PNG files etc Sebastian Tennant
2009-05-11 15:11 ` Ludovic Courtès
2009-05-11 15:55   ` Thien-Thi Nguyen
2009-05-11 23:17     ` Ludovic Courtès
2009-05-12  3:15 ` Thien-Thi Nguyen
2009-05-12 10:15   ` Sebastian Tennant
2009-05-12 10:33     ` Ludovic Courtès
2009-05-12 11:16       ` Sebastian Tennant
2009-05-13 14:02   ` Sebastian Tennant
2009-05-13 15:02     ` Ludovic Courtès
2009-05-13 18:01       ` Sebastian Tennant
2009-05-13 19:09       ` Sebastian Tennant [this message]
2009-05-13 19:23         ` Linas Vepstas
2009-05-14  3:47           ` Keith Wright
2009-05-14 12:49             ` Sebastian Tennant
2009-05-14 13:13               ` Sebastian Tennant
2009-05-17 21:55               ` Ludovic Courtès
2009-05-19  4:48                 ` Sebastian Tennant
2009-05-19  4:59                   ` Sebastian Tennant
2009-05-19  7:50                   ` Ludovic Courtès
2009-05-21  5:22                     ` Sebastian Tennant
2009-05-21 10:47                       ` Thien-Thi Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7i0kzuog.fsf@vps203.linuxvps.org \
    --to=sebyte@smolny.plus.com \
    --cc=guile-user@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).