From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Linas Vepstas" Newsgroups: gmane.lisp.guile.user Subject: Re: Patch to Guile-DBI: SCM_ASSERT Date: Tue, 11 Nov 2008 08:36:28 -0600 Message-ID: <3ae3aa420811110636i263de5bcn3766c8471beaf87f@mail.gmail.com> References: <3ae3aa420811101444p3488b456u9fcf243f0a5cb9be@mail.gmail.com> <406962.97326.qm@web37901.mail.mud.yahoo.com> Reply-To: linasvepstas@gmail.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1226414224 14609 80.91.229.12 (11 Nov 2008 14:37:04 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 11 Nov 2008 14:37:04 +0000 (UTC) Cc: Guile User Mailing List To: "Mike Gran" Original-X-From: guile-user-bounces+guile-user=m.gmane.org@gnu.org Tue Nov 11 15:38:05 2008 Return-path: Envelope-to: guile-user@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KzuNH-0001bw-35 for guile-user@m.gmane.org; Tue, 11 Nov 2008 15:37:47 +0100 Original-Received: from localhost ([127.0.0.1]:45668 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KzuM9-0002US-B8 for guile-user@m.gmane.org; Tue, 11 Nov 2008 09:36:37 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KzuM3-0002UB-MV for guile-user@gnu.org; Tue, 11 Nov 2008 09:36:31 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KzuM1-0002Tk-OE for guile-user@gnu.org; Tue, 11 Nov 2008 09:36:30 -0500 Original-Received: from [199.232.76.173] (port=36367 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KzuM1-0002TX-EJ for guile-user@gnu.org; Tue, 11 Nov 2008 09:36:29 -0500 Original-Received: from rn-out-0910.google.com ([64.233.170.189]:30143) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KzuM1-0001S7-9m for guile-user@gnu.org; Tue, 11 Nov 2008 09:36:29 -0500 Original-Received: by rn-out-0910.google.com with SMTP id k32so2475790rnd.7 for ; Tue, 11 Nov 2008 06:36:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:reply-to :to:subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=CQ1D/LHePnTWLxQpI8XqaG6YKCbMGINdzhUUY87qUKM=; b=jzw5rXMgt+5euLsXm9vTGArx2L/SGZHafReRY6cqLJMqigiMlpGtTRW9TjNmGwP7/x fSs+BU9tlZu9yWVIN2x3mLX2j+/+ZNgeDv+K+dKOr2MF3aq/UIXTYQ8576rkw2BZesNI A1JfJA/6HdE4x6WpO0Itv9b9qHvNsdVTfITQQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:reply-to:to:subject:cc:in-reply-to :mime-version:content-type:content-transfer-encoding :content-disposition:references; b=fxB0qkIiwC7qLF833qCVHQULJ7JSakRcd38rxuy4ZWrF2tp42kkoVMqoo3zXNx5XBp skjZDcoCzomvkrUYPjPRZstCDpTnPPdGl3s5A/WFv89y49fRvdjgMTD2VrnQDfTDkKl3 n2hpYbiSPczqT0OvsC3zqQyiQ1IzIsDP4+bz8= Original-Received: by 10.100.96.9 with SMTP id t9mr2921951anb.109.1226414188206; Tue, 11 Nov 2008 06:36:28 -0800 (PST) Original-Received: by 10.100.249.18 with HTTP; Tue, 11 Nov 2008 06:36:28 -0800 (PST) In-Reply-To: <406962.97326.qm@web37901.mail.mud.yahoo.com> Content-Disposition: inline X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: guile-user@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: General Guile related discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-user-bounces+guile-user=m.gmane.org@gnu.org Errors-To: guile-user-bounces+guile-user=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.user:6869 Archived-At: Hi! 2008/11/10 Mike Gran : > A patch. SCM_ASSERT usually uses the scheme function name in the assertion error instead of the C function name. Also, in make_g_db_handle, the assertion for the second parameter is incorrect. Wow! Unexpected -- thanks! I've applied it; now I'll have to spin 2.1.2 someday. Did you find this by code review, or have you been carrying this patch for a while? I was wondering if I was the sole user in the world of this stuff. --linas