unofficial mirror of guile-user@gnu.org 
 help / color / mirror / Atom feed
From: "Linas Vepstas" <linasvepstas@gmail.com>
To: "Mike Gran" <spk121@yahoo.com>
Cc: Guile User Mailing List <guile-user@gnu.org>
Subject: Re: Patch to Guile-DBI: SCM_ASSERT
Date: Tue, 11 Nov 2008 08:36:28 -0600	[thread overview]
Message-ID: <3ae3aa420811110636i263de5bcn3766c8471beaf87f@mail.gmail.com> (raw)
In-Reply-To: <406962.97326.qm@web37901.mail.mud.yahoo.com>

Hi!

2008/11/10 Mike Gran <spk121@yahoo.com>:
> A patch.  SCM_ASSERT usually uses the scheme function name in the assertion error instead of the C function name.  Also, in make_g_db_handle, the assertion for the second parameter is incorrect.

Wow!  Unexpected -- thanks!  I've applied it; now I'll have to spin 2.1.2
someday.

Did you find this by code review, or have you been carrying this patch
for a while? I was wondering if I was the sole user in the world of this
stuff.

--linas




  reply	other threads:[~2008-11-11 14:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-10 22:44 ANNOUNCE: Guile-DBI version 2.1.1 Linas Vepstas
2008-11-11  4:32 ` Patch to Guile-DBI: SCM_ASSERT Mike Gran
2008-11-11 14:36   ` Linas Vepstas [this message]
2008-11-11 16:31     ` Mike Gran
2008-11-11 16:45       ` Linas Vepstas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3ae3aa420811110636i263de5bcn3766c8471beaf87f@mail.gmail.com \
    --to=linasvepstas@gmail.com \
    --cc=guile-user@gnu.org \
    --cc=spk121@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).