From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: David Pirotte Newsgroups: gmane.lisp.guile.user Subject: Re: guile-cairo - patch Date: Fri, 24 Mar 2023 00:19:36 -0300 Message-ID: <20230324001936.57e4799f@aicha> References: <20230321020531.0417f3d9@aicha> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/xAaP990JtudZYMA/XMJYKTP"; protocol="application/pgp-signature"; micalg=pgp-sha512 Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23530"; mail-complaints-to="usenet@ciao.gmane.io" To: guile-user Original-X-From: guile-user-bounces+guile-user=m.gmane-mx.org@gnu.org Fri Mar 24 17:19:35 2023 Return-path: Envelope-to: guile-user@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pfk8c-0005iz-U6 for guile-user@m.gmane-mx.org; Fri, 24 Mar 2023 17:19:34 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pfk7u-0002zZ-5m; Fri, 24 Mar 2023 12:18:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pfk7l-0002ag-PK for guile-user@gnu.org; Fri, 24 Mar 2023 12:18:41 -0400 Original-Received: from sys2.all2all.org ([79.99.200.14] helo=moses.all2all.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pfk7h-0000W5-Ua for guile-user@gnu.org; Fri, 24 Mar 2023 12:18:40 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by moses.all2all.org (Postfix) with ESMTP id D272267C007E for ; Fri, 24 Mar 2023 04:19:44 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at moses.all2all.org Original-Received: from moses.all2all.org ([127.0.0.1]) by localhost (moses.all2all.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qCYmHASEqHCh for ; Fri, 24 Mar 2023 04:19:43 +0100 (CET) Original-Received: from aicha (unknown [179.210.48.245]) by moses.all2all.org (Postfix) with ESMTPSA id 98F7E67C007A for ; Fri, 24 Mar 2023 04:19:42 +0100 (CET) In-Reply-To: <20230321020531.0417f3d9@aicha> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.37; x86_64-pc-linux-gnu) Received-SPF: pass client-ip=79.99.200.14; envelope-from=david@altosw.be; helo=moses.all2all.org X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guile-user@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: General Guile related discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-user-bounces+guile-user=m.gmane-mx.org@gnu.org Original-Sender: guile-user-bounces+guile-user=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.lisp.guile.user:18954 Archived-At: --Sig_/xAaP990JtudZYMA/XMJYKTP Content-Type: multipart/mixed; boundary="MP_/dbSZJ1TyWWPJl6H3yT=_Nkm" --MP_/dbSZJ1TyWWPJl6H3yT=_Nkm Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Hello Daniel, > Here comes 1 (attached) patch, which fixes both 'make check' > and 'make distcheck'. > ... Here is another patch, to be applied after the previous one, see the commit log ... [1] David [1] a bit more on this ... 1- This patch removes the call to m4_esyscmd, which itself called build-aux/git-version-gen which i removed from the EXTRA_DIST target in the previous patch. 2- Speaking about version, you might consider - I won't do that myself, as I can't regenerate, hence I can't fully check - to update the doc/guile-cairo.texi file to call @include version.texi ... instead of manually set VERSION and UPDATED because when automake detect the above, it generates the version.texi file which contains the above and more ... and then as a dev, you'd have one and only one location to take care of when updating the version - s/w wise, we still have to manually update the NEW file [and the web-pages (?)] --MP_/dbSZJ1TyWWPJl6H3yT=_Nkm Content-Type: text/x-patch Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename=0002-Build-review-configure.ac.patch =46rom 5d701e9d16add264cc8dc1f4b17fc5e5c1029201 Mon Sep 17 00:00:00 2001 From: David Pirotte Date: Thu, 23 Mar 2023 23:34:28 -0300 Subject: [PATCH 2/2] Build review - configure.ac * configure.ac: Manually set the version in the AC_INIT call. Removing the AC_SUBST(VERSION, x.y.z) call, it is generated. --- configure.ac | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index 274d825..27aa373 100644 --- a/configure.ac +++ b/configure.ac @@ -3,7 +3,7 @@ define(GUILE_CAIRO_CONFIGURE_COPYRIGHT,[[ Copyright (C) 2007, 2011-2012, 2014, 2017, 2020 Andy Wingo Copyright (C) 2011 Patrick Bernaud Copyright (C) 2018 Daniel Llorens -Copyright (C) 2018 David Pirotte +Copyright (C) 2018, 2023 David Pirotte =20 This program is free software: you can redistribute it and/or modify it under the terms of the GNU Lesser General Public License as @@ -24,7 +24,7 @@ License along with this program. If not, see AC_PREREQ(2.52) =20 AC_INIT([guile-cairo], - m4_esyscmd([build-aux/git-version-gen --match v1.11.2\* .tarball-v= ersion]), + [1.12.0], [guile-user@gnu.org]) AC_CONFIG_AUX_DIR([build-aux]) AC_CONFIG_MACRO_DIR([m4]) @@ -37,7 +37,6 @@ AM_INIT_AUTOMAKE([1.14 gnu -Wno-portability -Wno-syntax \ AM_MAINTAINER_MODE([enable]) AM_SILENT_RULES([yes]) =20 -AC_SUBST(VERSION, 1.12.0) =20 AC_ISC_POSIX AC_PROG_CC --=20 2.39.2 --MP_/dbSZJ1TyWWPJl6H3yT=_Nkm-- --Sig_/xAaP990JtudZYMA/XMJYKTP Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEhCJlRZtBM3furJHe83T9k6MFetcFAmQdFsgACgkQ83T9k6MF etcOaggA27VNMz9wK/iwPBBjOAb/NCN63ezLlWgWkE+aWjcMDWhmWhXOTIss3ozs mFEAeC0Kjkromq6KdBpluUcLMI/E/8a4BLqTQF0shRvqBuFHFq8fb0IA95vjIT6T UBaLG+8DsIhoNX+wZ8eBXO33/YZb0/eOCNdyNi0QwZExDLFqX2JeqmAlse1gOjBd lGU0pRzYmaR8zJouEM6vQWmS+iY0hsAePyHYIAhgyKYIzJZWkVSC1A/76rTCSfBx tdYR3RqY0QR00wz1KbSlVRjvS8DUzl8pBXbNOaDYjdMMZhbsMUYtsekx0e2zf8Dh KTjQLG3A1TNpLbaBBZcve6zYXyTFMA== =Az3A -----END PGP SIGNATURE----- --Sig_/xAaP990JtudZYMA/XMJYKTP--