From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: David Pirotte Newsgroups: gmane.lisp.guile.user Subject: Re: guile-cairo - patch Date: Thu, 23 Mar 2023 01:07:10 -0300 Message-ID: <20230323010710.45b09944@aicha> References: <20230321020531.0417f3d9@aicha> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/3ruMvqjIaIKrV_yAFCTUpoE"; protocol="application/pgp-signature"; micalg=pgp-sha512 Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14275"; mail-complaints-to="usenet@ciao.gmane.io" Cc: guile-user To: lloda Original-X-From: guile-user-bounces+guile-user=m.gmane-mx.org@gnu.org Thu Mar 23 05:08:12 2023 Return-path: Envelope-to: guile-user@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pfCFI-0003X7-B5 for guile-user@m.gmane-mx.org; Thu, 23 Mar 2023 05:08:12 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pfCEd-0002es-Pz; Thu, 23 Mar 2023 00:07:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pfCEZ-0002eX-Dl for guile-user@gnu.org; Thu, 23 Mar 2023 00:07:27 -0400 Original-Received: from moses.all2all.org ([79.99.200.14]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pfCEX-0003P0-Ju for guile-user@gnu.org; Thu, 23 Mar 2023 00:07:27 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by moses.all2all.org (Postfix) with ESMTP id DBA6567C007A; Thu, 23 Mar 2023 05:07:17 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at moses.all2all.org Original-Received: from moses.all2all.org ([127.0.0.1]) by localhost (moses.all2all.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bSbIjGmVnq-o; Thu, 23 Mar 2023 05:07:17 +0100 (CET) Original-Received: from aicha (unknown [179.210.48.245]) by moses.all2all.org (Postfix) with ESMTPSA id 9615A67C0078; Thu, 23 Mar 2023 05:07:16 +0100 (CET) In-Reply-To: X-Mailer: Claws Mail 4.1.1 (GTK 3.24.37; x86_64-pc-linux-gnu) Received-SPF: pass client-ip=79.99.200.14; envelope-from=david@altosw.be; helo=moses.all2all.org X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guile-user@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: General Guile related discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-user-bounces+guile-user=m.gmane-mx.org@gnu.org Original-Sender: guile-user-bounces+guile-user=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.lisp.guile.user:18952 Archived-At: --Sig_/3ruMvqjIaIKrV_yAFCTUpoE Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Daniel, > the patch works fine on my side and fixes make check/distcheck as > you describe, thank you. Ok, great. > However I think it's unfortunate that it requires the dynamic library > path to be adjusted after installation, which is something that > guile-cairo was handling before. This is a private library that is of > no use except to guile-cairo itself. The patch 'removed' the hard coded 'full path' of the lib set at configure/make time, which i think is a good thing - and it indeed install the lib in $prefix/lib - which is, imo, unless a configure option allows 'another location', the right thing to do - but, see below ... > I wonder if it's possible to fix your fix, so to speak, so that we > don't lose that feature. After all, you're already telling Guile to > find the library in different places depending on whether we're on > the build environment or not. > Wdyt. It is possible, with a bit of work, to install the lib in the GUILE_EXTENSION directory [provided by guile.m4], but be able to look into this in the 'immediate near future' - feel free to patch the patch of course. Regards, David --Sig_/3ruMvqjIaIKrV_yAFCTUpoE Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEhCJlRZtBM3furJHe83T9k6MFetcFAmQb0G4ACgkQ83T9k6MF etf4wQf9F/YAhK7cVfzig/lzDywdZlCUq4Kmi2Y3PiwtmXlgjn7m5layg6HxHUjP Ec9SFAlz+XjYOCjPGxmgDU9Q5WpkMGzCdPR1xWC8r+78CnfFTomP0KBo+nOmwHd8 7beFoRuTHqMrb8SRkwQ2Lnf8LxPMhu3kJwZTIWc3UYF/rndie/CaaCBc6jiRkIO+ ThoZoMDm1Nce96sy6VibhokcKSFfnfwyitfCKoerYc3Bzx8pgC01RAoPKB3/jUEo 5LVZWkMtxTHxm2dkAiwW5u/ZObTrIH4SXQIsFkaEZiaI5E2PUOaIB6C32rp8uGlm r1LYaqMLGzCwfEOul6oU/bcscnSGkQ== =OTDa -----END PGP SIGNATURE----- --Sig_/3ruMvqjIaIKrV_yAFCTUpoE--