From: David Pirotte <david@altosw.be>
To: lloda <lloda@sarc.name>
Cc: guile-user <guile-user@gnu.org>
Subject: Re: guile-cairo - patch
Date: Thu, 23 Mar 2023 01:07:10 -0300 [thread overview]
Message-ID: <20230323010710.45b09944@aicha> (raw)
In-Reply-To: <AAB3ECB1-9299-485D-8F28-A4FE895BBC81@sarc.name>
[-- Attachment #1: Type: text/plain, Size: 1161 bytes --]
Hi Daniel,
> the patch works fine on my side and fixes make check/distcheck as
> you describe, thank you.
Ok, great.
> However I think it's unfortunate that it requires the dynamic library
> path to be adjusted after installation, which is something that
> guile-cairo was handling before. This is a private library that is of
> no use except to guile-cairo itself.
The patch 'removed' the hard coded 'full path' of the lib set at
configure/make time, which i think is a good thing - and it indeed
install the lib in $prefix/lib - which is, imo, unless a configure
option allows 'another location', the right thing to do - but,
see below ...
> I wonder if it's possible to fix your fix, so to speak, so that we
> don't lose that feature. After all, you're already telling Guile to
> find the library in different places depending on whether we're on
> the build environment or not.
> Wdyt.
It is possible, with a bit of work, to install the lib in the
GUILE_EXTENSION directory [provided by guile.m4], but be able to look
into this in the 'immediate near future' - feel free to patch the patch
of course.
Regards,
David
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-03-23 4:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 5:05 guile-cairo - patch David Pirotte
2023-03-21 16:04 ` lloda
2023-03-23 4:07 ` David Pirotte [this message]
2023-03-24 3:19 ` David Pirotte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230323010710.45b09944@aicha \
--to=david@altosw.be \
--cc=guile-user@gnu.org \
--cc=lloda@sarc.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).