unofficial mirror of guile-user@gnu.org 
 help / color / mirror / Atom feed
From: David Pirotte <david@altosw.be>
To: Jan Nieuwenhuizen <janneke@gnu.org>
Cc: guile-user <guile-user@gnu.org>,
	guile-gtk-general <guile-gtk-general@gnu.org>
Subject: Re: [PATCH]: gobject: also loop args after #:gsignal. Fixes multiple signals per class.
Date: Thu, 4 Apr 2013 13:54:49 -0300	[thread overview]
Message-ID: <20130404135449.508bb261@capac> (raw)
In-Reply-To: <878v4yu0nu.fsf@nlvehvbe01nb29b.ddns.nl-htc01.nxp.com>

Hello Jan,

> -      (if (not (null? args))
> +      (when (not (null? args))

I did not 'check' your patch, but reading it very quickly I have a 2c suggestion :)

	(unless (null? args) ...

Cheers,
David

  reply	other threads:[~2013-04-04 16:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-04  9:04 [PATCH]: gobject: also loop args after #:gsignal. Fixes multiple signals per class Jan Nieuwenhuizen
2013-04-04 16:54 ` David Pirotte [this message]
2013-04-09  5:51 ` Mark H Weaver

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130404135449.508bb261@capac \
    --to=david@altosw.be \
    --cc=guile-gtk-general@gnu.org \
    --cc=guile-user@gnu.org \
    --cc=janneke@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).