unofficial mirror of guile-user@gnu.org 
 help / color / mirror / Atom feed
From: David Fang <fang@csl.cornell.edu>
To: <guile-user@gnu.org>
Subject: libguile/__scm.h patchlet
Date: Thu, 8 Mar 2007 15:30:40 -0500 (EST)	[thread overview]
Message-ID: <20070308150440.S22277-100000@shannon.csl.cornell.edu> (raw)

Hi,
	I'm encountering a minor annnoyance in the guile-1.6 headers:

#ifdef STDC_HEADERS
# include <stdlib.h>
# if HAVE_SYS_TYPES_H
#  include <sys/types.h>
# endif
# if HAVE_SYS_STDTYPES_H
#  include <sys/stdtypes.h>
# endif
#  include <stddef.h>
#endif /* def STDC_HEADERS */

On systems that are missing <sys/types.h> or <sys/stdtypes.h> (more
likely), I can't use -Werror to compile because the configure headers
don't define say HAVE_SYS_STDTYPES_H, which trips a warning like:

/sw/include/libguile/__scm.h:315:6: "HAVE_SYS_STDTYPES_H" is not defined
In file included from /sw/include/libguile.h:97,

which is then promoted to an error (by request).  A discussion in recent
months on the autoconf mailing list concluded that
"#ifdef HAVE_SOME_HEADER_H" was a more appropriate usage of config.h
macros.

Might I request the macro tests in the above context be updated
accordingly (#ifdef in place of #if)?

guile-1.8's headers also have two instances of "#if HAVE" in the headers
are on standard headers that are usually found.

/sw/include/libguile/tags.h:#if HAVE_INTTYPES_H
/sw/include/libguile/tags.h:# if HAVE_STDINT_H

Either way, it's not a big deal, I can always override with -Wno-error.
This is the only problem with the headers I've found, so the headers are
in quite good shape.


Thanks.


David Fang
Computer Systems Laboratory
Electrical & Computer Engineering
Cornell University
http://www.csl.cornell.edu/~fang/
	-- (2400 baud? Netscape 3.0?? lynx??? No problem!)



_______________________________________________
Guile-user mailing list
Guile-user@gnu.org
http://lists.gnu.org/mailman/listinfo/guile-user


                 reply	other threads:[~2007-03-08 20:30 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070308150440.S22277-100000@shannon.csl.cornell.edu \
    --to=fang@csl.cornell.edu \
    --cc=guile-user@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).