From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Mikael Djurfeldt Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] fix broken slot allocation Date: Fri, 11 Apr 2003 11:29:19 +0200 Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Message-ID: References: <20030406115700.GA13339@lark> Reply-To: djurfeldt@nada.kth.se NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1050053537 14156 80.91.224.249 (11 Apr 2003 09:32:17 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Fri, 11 Apr 2003 09:32:17 +0000 (UTC) Cc: djurfeldt@nada.kth.se Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Fri Apr 11 11:32:16 2003 Return-path: Original-Received: from monty-python.gnu.org ([199.232.76.173]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 193utL-0003g9-00 for ; Fri, 11 Apr 2003 11:32:16 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 193us3-0001u1-01 for guile-devel@m.gmane.org; Fri, 11 Apr 2003 05:30:55 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10.13) id 193uqo-0001Gu-00 for guile-devel@gnu.org; Fri, 11 Apr 2003 05:29:38 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10.13) id 193uqg-00013x-00 for guile-devel@gnu.org; Fri, 11 Apr 2003 05:29:31 -0400 Original-Received: from kvast.blakulla.net ([213.212.20.77]) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 193uqa-0000ob-00 for guile-devel@gnu.org; Fri, 11 Apr 2003 05:29:24 -0400 Original-Received: from dyna224-222.nada.kth.se ([130.237.224.222] helo=linnaeus) by kvast.blakulla.net with esmtp (Exim 3.36 #1 (Debian)) id 193uqW-0002nF-00; Fri, 11 Apr 2003 11:29:20 +0200 Original-Received: from mdj by linnaeus with local (Exim 3.36 #1 (Debian)) id 193uqV-00036H-00; Fri, 11 Apr 2003 11:29:19 +0200 Original-To: Andy Wingo , guile-devel@gnu.org In-Reply-To: (Mikael Djurfeldt's message of "Mon, 07 Apr 2003 20:16:39 +0200") User-Agent: Gnus/5.090017 (Oort Gnus v0.17) Emacs/21.2 (gnu/linux) X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Developers list for Guile, the GNU extensibility library List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.lisp.guile.devel:2152 X-Report-Spam: http://spam.gmane.org/gmane.lisp.guile.devel:2152 Mikael Djurfeldt writes: >> The aforementioned problem with guile-gobject goes away when this patch >> is applied. > > Obviously, the original code is buggy. However, your fix is not > correct: Slots which don't have instance allocation should not have a > corresponding layout entry, so the index should indeed not be updated. I finally got a moment to look at this. It turns out that the goops.c code looks correct. The problem seems to be in guile-gobject. Could you please give me instructions how to provoke this bug? (Please make it as simple as possible). Best regards, Mikael D. _______________________________________________ Guile-devel mailing list Guile-devel@gnu.org http://mail.gnu.org/mailman/listinfo/guile-devel