From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Matthias Koeppe Newsgroups: gmane.lisp.guile.devel Subject: Re: Patch for ice-9/format.scm (removes arbitrary ~{...~} iteration limit) Date: Mon, 19 Jul 2004 11:04:28 +0200 Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Message-ID: References: <87vfgwisdv.fsf@zip.com.au> <87hds42585.fsf@zip.com.au> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1090227925 2020 80.91.224.253 (19 Jul 2004 09:05:25 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 19 Jul 2004 09:05:25 +0000 (UTC) Cc: guile-devel@gnu.org Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Mon Jul 19 11:05:10 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1BmU58-0008Bv-00 for ; Mon, 19 Jul 2004 11:05:10 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1BmU7o-0000yQ-5a for guile-devel@m.gmane.org; Mon, 19 Jul 2004 05:07:56 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1BmU7j-0000wu-7U for guile-devel@gnu.org; Mon, 19 Jul 2004 05:07:51 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1BmU7i-0000wi-Gj for guile-devel@gnu.org; Mon, 19 Jul 2004 05:07:50 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1BmU7i-0000wf-CH for guile-devel@gnu.org; Mon, 19 Jul 2004 05:07:50 -0400 Original-Received: from [141.44.75.40] (helo=merkur.math.uni-magdeburg.de) by monty-python.gnu.org with esmtp (Exim 4.34) id 1BmU4Z-0002TI-NO for guile-devel@gnu.org; Mon, 19 Jul 2004 05:04:35 -0400 Original-Received: from gamma ([141.44.75.90] helo=gamma.math.uni-magdeburg.de) by merkur.math.uni-magdeburg.de with esmtp (Exim 4.10) id 1BmU4V-0006o5-00; Mon, 19 Jul 2004 11:04:31 +0200 Original-Received: (from mkoeppe@localhost) by gamma.math.uni-magdeburg.de (8.12.9+Sun/8.12.9/Submit) id i6J94SsE011350; Mon, 19 Jul 2004 11:04:28 +0200 (MEST) X-Authentication-Warning: gamma.math.uni-magdeburg.de: mkoeppe set sender to mkoeppe@mail.math.uni-magdeburg.de using -f Original-To: Kevin Ryde In-Reply-To: <87hds42585.fsf@zip.com.au> (Kevin Ryde's message of "Mon, 19 Jul 2004 10:47:06 +1000") User-Agent: Gnus/5.110001 (No Gnus v0.1) Emacs/21.3.50 (usg-unix-v) X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.lisp.guile.devel:3871 X-Report-Spam: http://spam.gmane.org/gmane.lisp.guile.devel:3871 Kevin Ryde writes: > Matthias Koeppe writes: >> >> Kevin, could you commit the patch to CVS then? I think this should >> go into HEAD and the stable branch. > > Done. Thanks. Thanks. >> + (pass-if "format ~F (format-out-substr) maintains the column correctly" >> + (= (string-length (format "~@F~20T" 1)) 20))) > > Marius has applied this to the head previously. You can argue for it > in the 1.6 if it addresses some bug or misfeature. It did address a bug, but my patch to fix it is already in CVS. So no need to fix it in the stable branch. (There is little point in having a "stable" and a HEAD test suite, anyway.) >> + (pass-if "format ~{ has no arbitrary iteration limit" >> + (= (string-length (format "~{~a~}" (make-list 200 #\b))) 200))) > > Tests exercising the other three iteration forms (~{ modifiers) would > be nice, since the code for those is separate. All the tests for FORMAT that I have contributed illustrate a bug that I found. Of course a whole test suite for FORMAT would be nice, but I don't have time to work on it. -- Matthias Koeppe -- http://www.math.uni-magdeburg.de/~mkoeppe _______________________________________________ Guile-devel mailing list Guile-devel@gnu.org http://lists.gnu.org/mailman/listinfo/guile-devel