From: Matthias Koeppe <mkoeppe@mail.math.uni-magdeburg.de>
Cc: guile-devel@gnu.org
Subject: Re: Patch for ice-9/format.scm (removes arbitrary ~{...~} iteration limit)
Date: Mon, 19 Jul 2004 11:04:28 +0200 [thread overview]
Message-ID: <uw5r7r8qsf7.fsf@merkur.math.uni-magdeburg.de> (raw)
In-Reply-To: <87hds42585.fsf@zip.com.au> (Kevin Ryde's message of "Mon, 19 Jul 2004 10:47:06 +1000")
Kevin Ryde <user42@zip.com.au> writes:
> Matthias Koeppe <mkoeppe@merkur.math.uni-magdeburg.de> writes:
>>
>> Kevin, could you commit the patch to CVS then? I think this should
>> go into HEAD and the stable branch.
>
> Done. Thanks.
Thanks.
>> + (pass-if "format ~F (format-out-substr) maintains the column correctly"
>> + (= (string-length (format "~@F~20T" 1)) 20)))
>
> Marius has applied this to the head previously. You can argue for it
> in the 1.6 if it addresses some bug or misfeature.
It did address a bug, but my patch to fix it is already in CVS. So no
need to fix it in the stable branch. (There is little point in having
a "stable" and a HEAD test suite, anyway.)
>> + (pass-if "format ~{ has no arbitrary iteration limit"
>> + (= (string-length (format "~{~a~}" (make-list 200 #\b))) 200)))
>
> Tests exercising the other three iteration forms (~{ modifiers) would
> be nice, since the code for those is separate.
All the tests for FORMAT that I have contributed illustrate a bug that
I found. Of course a whole test suite for FORMAT would be nice, but I
don't have time to work on it.
--
Matthias Koeppe -- http://www.math.uni-magdeburg.de/~mkoeppe
_______________________________________________
Guile-devel mailing list
Guile-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/guile-devel
prev parent reply other threads:[~2004-07-19 9:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-25 14:25 Patch for ice-9/format.scm (removes arbitrary ~{...~} iteration limit) Matthias Koeppe
2004-07-10 1:05 ` Kevin Ryde
2004-07-13 8:32 ` Matthias Koeppe
2004-07-19 0:47 ` Kevin Ryde
2004-07-19 9:04 ` Matthias Koeppe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=uw5r7r8qsf7.fsf@merkur.math.uni-magdeburg.de \
--to=mkoeppe@mail.math.uni-magdeburg.de \
--cc=guile-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).