unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: Ken Raeburn <raeburn@raeburn.org>
Subject: Re: built with SCM_DEBUG=1 lately?
Date: Fri, 01 Jul 2005 02:44:47 -0400	[thread overview]
Message-ID: <tx14qbf9g9s.fsf@raeburn.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 818 bytes --]


(BTW, I should've mentioned in my earlier mail tonight that the patch
got me past compilation failures on Linux; my original report
complaining of some format string problems was on a Mac laptop, where
I haven't tried the build again.)

>From the comments, it looks like the list returned by scm_i_dynwinds
can have both cons cells and smob objects in it, like the winder
object that was keeping the snarf step from working for me.

This patch causes the SCM_CDAR invocation to be applied only if the
SCM_CAR is a pair.

BTW, under SCM_DEBUG=1 it'd be nice if SCM_SMOB_OBJECT*,
SCM_SMOB_DATA*, etc, would check that the passed object is a smob.  I
don't think that's happening.

Ken


2005-07-01  Ken Raeburn  <raeburn@raeburn.org>

	* throw.c (scm_ithrow): Only use SCM_CDAR if SCM_CAR is known to
	be a cons cell.


[-- Attachment #2: patch for throw.c to not run SCM_CDR on non-pairs --]
[-- Type: application/octet-stream, Size: 609 bytes --]

Index: throw.c
===================================================================
RCS file: /cvsroot/guile/guile/guile-core/libguile/throw.c,v
retrieving revision 1.107
diff -p -u -r1.107 throw.c
--- throw.c	23 May 2005 19:57:21 -0000	1.107
+++ throw.c	1 Jul 2005 06:41:31 -0000
@@ -623,7 +623,8 @@ scm_ithrow (SCM key, SCM args, int noret
   jmpbuf = SCM_CDR (dynpair);
   
   for (wind_goal = scm_i_dynwinds ();
-       !scm_is_eq (SCM_CDAR (wind_goal), jmpbuf);
+       !(scm_is_pair (SCM_CAR (wind_goal))
+	 && scm_is_eq (SCM_CDAR (wind_goal), jmpbuf));
        wind_goal = SCM_CDR (wind_goal))
     ;
 

[-- Attachment #3: Type: text/plain, Size: 143 bytes --]

_______________________________________________
Guile-devel mailing list
Guile-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/guile-devel

             reply	other threads:[~2005-07-01  6:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-07-01  6:44 Ken Raeburn [this message]
2005-07-12  0:53 ` built with SCM_DEBUG=1 lately? Kevin Ryde
  -- strict thread matches above, loose matches on Subject: below --
2005-07-01  6:18 Ken Raeburn
2005-07-11 23:55 ` Kevin Ryde
2005-06-24  2:50 Ken Raeburn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tx14qbf9g9s.fsf@raeburn.org \
    --to=raeburn@raeburn.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).