From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Greg Troxel Newsgroups: gmane.lisp.guile.devel Subject: Re: _GNU_SOURCE redundant define Date: Fri, 15 Aug 2008 09:32:50 -0400 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1218807209 22621 80.91.229.12 (15 Aug 2008 13:33:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 15 Aug 2008 13:33:29 +0000 (UTC) To: guile-devel@gnu.org Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Fri Aug 15 15:34:22 2008 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KTzRD-0002QI-0x for guile-devel@m.gmane.org; Fri, 15 Aug 2008 15:33:55 +0200 Original-Received: from localhost ([127.0.0.1]:39900 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KTzQG-0006y2-Bb for guile-devel@m.gmane.org; Fri, 15 Aug 2008 09:32:56 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KTzQD-0006wM-8v for guile-devel@gnu.org; Fri, 15 Aug 2008 09:32:53 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KTzQB-0006uQ-IX for guile-devel@gnu.org; Fri, 15 Aug 2008 09:32:52 -0400 Original-Received: from [199.232.76.173] (port=36260 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KTzQB-0006u9-BD for guile-devel@gnu.org; Fri, 15 Aug 2008 09:32:51 -0400 Original-Received: from fnord.ir.bbn.com ([192.1.100.210]:64400) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KTzQB-0002VG-17 for guile-devel@gnu.org; Fri, 15 Aug 2008 09:32:51 -0400 Original-Received: by fnord.ir.bbn.com (Postfix, from userid 10853) id 4565D52A6; Fri, 15 Aug 2008 09:32:50 -0400 (EDT) X-Hashcash: 1:20:080815:guile-devel@gnu.org::Aj4P9EURgDFZ/Zfv:0000000000000000000000000000000000000000000vp1 In-Reply-To: (Greg Troxel's message of "Wed, 13 Aug 2008 13:03:55 -0400") User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/22.1 (berkeley-unix) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:7435 Archived-At: Greg Troxel writes: > On NetBSD-current/amd64, the branch_release-1-8 branch fails to build. > _GNU_SOURCE is defined in config.h, and also in two files. With the > following change, it builds and 'gmake check' succeeds. I have figured this out. With autoconf 2.62 on NetBSD, several macros end up defining _GNU_SOURCE. The following diff makes guile build for me (plus enables autobuild). I'm not sure what the right fix is; it seems broken for AC_AIX to define _GNU_SOURCE at all, especially on NetBSD. I'd be somewhat inclined to drop the three macros, and have adherents of AIX, ISC_POSIX, and MINIX find another way around if needed. Alternatively, the two _GNU_SOURCE defines could be wrapped in ifndef _GNU_SOURCE. Also, I noticed a forced define of _GNU_SOURCE inside the strptime test. The NetBSD man page says: STANDARDS The strptime() function conforms to X/Open Portability Guide Issue 4 (``XPG4''). so it would seem that shouldn't be necessary. diff --git a/configure.in b/configure.in index ee3d527..101de10 100644 --- a/configure.in +++ b/configure.in @@ -49,6 +49,9 @@ AC_CONFIG_SRCDIR([GUILE-VERSION]) AM_MAINTAINER_MODE AC_CONFIG_HEADERS([config.h]) + +AB_INIT + AH_TOP(/*GUILE_CONFIGURE_COPYRIGHT*/) #-------------------------------------------------------------------- @@ -73,10 +76,14 @@ AC_PROG_CC AC_PROG_CPP AC_PROG_AWK -AC_AIX -AC_ISC_POSIX -AC_MINIX +# AC_AIX +dnl AC_AIX +# AC_ISC_POSIX +dnl AC_ISC_POSIX +# AC_MINIX +dnl AC_MINIX +# c89 AC_PROG_CC_C89 # for per-target cflags in the libguile subdir