unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: Greg Troxel <gdt@lexort.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: "guile-devel@gnu.org" <guile-devel@gnu.org>
Subject: Re: GNU Guile 3.0.9rc1 available for testing!
Date: Tue, 24 Jan 2023 20:44:03 -0500	[thread overview]
Message-ID: <rmiv8kv75i4.fsf@s1.lexort.com> (raw)
In-Reply-To: 87h6wh34t0.fsf@gnu.org

Ludovic Courtès <ludo@gnu.org> writes:

> So something like the patch below?
>
> Thanks,
> Ludo’.
>
> diff --git a/libguile/posix.c b/libguile/posix.c
> index 74c743119..0b1fe2637 100644
> --- a/libguile/posix.c
> +++ b/libguile/posix.c
> @@ -105,8 +105,8 @@
>  # else
>  #  define W_EXITCODE(ret, sig)   ((ret) << 8 | (sig))
>  # endif
> -#endif
>  verify (WEXITSTATUS (W_EXITCODE (127, 0)) == 127);
> +#endif
>  
>  
>  #include <signal.h>

I see you pushed that to master and I have done a full build from master
with the pkgsrc JIT workarounds.  It mostly worked and I got this, which
may be because I purged not-needed packages (but the guile build didn't
complain at configure or check time, like it did for missing gperf which
I put back).  Or maybe I just haven't gotten this far with 3.0.9-ish.

    CC       test_foreign_object_c-test-foreign-object-c.o
    CCLD     test-foreign-object-c
  ld: ../../libguile/.libs/libguile-3.0.so: warning: warning: tmpnam() possibly used unsafely, use mkstemp() or mkdtemp()
  ld: /tmp//ccOnwVqC.ltrans0.ltrans.o: in function `finalizer':
  /home/n0/gdt/SOFTWARE/GUILE/guile/BUILD/test-suite/standalone/../../../test-suite/standalone/test-foreign-object-c.c:42: undefined reference to `rpl_free'

LTO seems enabled, but I see ranlib complaints in the build log.  I know
LTO is not new in this micro.  Maybe I'm trailing edge but it seems
slightly like living dangerously if not known to be ok -- but
--disable-lto is easy enough so no worries.

I kicked off a new build with --disable-lto, and that succeeded.  Tests
are not entirely ok, but that's not a regression.  I used the distfile
as a faux release to build guile pkgsrc from, and that built fine and
runs.

There are some issues for me to work through eventually, but for 3.0.9 I
have arrived at being ok with you releasing the current state of git
master (3 commits past rc1) as not having anything I can claim is a
regression and not anything I can't work around as before.

Greg



  parent reply	other threads:[~2023-01-25  1:44 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-20 15:58 GNU Guile 3.0.9rc1 available for testing! Ludovic Courtès
2023-01-20 16:18 ` Thompson, David
2023-01-21 14:58   ` Jan Nieuwenhuizen
2023-01-23 10:42     ` Ludovic Courtès
2023-01-23 13:23       ` Janneke Nieuwenhuizen
2023-01-20 17:50 ` Aleix Conchillo Flaqué
2023-01-23 10:45   ` Ludovic Courtès
2023-01-23 17:01     ` Aleix Conchillo Flaqué
2023-01-22  2:12 ` Greg Troxel
2023-01-22 14:30   ` lloda
2023-01-22 14:39     ` Greg Troxel
2023-01-23 10:48       ` Ludovic Courtès
2023-01-23 18:04         ` lloda
2023-01-23 21:59           ` bug#60971: build failure of v3.0.9rc1 on mac os 12.6 Ludovic Courtès
2023-01-23 18:47         ` GNU Guile 3.0.9rc1 available for testing! Aleix Conchillo Flaqué
2023-01-25  1:44         ` Greg Troxel [this message]
2023-01-25 10:32           ` Ludovic Courtès
2023-01-22 17:41   ` Greg Troxel
2023-01-22 23:10     ` Greg Troxel
2023-01-23 11:02       ` Ludovic Courtès
2023-01-23 11:19     ` Ludovic Courtès
2023-01-24 15:43       ` Greg Troxel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=rmiv8kv75i4.fsf@s1.lexort.com \
    --to=gdt@lexort.com \
    --cc=guile-devel@gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).