From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Greg Troxel Newsgroups: gmane.lisp.guile.user,gmane.lisp.guile.devel Subject: Re: mmap for guile Date: Mon, 04 Jul 2022 09:14:17 -0400 Message-ID: References: <56ee7537-1666-3d04-7093-732a75624e9b@gmail.com> <0cf4e4ee80169487694b844996e04f3293eab92f.camel@telenet.be> <87k08tfau0.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5225"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (berkeley-unix) Cc: guile-user@gnu.org, guile-devel@gnu.org To: Ludovic =?utf-8?Q?Court=C3=A8s?= Original-X-From: guile-user-bounces+guile-user=m.gmane-mx.org@gnu.org Mon Jul 04 15:29:23 2022 Return-path: Envelope-to: guile-user@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o8M8g-0001Cl-Hp for guile-user@m.gmane-mx.org; Mon, 04 Jul 2022 15:29:23 +0200 Original-Received: from localhost ([::1]:57754 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o8M8e-0000Tb-CJ for guile-user@m.gmane-mx.org; Mon, 04 Jul 2022 09:29:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34396) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o8LuE-0007UB-QF; Mon, 04 Jul 2022 09:14:26 -0400 Original-Received: from s1.lexort.com ([2605:2700:0:2:a800:ff:fe4b:be00]:54312) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o8LuC-0001ez-EG; Mon, 04 Jul 2022 09:14:26 -0400 Original-Received: by s1.lexort.com (Postfix, from userid 10853) id 7420B4106A0; Mon, 4 Jul 2022 09:14:17 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=lexort.com; s=mail; t=1656940457; bh=VZnOEZ8Iv7W0ZmNXr+wIY4eJqFqqh1eAt197ZaTkkuk=; h=From:To:Cc:Subject:References:Date:In-Reply-To; b=qrIRqbPOs1xLZMx2GP2MdQPSPUYzKOoEYNL5Ozy6Bw1spnlqAeADWGUU9Msvg0RkP bjg5Quyux9/6jEjt599vlA7NjM8GdNpJ/swL6FWyvxGrEOkV4afk/9eoSc0Nw+Sw8O YOspmjuw7NMrt/hSxPXHUPYGElMFyoZMGZ6fCN18= OpenPGP: id=098ED60E In-Reply-To: <87k08tfau0.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Mon, 04 Jul 2022 12:09:43 +0200") Received-SPF: pass client-ip=2605:2700:0:2:a800:ff:fe4b:be00; envelope-from=gdt@lexort.com; helo=s1.lexort.com X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guile-user@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: General Guile related discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-user-bounces+guile-user=m.gmane-mx.org@gnu.org Original-Sender: "guile-user" Xref: news.gmane.io gmane.lisp.guile.user:18392 gmane.lisp.guile.devel:21252 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Besides what Maxime points out, some more superficial issues: > > =E2=80=A2 In documentation, please refer to the relevant glibc section = instead > of =E2=80=9CSee man page=E2=80=9D (info "(libc) Memory-mapped I/O"). > > =E2=80=A2 Please update doc/ref with a section on memory-mapped I/O. > > =E2=80=A2 Make sure to follow the GNU coding in C: space before opening= paren, > braces on a line of their own, etc. I have been meaning to try to build this under NetBSD, to check portability. I think the mmap code should by default rely only on what POSIX guarantees: https://pubs.opengroup.org/onlinepubs/9699919799/functions/mmap.html As for referring to glibc, that reference only resolves on GNU/Linux systems, whereas any POSIX system ought to have an mmap man page, so it would be nice not to drop the man page ref, esp. as it grounds the implementation as being about the POSIX interface. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EARECAB0WIQS7wyAjWilQwVHG9Vsf2nroCY7WDgUCYsLnqQAKCRAf2nroCY7W DrScAJ4w0VjJpAnVEfav8o+H26B+tWKEgACdGg8G6RE0uFDg6VxzdFyDjZQOZek= =89XH -----END PGP SIGNATURE----- --=-=-=--