unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: Greg Troxel <gdt@lexort.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guile-user@gnu.org,  guile-devel@gnu.org
Subject: Re: mmap for guile
Date: Mon, 04 Jul 2022 09:14:17 -0400	[thread overview]
Message-ID: <rmilet9qaty.fsf@s1.lexort.com> (raw)
In-Reply-To: <87k08tfau0.fsf@gnu.org> ("Ludovic Courtès"'s message of "Mon, 04 Jul 2022 12:09:43 +0200")

[-- Attachment #1: Type: text/plain, Size: 945 bytes --]


Ludovic Courtès <ludo@gnu.org> writes:

> Besides what Maxime points out, some more superficial issues:
>
>   • In documentation, please refer to the relevant glibc section instead
>     of “See man page” (info "(libc) Memory-mapped I/O").
>
>   • Please update doc/ref with a section on memory-mapped I/O.
>
>   • Make sure to follow the GNU coding in C: space before opening paren,
>     braces on a line of their own, etc.

I have been meaning to try to build this under NetBSD, to check
portability. I think the mmap code should by default rely only on what
POSIX guarantees:
  https://pubs.opengroup.org/onlinepubs/9699919799/functions/mmap.html

As for referring to glibc, that reference only resolves on GNU/Linux
systems, whereas any POSIX system ought to have an mmap man page, so it
would be nice not to drop the man page ref, esp. as it grounds the
implementation as being about the POSIX interface.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 194 bytes --]

  reply	other threads:[~2022-07-04 13:14 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-26 15:37 mmap for guile Matt Wette
2022-06-26 16:21 ` Matt Wette
2022-06-26 17:06 ` Olivier Dion via Developers list for Guile, the GNU extensibility library
2022-06-26 18:11 ` Maxime Devos
2022-07-04 10:09   ` Ludovic Courtès
2022-07-04 13:14     ` Greg Troxel [this message]
2022-07-04 20:03       ` Ludovic Courtès
2022-07-05 12:49         ` Greg Troxel
2022-07-19 13:20     ` Maxime Devos
2022-07-21  9:14       ` Ludovic Courtès
2022-07-19 13:30     ` Maxime Devos
2022-07-19 13:34     ` Maxime Devos
2022-06-26 18:21 ` Maxime Devos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=rmilet9qaty.fsf@s1.lexort.com \
    --to=gdt@lexort.com \
    --cc=guile-devel@gnu.org \
    --cc=guile-user@gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).