From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Greg Troxel Newsgroups: gmane.lisp.guile.devel Subject: Re: Pkgsrc patches: patch-aj Date: Fri, 15 Feb 2008 20:55:49 -0500 Message-ID: References: <87tzketg12.fsf@gnu.org> <87y79puca8.fsf@ossau.uklinux.net> <87prv0sixe.fsf@inbox.ru> <87ejbg0yhj.fsf@ambire.localdomain> <87odajqv8s.fsf@inbox.ru> <87ir0r9yrb.fsf_-_@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1203126971 6474 80.91.229.12 (16 Feb 2008 01:56:11 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 16 Feb 2008 01:56:11 +0000 (UTC) Cc: guile-devel@gnu.org To: ludo@gnu.org (Ludovic =?iso-8859-1?Q?Court=E8s?=) Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Sat Feb 16 02:56:32 2008 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JQCI1-0003oD-ME for guile-devel@m.gmane.org; Sat, 16 Feb 2008 02:56:29 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JQCHX-00079a-OR for guile-devel@m.gmane.org; Fri, 15 Feb 2008 20:55:59 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JQCHU-00079V-NJ for guile-devel@gnu.org; Fri, 15 Feb 2008 20:55:56 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JQCHS-00079J-AG for guile-devel@gnu.org; Fri, 15 Feb 2008 20:55:55 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JQCHS-00079F-5t for guile-devel@gnu.org; Fri, 15 Feb 2008 20:55:54 -0500 Original-Received: from fnord.ir.bbn.com ([192.1.100.210]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JQCHO-0005P6-D9; Fri, 15 Feb 2008 20:55:50 -0500 Original-Received: by fnord.ir.bbn.com (Postfix, from userid 10853) id D7A7B52ED; Fri, 15 Feb 2008 20:55:49 -0500 (EST) X-Hashcash: 1:20:080216:ludo@gnu.org::1c0EVU9Nlciyv2eL:000000Lma X-Hashcash: 1:20:080216:guile-devel@gnu.org::xchF8aoJI8FnuVwE:0000000000000000000000000000000000000000002OBk In-Reply-To: <87ir0r9yrb.fsf_-_@gnu.org> ("Ludovic =?iso-8859-1?Q?Court=E8?= =?iso-8859-1?Q?s=22's?= message of "Thu, 14 Feb 2008 19:30:32 +0100") User-Agent: Gnus/5.110007 (No Gnus v0.7) Emacs/22.1 (berkeley-unix) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:7014 Archived-At: I am not 100% clear on this one, but I think the basic issue is that the code was defining errno always, and that could lose depending on whether it matched the system definition. Perhaps we need HAVE_ERRNO_H, but in general I'm in favor of checking for C99/etc. and trying that, and only if not found trying to work around. $NetBSD: patch-aj,v 1.3 2007/07/20 00:09:23 gdt Exp $ --- libguile/_scm.h.orig 2007-05-09 16:22:03.000000000 -0400 +++ libguile/_scm.h @@ -119,7 +119,9 @@ # define SCM_SYSCALL(line) line; #endif /* ndef SCM_SYSCALL */ -#if !defined (MSDOS) && !defined (__MINGW32__) +#include + +#if !defined (MSDOS) && !defined (__MINGW32__) && !defined(errno) # ifdef ARM_ULIB extern volatile int errno; # else