From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andy Wingo Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCHES] various commenting, whitespace changes Date: Mon, 28 Jun 2010 15:44:54 +0200 Message-ID: References: <87bpazfgsq.fsf@ambire.localdomain> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1277732570 8228 80.91.229.12 (28 Jun 2010 13:42:50 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 28 Jun 2010 13:42:50 +0000 (UTC) Cc: guile-devel@gnu.org To: Thien-Thi Nguyen Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Mon Jun 28 15:42:43 2010 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OTEbd-0006Kb-AU for guile-devel@m.gmane.org; Mon, 28 Jun 2010 15:42:37 +0200 Original-Received: from localhost ([127.0.0.1]:59867 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OTEbc-00036S-Ot for guile-devel@m.gmane.org; Mon, 28 Jun 2010 09:42:36 -0400 Original-Received: from [140.186.70.92] (port=40991 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OTEbU-00034T-EZ for guile-devel@gnu.org; Mon, 28 Jun 2010 09:42:32 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OTEbS-00080m-MF for guile-devel@gnu.org; Mon, 28 Jun 2010 09:42:28 -0400 Original-Received: from a-pb-sasl-quonix.pobox.com ([208.72.237.25]:49919 helo=sasl.smtp.pobox.com) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OTEbS-00080g-KW for guile-devel@gnu.org; Mon, 28 Jun 2010 09:42:26 -0400 Original-Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by a-pb-sasl-quonix.pobox.com (Postfix) with ESMTP id D2642BFA6E; Mon, 28 Jun 2010 09:42:25 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=7y8Crgj0Fi9KPxKcrc5K7W28rvI=; b=ZFtKOL RIKzY2TYIhBjRIH7/YN4cCkrjNVh6G5EOepKHee4sDEWvVOtmcuEKKD5vTD5U6dK Uf6bYeteZ7DWachhyGvBJ+Atohg0WwJFxP625zpZ4NDK9QctKfrMSAP1C5OTDvJA /6Gy25+0jKrgHcn/5kDGhYfNYnqjbM9HVmLYg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=FrLVV+sN0rp1/L/rMefBVpomPaKeDlbE QG6wp0mWruPWCpIdb8ATd6wv9Qu4mDH2awo3HrDSK7hn9RZOGyvlwM0qq2fLjgPF 3Ouva4+hrrOshr9NZ5m/bl5LPAXs5llxvDlTh6N+ctKSRbkD5kAXMywhzBXrXQsL e2vGIc+ByTc= Original-Received: from a-pb-sasl-quonix. (unknown [127.0.0.1]) by a-pb-sasl-quonix.pobox.com (Postfix) with ESMTP id BB17DBFA6D; Mon, 28 Jun 2010 09:42:24 -0400 (EDT) Original-Received: from unquote.localdomain (unknown [83.202.24.141]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by a-pb-sasl-quonix.pobox.com (Postfix) with ESMTPSA id 4826BBFA6C; Mon, 28 Jun 2010 09:42:23 -0400 (EDT) In-Reply-To: <87bpazfgsq.fsf@ambire.localdomain> (Thien-Thi Nguyen's message of "Fri, 25 Jun 2010 14:16:53 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) X-Pobox-Relay-ID: FBFA03BA-82BA-11DF-BC0A-9056EE7EF46B-02397024!a-pb-sasl-quonix.pobox.com X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:10579 Archived-At: Hello, On Fri 25 Jun 2010 14:16, Thien-Thi Nguyen writes: > From 9c6b71e9b3334439ae6348b38412ae6a8fb154ad Mon Sep 17 00:00:00 2001 > Subject: [PATCH 3/8] Comment, whitespace munging; nfc. What does NFC mean? In general I'm a little uneasy with this kind of change, as it is unnecessary. But, OK, I guess. Please feel free to make files more closely follow GNU conventions, when you are working on those files; but do avoid a general cleanup. I think it would drive me crazy ;) Perhaps Ludovic will chime in later with more general feedback. > --- a/libguile/guile-func-name-check > +++ b/libguile/guile-func-name-check [...] > BEGIN { > - filename = ARGV[1]; > - in_a_func = 0; > + filename = ARGV[1]; > + in_a_func = 0; > } There is no need to change the indentation amount here; 2-space should be fine. [...] > +# guile-func-name-check ends here I would rather not have these markers. It's an extra point of bitrot. If you really want the end-of-file markers I would want some confirmation from Ludovic; otherwise, I am OK with you pushing these patches without the EOF markers and without changing the awk script indentation. Cheers, Andy -- http://wingolog.org/