Re: [PATCHES] various commenting, whitespace changes

[Andy Wingo <wingo@pobox.com>]

Hello,

On Fri 25 Jun 2010 14:16, Thien-Thi Nguyen <ttn@gnuvola.org> writes:

> From 9c6b71e9b3334439ae6348b38412ae6a8fb154ad Mon Sep 17 00:00:00 2001
> Subject: [PATCH 3/8] Comment, whitespace munging; nfc.

What does NFC mean?

In general I'm a little uneasy with this kind of change, as it is
unnecessary. But, OK, I guess. Please feel free to make files more
closely follow GNU conventions, when you are working on those files; but
do avoid a general cleanup. I think it would drive me crazy ;) Perhaps
Ludovic will chime in later with more general feedback.

> --- a/libguile/guile-func-name-check
> +++ b/libguile/guile-func-name-check
[...]
>  BEGIN {
> -  filename = ARGV[1];
> -  in_a_func = 0;
> +    filename = ARGV[1];
> +    in_a_func = 0;
>  }

There is no need to change the indentation amount here; 2-space should
be fine.

[...]
> +# guile-func-name-check ends here

I would rather not have these markers. It's an extra point of bitrot.

If you really want the end-of-file markers I would want some
confirmation from Ludovic; otherwise, I am OK with you pushing these
patches without the EOF markers and without changing the awk script
indentation.

Cheers,

Andy
-- 
http://wingolog.org/