From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andy Wingo Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] Fast R6RS div/mod; improved extensibility of numerics Date: Mon, 31 Jan 2011 21:46:35 +0100 Message-ID: References: <87lj221hn7.fsf@yeeloong.netris.org> <87vd15x9fu.fsf@yeeloong.netris.org> <87aaigyfxi.fsf@yeeloong.netris.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1296506510 23581 80.91.229.12 (31 Jan 2011 20:41:50 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 31 Jan 2011 20:41:50 +0000 (UTC) Cc: guile-devel@gnu.org To: Mark H Weaver Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Mon Jan 31 21:41:46 2011 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Pk0ZF-0002Ph-O3 for guile-devel@m.gmane.org; Mon, 31 Jan 2011 21:41:45 +0100 Original-Received: from localhost ([127.0.0.1]:49689 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pk0ZF-00044j-7f for guile-devel@m.gmane.org; Mon, 31 Jan 2011 15:41:45 -0500 Original-Received: from [140.186.70.92] (port=44608 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pk0ZC-000446-KY for guile-devel@gnu.org; Mon, 31 Jan 2011 15:41:43 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pk0Z6-0006ST-Sz for guile-devel@gnu.org; Mon, 31 Jan 2011 15:41:42 -0500 Original-Received: from a-pb-sasl-sd.pobox.com ([64.74.157.62]:39400 helo=sasl.smtp.pobox.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pk0Z6-0006SI-QU for guile-devel@gnu.org; Mon, 31 Jan 2011 15:41:36 -0500 Original-Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by a-pb-sasl-sd.pobox.com (Postfix) with ESMTP id D039A4008; Mon, 31 Jan 2011 15:42:28 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=EzuKjO9X3GKCBUR2sX5Hx9VfL9s=; b=Gik9f6 V6LnVONJAX8+Mk4UCZqs7zlKVBExiKfS5PvAXcKk6KAtlesnPNAEdDHHaaV6abnK v/ya/13jeWNsD2l6l8miCFxSvZHZ+cZvdCAKNZPpcSXUdZwp7jYLAKu6eZLZDbYp X8ON3zajYBZCELaa3qr9qJUvipDe4OAM3N2n4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=wXbydNAAuDq+Kkj1pJYBxEKC3KRJiJsa iY0rQ9XdSmbIm/F+sGHQ7003qc7NMmVeTdNS3lPYsgOjbCBUTGe+Hdu+F0qVzIjs Ucny/Ngl/0TpsHY3ihDFFsOPACdoxs+FiBm055xzVu/TT3yUNOqHhzCUAqmJ7yH/ TM0lIn7AS24= Original-Received: from a-pb-sasl-sd.pobox.com (unknown [127.0.0.1]) by a-pb-sasl-sd.pobox.com (Postfix) with ESMTP id BC8594007; Mon, 31 Jan 2011 15:42:27 -0500 (EST) Original-Received: from unquote.localdomain (unknown [90.164.198.39]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by a-pb-sasl-sd.pobox.com (Postfix) with ESMTPSA id 281184006; Mon, 31 Jan 2011 15:42:25 -0500 (EST) In-Reply-To: <87aaigyfxi.fsf@yeeloong.netris.org> (Mark H. Weaver's message of "Mon, 31 Jan 2011 15:30:17 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) X-Pobox-Relay-ID: 9DC4EEF2-2D7A-11E0-908E-F13235C70CBC-02397024!a-pb-sasl-sd.pobox.com X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-Received-From: 64.74.157.62 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:11464 Archived-At: On Mon 31 Jan 2011 21:30, Mark H Weaver writes: > Andy Wingo writes: >> I did apply it, but it made the test cases start to fail, because >> numbers.test is loaded after ecmascript.test, and: >> >> scheme@(guile-user)> ,L ecmascript >> Happy hacking with ECMAScript! To switch back, type `,L scheme'. >> ecmascript@(guile-user)> true * true; >> $1 = 1 >> ecmascript@(guile-user)> ,L scheme >> Happy hacking with Scheme! To switch back, type `,L ecmascript'. >> scheme@(guile-user)> (* #t #t) >> $2 = 1 > > How could changes in `expt' possibly affect (true * true) or (* #t #t)? > I don't understand what this has to do with my patch. Sorry, I wasn't clear. Your patch replaced a test that expected `(expt #t 0)' to fail with one that expected `(expt #t 2)' to fail. I assumed it was because it was treating `(expt #t 2)' as `(* #t #t)', but I could be mistaken there. You can see this error if you run the full ./check-guile, not just ./check-guile numbers.test. Cheers, Andy -- http://wingolog.org/