From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andy Wingo Newsgroups: gmane.lisp.guile.devel Subject: Re: Patch: New section "Invoking Guile" for chapter "Programming in Scheme" Date: Mon, 25 Apr 2011 10:01:39 +0200 Message-ID: References: <8CDD0063C9BEB29-FC8-5987@web-mmc-d08.sysops.aol.com> <8CDD0D662A18273-1820-10289@webmail-m029.sysops.aol.com> <8CDD0E1EF6EF23A-1820-110A6@webmail-m029.sysops.aol.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1303718522 20669 80.91.229.12 (25 Apr 2011 08:02:02 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 25 Apr 2011 08:02:02 +0000 (UTC) Cc: guile-devel@gnu.org To: Mark Harig Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Mon Apr 25 10:01:53 2011 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QEGjw-0006xO-T0 for guile-devel@m.gmane.org; Mon, 25 Apr 2011 10:01:53 +0200 Original-Received: from localhost ([::1]:41858 helo=lists2.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QEGjv-0004RS-Ug for guile-devel@m.gmane.org; Mon, 25 Apr 2011 04:01:51 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:36433) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QEGjs-0004RC-Qj for guile-devel@gnu.org; Mon, 25 Apr 2011 04:01:49 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QEGjq-00027l-Sd for guile-devel@gnu.org; Mon, 25 Apr 2011 04:01:48 -0400 Original-Received: from a-pb-sasl-sd.pobox.com ([64.74.157.62]:42898 helo=sasl.smtp.pobox.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QEGjq-00027f-Ol for guile-devel@gnu.org; Mon, 25 Apr 2011 04:01:46 -0400 Original-Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by a-pb-sasl-sd.pobox.com (Postfix) with ESMTP id 2F6DC2D68; Mon, 25 Apr 2011 04:03:47 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=10NoYwGCjybLwauXys+/qIoYI4U=; b=oqB9v0 elLizUoy80eRS4yI0aeVoXa228bNdrbq6de7ouiyzmzvKTA+2da67osSMSI9Gtw3 gtahJ4Trfz8V3NkUgyDQP5fu0Oxmzs9ZfXJaB/jVP/V6j508eoKejOwoTPBJIKcW hPUZG3fJ1aLYFlVGI5ZkofHjFv+D2Rx3JiwDU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=pOSq9kRX8FThL3qwIoPMQvoKMtXWx5O7 ybeTyrzEKgF97u7qL7+PVGxNFeZ5+oZr4j49QiFhR0gGUM2EL1sNzI35Nvan4oQC 06NikvR7/Cur5Cv7Qz89Xob3WiRf+sYgnNE6v81VRkw1ksP3L42cKD7Qo66/hgF9 8CGqxvEggrM= Original-Received: from a-pb-sasl-sd.pobox.com (unknown [127.0.0.1]) by a-pb-sasl-sd.pobox.com (Postfix) with ESMTP id 1C7892D67; Mon, 25 Apr 2011 04:03:45 -0400 (EDT) Original-Received: from unquote.localdomain (unknown [90.164.198.39]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by a-pb-sasl-sd.pobox.com (Postfix) with ESMTPSA id 540142D66; Mon, 25 Apr 2011 04:03:43 -0400 (EDT) In-Reply-To: <8CDD0E1EF6EF23A-1820-110A6@webmail-m029.sysops.aol.com> (Mark Harig's message of "Sun, 24 Apr 2011 17:58:53 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) X-Pobox-Relay-ID: 8AD3BEAC-6F12-11E0-9638-E8AB60295C12-02397024!a-pb-sasl-sd.pobox.com X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-Received-From: 64.74.157.62 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:12337 Archived-At: Hi Mark, On Sun 24 Apr 2011 23:58, Mark Harig writes: > On Sun, Apr 24, 2011 at 11:00:16PM +0200, Andy Wingo wrote: >> >> Right, at the end of applying all of your patches, I'm sure that's the >> case; however the first patch adds an @include without adding the >> appropriate file, so applying just the first patch without the following >> two would yield a project that doesn't compile. I just meant that you >> need to squish the first two or three of them together. I can do that >> when I apply them, though. >> > > What do guile developers normally do when generating the > patches? ('git format-patch origin' is generating three > separate files. Do you concatenate the patch files that > 'git' emits?) Please let me know if there is a documented > recipe that guile-devel uses that I can follow for future > changes. We use git-format-patch, yes. The separate files that it generates correspond to the separate git commits that you made. In order to generate an atomic commit, you will need to squash your patches together. To do this, do an interactive rebase in git. Interactive rebase is described here: http://book.git-scm.com/4_interactive_rebasing.html You would "pick" the first patch, then "squash" the next two. That would yield one atomic commit, which would then be written by git-format-patch into one atomic patch. I highly recommend reading more, experimenting, making backups, etc; rebase is wonderful once you get the hang of it, but it is a sharp tool. Good luck! >> > +For compatibility with some versions of Guile 1.4, you can also use the >> > +form @code{(symbol ...)} (that is, a list of only symbols that doesn't >> > +start with @code{@@}), which is equivalent to @code{(@@ (symbol ...) >> > +main)}, or @code{(symbol ...) symbol} (that is, a list of only symbols >> > +followed by a symbol), which is equivalent to @code{(@@ (symbol ...) >> > +symbol)}. We recommend to use the equivalent forms directly since they >> > +correspond to the @code{(@@ ...)} read syntax that can be used in >> > +normal code. See @ref{Using Guile Modules} and @ref{Scripting >> > +Examples}. >> >> Again, probably worth eliding the deprecated 1.4 stuff... >> > > It's not clear to me what you mean here. Please provide the > text that you would like. (I did not review the > "command-line options" section for content because my > original proposal was to keep that section and add a missing > "environment variables" section.) I recommend removing this paragraph, or removing mentions of Guile 1.4. But as you note, that could be a separate atomic commit, and you don't have to take care of that now. >> > +@item --auto-compile >> > +Compile source files automatically (default behavior). >> > + >> > +@vnew{2.0} >> > + >> > +@item --no-auto-compile >> > +Disable automatic source file compilation. >> > + >> > +@vnew{2.0} >> >> Need --fresh-auto-compile here too >> >> > +@item GUILE_AUTO_COMPILE >> > +@vindex GUILE_AUTO_COMPILE >> >> Need to note GUILE_AUTO_COMPILE=fresh, and @ref to Compilation >> > > I do not know what that option does (other than a guess). > There has been no update to the Guile manual page or the > reference manual mentioning it. Are you working off of the "stable-2.0" branch? There are updates there for --fresh-auto-compile and GUILE_AUTO_COMPILE=fresh. To rebase your work onto that branch, you would do a "git rebase origin/stable-2.0". Regards, Andy -- http://wingolog.org/