From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andy Wingo Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] Add new debug meta-command ,error Date: Mon, 30 Aug 2010 08:01:32 -0700 Message-ID: References: <1283143931-6220-1-git-send-email-jao@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1283180335 23788 80.91.229.12 (30 Aug 2010 14:58:55 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 30 Aug 2010 14:58:55 +0000 (UTC) Cc: guile-devel@gnu.org To: "Jose A. Ortega Ruiz" Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Mon Aug 30 16:58:53 2010 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Oq5oz-0005Jg-Aa for guile-devel@m.gmane.org; Mon, 30 Aug 2010 16:58:53 +0200 Original-Received: from localhost ([127.0.0.1]:50335 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Oq5oy-0006or-QU for guile-devel@m.gmane.org; Mon, 30 Aug 2010 10:58:52 -0400 Original-Received: from [140.186.70.92] (port=55161 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Oq5on-0006k5-Qb for guile-devel@gnu.org; Mon, 30 Aug 2010 10:58:44 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Oq5oR-0004z2-5I for guile-devel@gnu.org; Mon, 30 Aug 2010 10:58:20 -0400 Original-Received: from a-pb-sasl-quonix.pobox.com ([208.72.237.25]:61721 helo=sasl.smtp.pobox.com) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Oq5oR-0004ym-2L; Mon, 30 Aug 2010 10:58:19 -0400 Original-Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by a-pb-sasl-quonix.pobox.com (Postfix) with ESMTP id 21903D1E1A; Mon, 30 Aug 2010 10:58:18 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=Scv7ZHGlfDsyvnFNAOUTwRASOLo=; b=H0CTUW 789uqIKzMkLrENgIAo/D+jRGbQRCocPn+VCY5DRBEJ9PZuaZRZPcu4Uyqr6gUa6E DNx17rLAMfD7lBAoxPpePbv3EtVN2gM03D9P+BDJqpCj3+onrUMeLSp9hZNmqD+r 8o7V91bMJGH7VAk6M3ODq9agQ0cuIc4sViRQc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=vZ8Y2Ne16IBq2TK4xL3tkZCrilpiIpf5 ++lXaqM9PNAH+tqArY7olbZuHjzBzATj8yvMdyaufPpfLsljSUbqgYC4QMowBDzq d5mFMeH+oSG3o5b299+AywX/twnW3N0jCVxAxeK7C+u5uKaarCRHpdeQmr7/fX2Q vzfEV9OoDuk= Original-Received: from a-pb-sasl-quonix. (unknown [127.0.0.1]) by a-pb-sasl-quonix.pobox.com (Postfix) with ESMTP id 0DED1D1E17; Mon, 30 Aug 2010 10:58:17 -0400 (EDT) Original-Received: from unquote.localdomain (unknown [75.28.21.123]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by a-pb-sasl-quonix.pobox.com (Postfix) with ESMTPSA id 64741D1E15; Mon, 30 Aug 2010 10:58:15 -0400 (EDT) In-Reply-To: <1283143931-6220-1-git-send-email-jao@gnu.org> (Jose A. Ortega Ruiz's message of "Mon, 30 Aug 2010 06:52:11 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) X-Pobox-Relay-ID: 05609BA4-B447-11DF-BDCB-030CEE7EF46B-02397024!a-pb-sasl-quonix.pobox.com X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:10810 Archived-At: Hi, Thanks for the patch. Only one small comment; feel free to commit when you're happy with it (I think you have access). On Sun 29 Aug 2010 21:52, "Jose A. Ortega Ruiz" writes: > +(define-meta-command (error repl) > + "error > +Display the original error message." > + (let ((debug (repl-debug repl))) > + (format #t "~a~%" (if debug (debug-error-message debug) "")))) > + Perhaps use define-stack-command to handle the no-debug case. In any case if there is no debug, we need a better message. Thanks, Andy -- http://wingolog.org/